From beba5b77bcb896d5bd6cc9f45af54a90cc979062 Mon Sep 17 00:00:00 2001 From: jennyhickson Date: Wed, 22 Oct 2025 14:53:13 +0100 Subject: [PATCH 1/9] rehash review process --- .../gh_screenshots/project_scitech_dark.png | Bin 5113 -> 14989 bytes .../gh_screenshots/project_scitech_light.png | Bin 5132 -> 14862 bytes source/WorkingPractices/pull_requests.rst | 99 ++++++++++++------ 3 files changed, 66 insertions(+), 33 deletions(-) diff --git a/source/WorkingPractices/images/gh_screenshots/project_scitech_dark.png b/source/WorkingPractices/images/gh_screenshots/project_scitech_dark.png index e94a431e54cb81775f26026190c45203f5499633..46c6b981b4755fde2622947c61036907c4a13436 100644 GIT binary patch literal 14989 zcmdVBWmH_j_br$N0t9b7!4f>d-7P=}5S+%{gS$(DOK=OG;53ax;}C*01cEo#xVtrt z%XEJ4&CGjm)|zkgpP3K0Zrxh9`j&OoKKtwwt)?Q6hy4os$&)8|3Lj-Po;-Ovg1W@8 zFi<55?dk=n+f#Q9`S(w%MyPgC59l`1%F<7s)F$BEnLS56zi|1e=l z$&)7{bPBT4T0X{yiv$6Gk!zAC8D4U9y#kKu@0I!Z<_#4DNv8$ZA|}{3m-!c4$Ahyp z3zS?!Q(T=;(O<$JBH|xXdfJwM?^#gQHRp zhup+aS(TBF?p;^V^(L-LzDTr%e8SpQZK0ptAUah}hN0hEI{Iqaw0FP8Y2#Nm28o3b zh|wD(I=X_h3Vq~W8E~Ixs-vAIh`c-_qls2BSE6#6pIFW1kH!{ExvKl?{jHjAVs$AI z000z2%Jht#{HZuu7H?D3x?zLFX{Pg8*&fZM^^7sl6=17cXAbjaI`XW4BBji!^V3e} zQ_T~qDkVf!b>Nw_gbaS;1zNiNd8a>DGMLPSDiz>?TlNovdDT&+OZ9d1s5jNE7+!aW2S-_fqr#xc>HEpNB$5O*c8J1Zr5sW3<9@~r!w~N3_7E^w z*$-6gee6Hprt0hfhv0F>1*xmDFX0LHn)ePQ33=|3RK>X4^24<9Y4>u0)m=`;v~ukNV;kl zz*^|WGjbd7=YSmL$DD7zCXW3V9k)QK&88sk<;m=e5Nx#{m#(fP3p@HmT#hW+p!Le9-mOi?Y|-bzkRu z#+?lxtUj$0akqHUGMd-J^y#>8oB1qJXrr1!#4?J8l{SPdr;a|+VX}cB*kReYgPfFf z6KSj-YN)NymvDnM#DphxTd}uJbQeX;9KYT>xUANwjsA+iyn6dj&t-Vmv#y|odw*n6 z%nw)~#ce+Sz-%Llf?u-R31N_08-n^`M`8O@@BR0>D{3(~!cW#vo3v|iojoF74Gmds z_btK?!ZW_9@X6$c6cQj_8Ind9)TesWTy|`}STPp#i(y!yLlUd_H>&Xun+-RdhZTXO zJ>|SMu#I{f6_L_hAy=Z(VD*&fg>SUC*!>J$VLHk36*HT1VBlehQv7(0*JD5s z0t*CFA$&XO#sodz_A?oNO{_Qf6XiCdt@~4^v&Z!56P8TSJXga@5By;NcncHtPS&vK z>U&gEuD;OJxAWdgQao%-`hgEpvqz-Ql8ER0rzNO_T%V2l_&6&~B<41e5YC9#Z z%+P8IEZ68`=VQKer+fIBznU?*;qR7*cx&7JHh(fTA!j!78nIP=X-VkUsWWAIHeA|9 zwNWm~r$tMB6Zb*B3u)THEk0CO**7kbk`~kH9oN4W=U=P(?HHaN-B)-_w27{+LDBVW zdB08$$$A}&$*RCdPm^8c*1RmB^?9gY5jZyd0Qj>{D|*z8<*eb z68__djw|b3+XY4e_JZSzkCWTt-pfr+&}9*MoEoo+AQS5Rgwy20xrN?MnAv?xq6N#a zI%g`~rP(azEaObuC7M{(mX~dKtv&c!r(;6#+wGMT>*>eT!?F0|5Qk9Xlo)wnWF6Ki zbxr4tiE`bcT7~PC)}g(~K?MWoAF>;O1M!N4AMJw|1GbPm_LL!JBvg~p< zHuo`OpSX+vo%qWr=R5yoUcOQle;kYcIOwd-<4XZfw`qqhg*}x+FC%~%tVh4NA3M1cI1moND4Txbh|v`@h_l=?E3qon=_rbyBNhv4 zEF4GfW+XCH1B<UDs9aT-1#Wv$>u<=1c+qx|+6q@4P1r(zbxs zI2Yz{Qu^QB%l(eJVKX@}EPPB?nfiA}5Y;3$fS;8KZ58tzr0+k5R=XLJ8PHyL_MVBnhz2f*#ENek8L@EZr6 zTTY1Pw?8;*$%2@Lfg8@V)$z+-r_nAAFS%YE@2qcYP*>(>ed*#8`|5ldz!`7DAJ+8p zTdgzO?*pAQe0EDZotaE@+?`yBMjUl*HlPrEkCBKmgVb1bA0oT@HV^>k>Tw-QFAfUdd!=XL#i33Qi3$xZC7A8XTGB5=})wo9-$+QQQF@$$>dvdMmYY|g+ z5$hq4MH*$(4~$}SyNX&mFtYSpjM!y|!dMp+0Dns`}odVaA%7R7M-68o#~Sd z!U;K-0pT{q$G|pULvIgC0piT?E;`u=V-wfQ)*JWB2{Uy&qj-Av+k(T&MHd4Hli|6y zLzg~PH6k*^x1Fvfp zLD%W`1bUA-OTH=TN((2pdoTp6A&@=I{B|K3ktTsOMwDSugo-^;_>R3^-ZH=6%-+oTbZUw+%wE<;G^>%%p}9S!IXopaR)(`X>4IWnU72wM14#w; zG;+=_{Ow;G{Fc%8`1NF41hY`{z=}uwWbk}bDstb|6OX&)M6-RNDpmylh2Ua*Bs7qY zsj9m<$UInQ1EjhpOSYtOD{0v4=G=Y`Zhrj$!Q(x$ue?AwwcPil$9Tr9&ot6v=;u#x z$mG(ypMDXWZh~~9xqE?#+;f{LUFZHJH7n&@hI!?laPFfQ`nG$9IDd000u?oNuy>)k zQ8yJhZZmVkwaw3~U*0%AlEF7>>`C*wTJVF|KS8@bND#2@J)6UX;ziAtG0jPs97N& zVx*d8OR$8!J}s1luVhW%D7o0<7y^}YAd8v0+8B=Y%2jPt`_RRNtAUR;lsoao>tm|H zHk**8^b>)p>YwUVL|U$Ota-j{PXWL__Kk=c7iSCc<4VD`R!RI*r_ofwB-j7D9+m2a$G98}lCmEFV0GMB5 z-bY3N5m87}N&8oSzYDeXllq3tT8q9nCx~oQc#KawMRfQ{o30N z{obY06nEWcy&YIVOILuBf%5_3Z-qSFd&@DU8KveMf!u2ofrKUjM?&O5=griWR^`?D zIJkxk74zp@h0Iz_Jg)Q};de8;xB|gq`Z;<^AGT<8ZF~r{J03c93q1%Cbzriy#6-!m zU;+~T;zjGrz%RbU5i9t5WlQ(MohLd2?wX_-hT4=FgFin2@2(DUaX-T-iD!13&=yeZ z=p#GeX8Nxb>q2QvHZ-x*AvtSJY36DRWG4hhNG7i8dM#myxfZerV|(sJTR9kiJvi?D z*jVA(abtWgy}v`a5iE|mk1cCfF^B}ce7%;w1!`!w=?S2|DMr{&8;afEY~M5+ka5g~ zFv)0g2hY8-jLMG7-3>Lnf5p*Vd?vIwPbw%tL_W$($%RM?78xye=68V`aF%Be`9CaZ zcI5GT2PIK|L18Hxg`kpUv?J=Mk#HP3A@;V@RaSyE$kydr8YiO92d{VG()M(eH1A5< zD5w1{;E&f&p{V5zxz2B8cCB-RJIlgkIwp5$UN%*~4mdq`L9(DVg1wRhp?JUhfn}&M z|6ftU(VRLH?7x?%E8D!M9+v{mn@Pg6Z?Spb;E7nQEN_V4T7SB>Ed-Ip?fT?{umkS4 zrq|XyFy>5#8#yeq^Pvcf$=5Q8VZMIBqG~SMg zK9^(B?fvf`ZCvIdx0s_3s$F&M_XqXg-#B3hRRY2<0!@Am!~9SG-r1lzU?g_f(F5{N z(6_ekqF(*QT*I3)E?LI&p-m4C!>e;@oyOZ?z{!obn@6)h=>!&TY61fzgI1JGhVs4& zS6J$~#|bT+c@sr!9m>@@x#VD_5zi(ig?KLK5i%DGi$o1}SZrKh;m-{X(Fw>siCys! zr3OWt2^iCiy%aPI1cU4rSlC1?DMbD_NW}tIwyy?oCEBcWLT? zk3Z}HiMPe0>pX}K;B2w=l$VW}vFm=}7b-$QmdD%W#~PP$Odp3?m%E3yG55st*<8e z!u_v8AJ=TBQP#BivVBjpF4{O)1F_IeN0!5#p_b??@eiu_VCw6&{2H4*9G}zY zqh{~4_w*DuSL7+!ov^ERr)W7x4dWj3$|Fv)AL64q4M?-U3N>5NCb0S1?zK z$7%Rq_Z{`P6$LTL9Pu<9T-DTPX*U8YE@QQexfY>yCcn@Z$68$uwbi|zS2+aX-1M77 z>f1mp?mbNVZw}W=EbOmkf5uD^s8di6n-Y%f0f)or@g8HRa`Icb`G^Ku^+4C?pvoT@>PV7iq?{*I?G0l!X!!bCiK2k z*HvEBKnV8sG}wc*Bs~&?G1uf>)$f9*8zy#;^Upp77t~i?g2p&r93sQ=Rm%(Mb_7K9 z+S7= znY%s?9R;iX_}n%4{X|e)<6TpMv*hBC+oj?sTI6et;l-+@7qNVI)t6K`VH+>APf~;g z*>4yv8t$qn4tlmOC*Rn2?Du-~^VT)*+R}6U))B75CyP4Z85S2pS^K;x#{G+aB+kKK z+0QU18t5?u2#8~sSUMGc-^I;(3ZTy{+z=M@c{4v|lS=z@oMrj#`SM&_d_l}`fkJOD z?H}|VfF{QfAJb`>qvPuui-G0DR=I`Bsi^KBf(~7gjiNOs5AYfs8gKjlXep=-^D1M- zbzE5;<~A*1P|uV0bO?T%myn1>kwtsJELGQ<={(h)(x~3nRzN)a8I;P6{iZWNS~a8c z*F5m8ZKc83oxvAn(Y^$I+tU;1n)^^9wO&z5;_EgAF{_G$gVF_coom z`x#aKrfQd&x7H)Q!q&WT94K>Fd0G~aHhYqE7(%;9UJWK<%p@JEk);j=G|MfiQNiOq z?JM;X-G70E%YrG5b(`J~^J0#g6FqP%dHG;VhlaUc1r!Q#_?hU$A4YFwRH&vWvs8+4 z!&?p*ho(&*LT93PZED?P585rQ5zUrt$+;t-#$P7JH0(|(xEE%KfPfBz0D%VTwO4cV zQL#1Fcb06A#sMGDp@}W=7VQ|z;M_Rq1IcRZi*66_G80j|z9yfe57~0bXoI3IW`-Gp z=7-;8NkJHMg>&eo*!geewmw%veX(x|(@}?pwfN4DeF&yA$97?FVwGqv=P_Sg?W6f0 zoy&E>zr6B;f$z}XqM2wxr5cUe|hikJ{!CC-j77mge1n^pi#>90d?l)B}nFZb3Nx&R)ntd+Nd`^G}^*;H14*J zRWlrEB5Azwdcf5e(Mq|xP7Z8U37~k*+X-&_S)-AotKvp`7&ds$mykKA(vJFgNY?zp zhfs88xc8*3bscysw>YlwQ7F3}yZj;~nPt&|y%}qDrjJhB0kyyWT0I~*{qyUVy9aQB zF!>esTv+JA9?R~7QNoTN@HG2-PLkM@(EegGo7IS(_b_KU@#TpT9p|!}bf_z4Auxe-mv145b=xn;4WdE9c(P5hSrnxo?Kt~*7@fc<@7mjOR0 zoOt;d5m@mqp?i7hJp{z`$jVe9>Fq=4jf0PXj=I)}5`Q*~bu*qB4s zBjPxG?v7n2d`S{&?a5ZY+6VVU%!sUvLN1i)3f#jV#Z^FDbQqHHZB=*x#)(g0b6X2go4s)**3X@&7hBHCYEeu80Pxb(1x334zmjSbc4!E`5p)(#J{JN2a%rV; zM;HQfGMG6oF3gBaF2|j9m(Vt=Y?NiY`YX4^|y z5$CLEN%N3=e-&N!afZt=Hprwlq_JqVK*eYNx|3u-J5<&*%TaQZON`xQRMXh1%^7jR z_u5QDSg1tSgJZychwziD5n72g{U<{-io8CY_bwOx=lhg+;85X{DBak1% znJ;+lSy~Z(k+J&=8Q+-K0iaao%?J~v3fGJM#N}j-^c27v)>)n1j)&g>gQ`&l1+*w zCm#eJ&L=TD<;hSMWYRGItNHe0hBx~QwEH~13S*E8YCvPNA;V7gRBVe!A*mc^|{ zUp)NR64Tc_hkp9e?BlF8u`37m7Y4#Aj3$u6_QGirXkVD=CB98sjjdp*nSW5h8QxmVFIB2h+2sbdm!U_F+x z$F8(x6q+wFTYP^*Ssl3rbR4R*DpC5CKrzPjBuyDU*WFK|R z3E#|h4MZ=}^i1CszlRV$hrn^B&Oh)7wkd9QH2Ffh?4v_jVM=a34=(|EZd$DWks6gd z4H8D+Jorp1?|8IfLFq7rN2|N;3MA#U#`T^*bI_ywh2+CEVva}eZw~6Jd!3Tm_=1?8 ze6EVzO(G%N+7s;{$mlI7LGIw=jNd$NUC{Pf3H;CxBpF=wn^!0|wAZXl^WYnZGXt|{ z!$}IgaD7ErgG&?AVdM(TgtZwkR(t~2G&YqmH2kVF3?&RxJDI$Rm3<&>aPQ(?7baZO<`wkr_x-QR)HqYF$)xlL_w+qj2gYvQc& zh#p2-WClJA5ORv~10l-o$;IYn{XCrtB?Ko;D4n0cJ6)`p&ief3;fg=cP(6JBU$Ko`MT7Zq^*=hP{%9}iPtDi$&;;=xz7|<@8k~FqT zEU>QOd09f+i{Jy8PaT6+I`Rm_K586;S66gVSD#wlCX|p21QavFE=(=h-IH{hF_%89 z?g1+sAIqT9}Jr&OQ0ttM;b|Be* z;aue0JXJgR;RcLm9_TnG_t=~z7jxYIGcafdsBs-hU~w}g=z2D#Al@g3VloDOqyFGD zl_W&3mCPWvW{;60AOY$LjfG)+f`*F`gh=C)Won{FAAY0{3n*eh6))Z9Z(bLrdqu(r zp;y=7R~!b?cq*8rKU!H#4EYNRm*$t0TZd^66JZ?%w)w~7A70g5-~LcZS}!mzTC(*B z57Nuoi8yqRun(5ipWG-_;28Ki|<+0RF>TM(`~Q>tXSa@ zSo+ne%~Nxg+R9*zfETX9VGY zYhMMVF?hOv`i51oYNa={rTS||C^Eq3f)^+_RJXG3dOx6?+F?Bs=T4Lp!||uBQPr1- z*)`0;Cgsqdai`L5id9P+uZ%Ml%z+%A)@4`*rgrX%)=F(eO{50t@pXK%p{(9Eo!w#; z0%?KY=}IqC3BiAeV{Tu&a`NA@Dz~C{9%}#n!e+E*r%#$FqGlECt%X_JS3vTr7aA1* z;3E5c^K=~wdu=lGS(Y^KNEN^o99t=FpB}=nVxJQXvQ~WFQN0gs@!dFGcwTD#@IA(< z2LHRax{=ZFz5bW(N~<;_3XekzDJozp{WIG(AoKh-B8evM^c^_B19Iw$d&gNHmg9&{ zkHiZDG8$~e#Y0@i=v?nCML(D_{`%5nq_ZgNH4SSJc@6v#Gl~LZu&17uEYvSkHJ5#i z@NktuRA9&lPc(y&_lnWi9sMu%J~Us&2UStpiLZ)by?6O@<7SdTql-66D?%9-X!zap zEmY#KpRq>5>{a{K9**No(osTnnY@mJUopq!&Y)c`mwbrXgS}996 z7P9@u0c)itKkoObpiea{=}?5vaJz)T2yY8Tl4qCKKt1=h>AO2%1}7G>-8?rMK}?0u zdD}DZzCs!Fff7NY&p&^4ZfjgPfjENg^u=K!qpMM#>F-02QJ!Y^NDgJ*ylRQ9NG{^fNh_@y$*pYx=3{ljoUrghfQ9@`Vi)V0nTAU{n=OeU^N9 zf>4>0V}dWmS8fToP%gO%fByQDy;1mnmzA^nT<0E>A(h8{C)HHpTSk_(3VDkNvuo0& zLr)p~`3gd-^668SNJpA#3%bjFjK;1Dh}<$%>cWt0KSJKKds5jyx!49HWr&xROWEpACSqblb!|L8aLr+Hs3iwoil+)z; z&lhcpt3pRdhxT8S0_|XUk49Y=6RpZrbv!fs+}?57#uX+gkd_wg?|nQ~y+E4g*_kRN zgz~e$Lz@I!0NDY6q^B6n|DR7w30%>j^j0f>{k}y-4HW-J39>(9tltzZqrK%PZoOxH zP7B9VKL5Tc#IqFee8>%H%Uy63L?bg#-8})&td)=eycK`7?;QZIzj`_RXN#V4Ru(5>uPn-Gws`wmq?h4a)p@K`iKBPA8D+S{+$bEb)JQeVb+1^ zQLOfcx0@Wka_FjzEDD<(z3raRuO;k+rOat*iteZ$y^DH{Zo{xQ0|@W_Ehes_adatv z&Wc({1Mfjb8tx52hsDye44smeufE*6o&vpp0EdQL_a>dy4oa;Wj|v0Fb}vNF2_u!f zgQ9bp!53{dG)}AT!b!E>uUkLR@O0gfnQK$dL2g+5gfnJ(x3?>;yz47x`1ADzyv#k# zsPbN&ave<}dZ!mc&vOc=pWT%$g6Zc4?p_Gf?0>U^KXTH|dxWH&b`^egw2&%Z&} zqoL%4n?`z7#Tl9FHQrOvkKVgG`dfJTd!gU(-@dF6JZ!Q~KlioWfJoRc9U)_vo#_f< z{_yRGO!T(|_46D6$QO?+pzGyr_ue~6hz2yCC6CIPiu=aTf<+4i!;{C%>`SpCheYF&#$C?u!;%lU8n)}hU8c3j zn<`rBw3 zAfKA|ij_mQKqv|qE@odpirqhW_#X}OB@qL?D+tE2r*Lwv4V8Tf7_(Uu=dF^Y(FmVS)aefB6&UpS~#U$4swrY;_=e8}enLK{`6BAVHCaGgef=@;uk-GH-yxU|3OQ;yfV8B-t0 zfn%d~-g~HoXr7ksiD|JYnp?fS{?p0w4WE@Yw4}QfWNJD=%r+}gmciNj z8gO-CIem@NAk!DW5vg)+5bg^(!N#tyjuiz?LY8k&tVvzuJh79XNmRXr*I+iPOKR&( z?tRh9Cx@11AFyf3rf~tr!{1?bzoo5pIqrMchnEUVgs8B;)U5UJcI=frYsV*6np%u@ zTK@`~qhZM0IuQ`#)!vFJ?19Xpy@*z^w5%!5UTYH%G4*jq_vtFmuT5%QRh zcl0zv(R<+!PWyGBulxLyum(R6X&I96kS&}DkYtpom_yT{*f-YE36}6UZg~fnD6I@_ z9%$R5oB-EsbO>$cZ@S<4io#n($*LMEb;71A;^id`5gzh2N;)RyX&r@XQgFLkzi#ZO zX-@)=P5#g$YyZ-FSn<2$isU_gi`EGF9z+$6i9~7c+_2YZeVI|Zy2n4z|71W#6gemj z7RG-~8bX{?m`*RqISQ?LF?qY=i_!wV`|&zm2vHm0!%#qX*n>wQX42*O`mJ)9lYTM{ zP6NUodbP`11(ucsh)=H0$ zN~f)xYT~1Ar!UAGso>kZn*RIVY$JBYHf~Jn3Ndu#ttna-gCMINhnDH!V#2s~HM2QNI@6v^2h`G3{(I%)JfAmZyaz2}Q$$~Oi z&p#XV?z3xphy}E znupR&zKeN{QCeZSNhPLa`A*hBS|FHEg5=H1X-F(IKq883|E*%doaUmWqyRgu*$Xts zV(B;MToN8(rY{(fCiZq{sy&)iYi;fF?YGy z0mA(V$@aX{LOy{{cC6ayIZe=wWcVi6AI|p{K7`K=TZ&5?TrHZNKCaqY9=GWKqYaeY z6>K@t{F0y$dQ9KvbQ|=A$Y$NkAKbdeuYdD73V&dDG6eMria<5L6&o&Grf2!RY7fZ* zWBQ}5NDz6ECid&bkkNd0`e>Jm>8E`ef9%jRT$&V&1`>FpK#6R^5+OkSTH7pCGwqXH zw0m=h>^_y^MSGbl;!--@EcY-kFVuk4#rYHM+nB89b*(-O`7;c3ps;riE}(aFV*)!w z=Pq?1ON;ro#;h9@`BKCZZoS?!EoeHQ&gDV9J6ED4D@$q=j->)@b(rh!=uthxW#dew zP86fz+)ar|P`djbS)FM3r8~9`w$8Pb&^kNKJ}pZ3W_V6d!IK7C`4`r$jn*zdZf$NX zT;kp*7U4>f;JR(WG0lQvgG8lqRcJfxlzeJUglv=cx1!2_loPT^fxI#5?gq0ruJx0T+(pcM3e9O&Y zQR|a#olZhpZry?xO0$g8&`PtpE`58jfX0r6VTIcyT2hu&idJpEt-fe=Mr5PTNMgY! zXwK8e#Q%j0{$YOP$0wof@ zCP`iS*4oCowjZSd|Hg?-jp4k!rN1Es0F3?@JegVweFmdwI^X${rH80_yz+4@_KP zo!ejVYCF$YU$%wMblxm`U5<*DBax@G^8aAt2LqdSjKNkByDd!(ZL!-Ku7>nmS zTaz&MPIPT#IH~&yC`9zoy9(9K@-H_~kMA78GNJm`mpA*|e`|;P{Kt!+ zKIaKD_1_8i)2JgZ0w9Dfe#zJ;|B&XQR)XVnhd(dGjKGdwWV+BIRYJlaa>E)&-gM}n z)Y#KDF9ebnM>?nMJ08~989|fkYY#;EQG;1F^0>}&np+!GSquQo#^Ln=pJg(SmzuBu<%cPp3$_boj1`|Ep@{va@+bAxf++O4 zM`e)U3(14*+prOv%~4Pvr<+|fLZXqd&t&_M&azosWDD?N-Un^=Vj)ggh-rHAw=eM+ zMP+uh=`uT{IH=h@aJtnkaT7IQfV62}f|2HZxq*YFtwQ&2@`IqLiOHYuFO6HLdAfe_ zB>YlCz{(R?&zpm*j2l6iE|X3)jIiwSf^ruAd8HqUG}sA)Kv_^Nl67WXH&2578N~`~x1=tw>?vFpUv?e<6`7Yx6BP(GJtoc7gkL$3_dT=IVQT{r3 zva0$BYzZ7}_3S;R_Z}n%E!N8g{5P)0TLMH|QSsSR3M56Ef6OF`a}9pRjB=h}sZf?; zWxa^KjQMeTKjXDgNER>9v%u({=sG-235=y=sSrOL4GD?{zH291oTsd``GAbt!m2nL z_47cF@qPrqu+NMiQS`4psPCZr(YpFJAsek_@#v>b+OO>Mod_lrFr9d|>}B7A%-a3O z&tOmaMR}#akB%y1dw%T<`y}D6YXyAkGvLi+_c~m2h()t9bX%pe1TVG>|c8a zS6cW|y>#x>kZt4w02E5}$nPZ2R8T&m__V_RmbvEocb?$>*Q7a*D+eht!|lr7m*f+O zQGW-EZh{f@p``4L?f*D}R5y*QrySy3A=3dlv!Sr3r_QjL-dN=4YHJkX9lP19=~4I(!8#fSh#Q6WS*9UAfl z_O=2gj3*i>ERd!|7*a3T+JJ`=nB%S!DQaYOP)~VhXTg@V?*g>TXC(3|CIW_cVHo=@ zVn&+>mw}Q24Tr5w`}#v^lM9!FMW88n_*r7+yg^s#9LQubp*qn2yf*9m7p~K;D&obA z&FVPbME9T5Zxh<)@n_nN;d&~v0uE6sO^bjrLcq&%NjX{a82_r&EY^n#RuX%)6 z`{s)hi{tnrxI;MRTnwzF9p_Z>vA4ZpJx-1#laQ!uv7Qe`Ma)0<-{=7kzI$WW8Q{xR z1!nRr5cSjsGza?Lh%2z$`~#bFOBwsD9AbTtrS&BUE8Nq9s6&REiJO3)s~-~J%k~V* zhIIG{PR1{W_woA%0^^NW(fySO1PaK*;c9L~UI&~?LQidZ2bP8TgvgV{j_AME#`~6{ zoM#R;z6Y-_hB8e~pxI9EOW|@tWZVP3LHC>F_is^?gkI~Om>B?gQst%U`o<&`FAO40 z4wdtnlB&3wDXe5?l#T#nWj|EaeB9$yRH+MuRf2?`d;c-TQvUTMu=@zcLd7!B8*@F~ zoSM9%->I)6{i=Wd83UsTqOxT?)SvlXG^otR^&dVwNA$5QbFmm~$;Id`0u9z^PJo1zqM#`sf zXdycQ_H0u#AT#X~yryFl+0oD^nr|Y>*z-6R<_>-?FwZfI(f8eQq&<%XE7huOQ^ z72J*A&S1e;Mn6r+N=Jc&n*+ZXychq*8#Hz*VYVkdq#C0=2{-$*kG(lbHqt$W$#%L6@5 zpGlIF=Hvb;cW$r3h+qOJbbnr-%GI(QRWLz0Lg=we#NUzQzbaG;I}%q(nXrVF-)E`= zzF2r5E8wlD{Uu<*e2Bz`In%gΞ>0XKZjNiM};7SvP*WkXYff+@)XRJia4!_C_o5 z5Su_aia$@NhC>DgfVFuj7nm{QVog|*)2$tKQvh4ORcv#?vpJ>{clB2{fR{F$wnq1d zVx@WO-R@@_FZc;jE!(GJfD>3Dw@KqKWM;UEtOO?F9^Dez03tNLHSGJ?dW?IgI*wY% zilDn*;p!ldp2Gr~qX27lyuEP}10=`^4Vd5~l#vpd=PM^!XouAG6eq~co_V@!HP`?4 zdS1ZQ!o>$v4gI)5&lF4e8Ls1tU*Zd7EH$;(@AT}U-#UE+7k9V3rUO}mra+VrZ7BBA zGh4{gs%pkU>&>7>*oeef;wv`HUSj&Khp+jxqB>q|AZ2C|M$^r|6?TE ze|=uf(&gc7=%p6QrT!noiQ|8d#8X9u8R|E3Oj@Aqg|ygVp-fMv7~Bz5;9TGexcPXH@sASSop9 zUwI`T!OQ=NhO|7^n*)4=eEzeir#Hc-V5|5PvsC6##8bW0$;eQ@o{XcjIV(>Q)u5n3 zd6oaXJkX##nd16S>R~hxc9X1 literal 5113 zcmai&XHXNswtztqL8OGU!!VBsD0izjimSWJ>Qx=6)n3%!2=Hq>l{+ z_DDz=k{*NAjbB;+BvOXxO?2GcD-hv}%}GHZ(pv2C4DVpC`ZQgO##VH)nlTE&$7Wvn&8UI}1}iORbx* z4t82O&a=62+vRFC{28>0dH@FF@CTv*fCwuR3}(Nr2?SEd0s+b78p()9QRqkD_uU2p zz!BR!^Z=K=RSzI;4+O$h`}v|nea@@(Wy=^$(QgLTvdBpaA7Vi;LxADM(?*Y<3DvWik20#%I@%U zs)kUoO;n;yDlD3PS7g5CD~boN*Vntm2j?A7p8Os0^cUmyt+;Nl+C;=f%Qok&%3WfDJ%-;T-C))8%Ib?Rmf|!Z0)=w8THSD}d zK7(gzlvPocS!#aFy7(e!LXI}$Dy~$qJHmSi6zF7lJm|#_nf=+gv>i`gUH^4-`A|C* z{C96kIIDeLI8WZEXJ)s#7yRdo(YPm>RqD`(09bSmslH5v9Tw#w+3Km zzy*hHou)@F74EWW>gdu|!odyITtx=m{GgQ+(w()z%s^j1G-KaW9om6N7tBa%ydmkF z6i!HAZa#lI5{cPJl&8GFSAXMGqH#?~pw)!F@`xIpxE!Yy_DUpEjh^dvhuI zYdsC1J(RTgvrCNX`cSvu-}XU)uEVC?U)!A_)B-Q{8IL#YWWRFlF)QbxK4J+Go=P8I zHziaZ>Of&JUP;40nzX+3EF$lhFy#0?WO0gdIVV6X+!V3`jfrcJpY!!fs(-KBY*oi~ zO0$8`5^Av9oF~=Rtc`GYjUb>dUitzD;&c3uR-?WbYU?1>e&psU+k;oXsCgre(o zO@H%9(WwLn+HN0*clCaP{UK3q4=y{BL3&_Nb$%>|t3St#RmKe|q0*HQw~P?0Yu}xJ zd?FVzEu;%PEp|_}cDbIJlyR)$!eT$RPXzledI%0$4)=b#u5w@0XxZ(o=A!j{(73oO zgG<@gA%smEnCkuOz}&LzP+p;9=LYRJZtq5H-0!UGk8~3HvD;eJ0ij&P;FsD1rV;V* zLZ6i*j%L^Zw|>%FLSd-*v+C|tB}?K# zJ#^lq87nLKd~yF}&oDpS?wNaZKx`-cxY7L4-G2 z1a6NL2!ILzQ}K(Dl3qi6|3$`s8T>DRt}r8e;hpiNO9MWFf<@p@HA};+$}bSgw*bSx zpt#&7E>0yrq0>^!(cRxubqEw{pc_Fkb?r%>93`BFs|P*!XzJj7Wo4x^vE}YGhzbCC z%qX0jUo`s=VjN1f`fZ@+2Gz6pi^iV6Li)zNqxccSMmhk~Q}bxxH<2qqx7DN9c`zz0 zfox7Fum19m#Fg(U2a%WI7YMg7BvIkHa zEWZQAcJt01LttV{o7Fd*zTUn#2 z=oehHT6h7&zCA=4ynl#b?ppVMM0jE@?5^`MeYrqN-6|JZfj^==HM0s7^55j)h^>I9 z_((s$L2f5-;lKCZvuzXmI&sf0J5v3f4oSfMCv zS_>KVyqys(z$@*pJk23`DFwxmsI|ht~z0z)*0f?%FSf9F^pS0!=J}ztq4z=|U2k=)1 ziT|;=t8w$2-EmhDwI|nXLd>ZQaE+p4Y}?IoBax&i=S=$aHlaMRMUuX!2DGCr=Fv7k zJ#x({>0<9yzxg$l)$llMd)ZRv&^e*yL?HS(p1Nx6HNf|cpLV6F1I2W;c}EB8Oi`!C ztc23q4U|jP?jVd=3_8((AgH^Vf@N)26=@>A@*z}?Zsz>Sj-1LDPfH;%YjphOw!y7k z)2KP0gl09I(B*qnE$uaqZ|+#YXas>Xla#%tCp{)uW!NkIzG+9JaStra!MmeTB{pbG zV@sVh;L_x*6@!v>uMOkTULK1yf2$SwHurbt$!GI{!}s(Q7|ISuUZy-gdn zsu|{1hW*SW$4sNMhf#*SA;YkZdJIi}z#JP*=VJytPfrOLa?RrOZpi-0+GO>G z_7x9}m6`5e5h=f^cCc9OOAIp*Q``05Nzwm&{r^AG{yoLgI*DCOFgOH|wFojYtpc_M z*)!E5$KmtwRe@*Dne-Qyi`{3N*Y^sF_Krkf(OtO|?OD}>T{XxJlQ8rhRfI!?V<2k! zck8V!widk$J`swHssf#8(?@LKX$3M8=hp}`wJKU(bT$ZjO+JLG8EnOu8pA7(Irpeoe*@x^&vrb;X0jcw@-Gp_m_#&TE>iVi^QT zM;%aU?(;RC(G82<;x>>(fP50TY?Vy1>2afj-Dcc{*+Q$(Sd0#*8`Yfwf*zNq+D}Hq z){A55F;IP}iz{GhWY~|>pZzQWTXJ9J%goam(;xdUEGiWEX5tma^A~QxJhI%Lk~+_6 z|2$%SA3}S$CidGJ5gyeR`fCn8fD1TW6FFAw^Qj*YmzbC!($O7%nCoxI&E3{Cu1Q-` z)RZRvWgU3SjOFQQqlLak31;+*F!UDT(+J%x>XV3J8ee4TZ`uadQmQz`IeeNlHv)#K zkKZWs3~zs)5E+oOUZSMGTVfJ+Iv{uq7kdaVZFAYLOX80s$)+L0hn8ntb9h$G5~ys% zbGysQHP?n>UZu8lu%Vxo&DzuwXuHDC48NqdtPm%&Re(rJmx}P+V;Zr=%=dM6JplF?KfB@X%#NO+iK3ZA&VUyqll7 z`c}u-9H{Sb}6~cXi_%XwX##lyF_&+O>aUB`v8yzUb4N`UpWx z%`cbEw0z*JfqUCiOhOZ{t?baQ91uK$^JE<#}s^!M2~KW>oTNK(KI zNH;o88@yi+ihOqdu`LRj@m_V&)ZHNEH!fKyHnnRFmCh)T~Aa6f- zmRDi1aDw`+9`x+u8I1orIxOcrO|!yQe!I^{p~nqDAL)XZv!a}Q0Z75u6O~<^0G*ad zryp}fin$KznI;eQ&nu_M=U(zW6HW^b!-_U;x8N=nEs_JKYVb zUu@|%imo@xZ$*62y<;i%aPKF>XgD#rG`yt)pj1fmDY+8=*M!_XM@F2-`J#`pO%6!Q z-L)_n<(pW#2pXUg7fqIt^2#ZGvY&@p5dIc-0}SdGl&pVnQXNml(-MZiX$TX+#{&ad z`1@{htG4(>m=?>c2NiE;s-2rK`?TuKeUJ}Da%N^3N%?mzylb#)+)Z{gEwc{H+OD6snWO=xVYHeKkO09-8Dm##Wtl|fWkkDO6s;i)y z?<*ft#LwIq5qO(M6Nph`m`l<4-$kqcVDf*eZT;IeOi0(|b>&kFC#c*0)2nhF$zx4@ KaOFeW$bSGBm$Xv= diff --git a/source/WorkingPractices/images/gh_screenshots/project_scitech_light.png b/source/WorkingPractices/images/gh_screenshots/project_scitech_light.png index 0094182b83fa08701182fdd6a16df3929130796f..bff68cef3bee4ac87b72cf67d3395d7e8ee06c2f 100644 GIT binary patch literal 14862 zcmd6Obx>TsJIU(0K6ye!|M&A$ zPMz-L$&(L7a#9~Py^Ic5(ESLu)1M-V3?8f5X>FnA*CFckmr)qevbeEg zCqa~a;&+?b@Los=W|`-mpbHdu{u&oIDdBPE5f6DM4yQw2pGqc2Mh*p0%SlOn{+UQe zL&I$%i~N=J9bHsp1xlx~0A8yh zXhI)%{qAdYRjHX35`3{Af`$}qfkDUtRF;2MB_bD%{)Fou!ww*VFfc15a=)#O>`Zxz z93)}h7k7a=qxz3P?0tRw754u&t)PTU1vlb4E(i+^q)<(Toe7qLLwtsSdrc2U2`^X zVB_LWw?+SN=7%I%N=gd#Y2Y8f(fBTFT(D}w3)sopG1v7eWBqoY`_)E**v0IOMztO< z-Rdm*H>!s>dvg^8GIY0ch{4|Ci~k; zJ}k%q?_#F7TTmv)W%ZW_!n#C>DVAC^YIC{seQ_td-r>);*v7O#{ghPLS8uTLP5=BM zfcs2N2*WvXan*DMion%Kqf%c;sg~$c1KIkt`l>&wr~VWA`=9MhEK#mBbeJtYacIdxMPS}>012$bEIupZ+ z4~l6aZx8#zRm3!o2?@wgyg8@drUUe3h~s}@wI~jD=;N#rYswtPaDF<(>~mT#TUqFY zx8?yUYs#rmLwSFJwfE!*drzw~Zih_hn%Z$FWy+0c4LCeu(bhSqE6g`Ic}L(Eo+9}% zj`8)LOCP-)fof89Pef8f6kzxxEhGyJ;;yUPnMqj*7c?xZq;c zOozE!#~wOZv(86A5{_53l?>WgwOd&X5oC7>SV>ffRbS5EGc#P4V9BOcQ0Xg07p_j3N2z#))O!$t5<{o1t8$RaIJe`fw!uGOZgGL;Ay$r(r2 zJo$knIk#tbXtE!VW_*t`V~zi3TIDckP??s6>6FFI9-~6~H`v-dTX+-AkD7yg#Vy%m*aH-Y^Z^5i7m8sDbuJ)V*kb4V!5i4HTTj}r&i>s5hE11}01!!bKcej<6>O8Sa=TP!K@+I6TZV&9gipeu% zkvb7T5E+!>IV0E7j-rm?C|GRp{Ii9t(<62HBe#C`QR_HqqWXe`EYoOE70<6J8vEBv zL+NE6=C{hcNjo|8qxP3UIRef!3`$wWMx$TOx}I2cG%zY8Gi0|MPuB*|pNv@Z`ZYXg zhzuNNS{bVz!{2yC^;Nq7NOEj%4sShqGfygA6K2O zNztx1b<#e;89ZZ4gVdN8&t<;TK90*!w79pe;!;?2&9{2z6hTuG$R~IO#5O+c9JbhZ zfZA0KJlMRiJV0^mwbSRu8`eau&9{A$W{%6t5RILMi{-=keXuB>tCVN!3YTll>01`Y z{)gd>*>`)EAoFYtxMqh^yxif|S$5QxFZ=$v42Aucm196Jb&oeAcD1XpP;p0*Zex=O zR#B}ho#=I&7s%g8B%*_2Lefhj=Lc6y|Lz83bC;5*%u+UlqGuN&GI5=@65sN;G?2w# znM%7>do17)r6g2uQ9~=8j|iXU_aP75Cy(>II4FQ>gRDZ$SD)TDi%p!HL6o<|(~3H> zM2Ajm^DlU)|A_j%8^om*oAHY^Z_0w~wr&{TS6$!s1Q^8LUOTYLkbjuO@}v{&!CYTh z6)L$bJJ^>L5kAVwP4Ey&c{oWFk!T-?H(}N3vo+K^HP^@g;^tI5r zHNE%udE!PZZ>CGv@`HZ)>+r297bmn~`j;L{ti&JU`kMj>C>BGj8YAka7RS8xv`m(Y zudi-CFU(Bk#okIEVdr&f_-g2_a@38XbQ)IrT@IAlC_^JC948k?OZh9{0CO839(PqA#89 ze%%yrtTGfn_qM??+MUO?M-vS{IPBT?EU`^mmVRjb!(64`K30U~&=Nju6dp011_*^Dq0?QBSW%UX< zh&S0rk(JUi1E)R28$=IPqD`K2;%@mDl-&=fW{qn54q>AKi!mbfqK`eah{gGOKxgGr z4WrNgx%PpmTQ@~u1*;|7-RtA(deI{C$wBpN-#2SfB)@A*dB;I&Y>J2BLV1tRW%gP$ zK$qKTyv|-5Oc>9X&G3Z6+J~@SP1IC<+w_nJln7i`*D=I$&CcbWVJTrLl z%*p=mhAAl=UG$HAOQTCc_49OgNx%jZkTEX5 zdfwd&`DE{S^4i}kQP+~ylkl;IqgZ;4;r>a(a~O`NX1-$%ll)-w3o2a54Dv62jpl86 zM=T|SVq1ChO$i@UNR-K4`~*sRic(pg4zH2P$QTN0Tz3B1VJVY|I`ps~EsIB=AO7Mg zV3c0M3={2-wy(2%tt@~|*^tZM1JcPK-Ik{`I zvXFXYoi&M~F_MqU4F66R2=L?tXykybPyFVwBRQ9-K_B(yrXu$JqJGOk-jL6ad`#cW z>W}ke^R#z#y8R}CJUoVp4%&OfhmBxqLLE$_$vAM1MFLVQoe{G%t`Jy-fE-RL;cbFs;gUZ17pTl zWdTdERUPf7JHLv2;-CByTC0Inbto3_Ej86xb=mR0{4&48*HZVqUpG!(fV3cmu+zFR zK{Uv-R5UUP#iu|CiJp9ZG0y4t+#Nhl2oxAzoqVHRhdN#4yu)Uk2_$i+zKl9_35snwS!|!@ss}RV0@!~As0k|UiK6Ilo__ISJhEnt zMwIcbqrg_Kvs&tRWc~yf3r(q{mD14QQVU5?=0vDTTD|q%=PZ=M5BEv`Fd5c6fv8s} z;=>f{z1p`=AYJCczdpOC!s)yIlR!@{=ef! zrXUD|OVJIjvWMx{sliikU)qX^grN?bPxIql9Reo-3G0OkVj3lX_zZm`&+d1D9y8X$ zSx%XvM`;=RMXD!9uY?o%NaPM3q|S-(P5l9Z1CwVRUMK!++rhsi&5@^%B6KQ^It&LQ-G;Ru#q`h}^yz$53f+bg2yVOjOPRZ_G1b%05hj z766=2&~3-X1nQ!)yTN(MvNu~$xu-7k(XtO0lAA+ow&_3`IXt@i5%Y!HJ;AN%(8qv4jyY?Sm3v6vpq?;idUq2s1B3}$O^|C=s7v>3 zD0DL-{kK-N9$_3A@9*Q#!4Cw<%1yXJ#h7G6>0;zTjtU0W6pz>1_amEDo!6mutWWh4 zjN`BteI^+a2M#mpZwj> z>TLEYEiO;QcRi)m+jk?5UsH!jW`Y(b;(bQv(0y$w!ppn3E7_kZu3WA&6fVj|*5^*mr;R3oT+ zjvrU-r7NNnNw49STIS)lhMB=x%f{RPLe2ds5dYc9_K{ z&p%1vP8GIZmea30Uz^p9R?`#bjhz>z#w~N5p$eHKY_$tv9rY`>@>gQ@k2myYHIla1 zRVr&XinkrGzUwgK&d9*+ounC;m-^jPV&_Bw9~?+d-mQ|=9zCmbgn7Unr+x{p)q{kJ z!UfFQ65>F9*M`i!qO*G|_=mt}&|3Y_FEmURXjww)&!DIV&_R}nt)81=D_H{n2>Krn z?CUDFuJ7@rzvE^TtyLsos={vs)KH1cHu?osO#AMv>OSVgpz83>i)&0w%&%se&UgY_mDNG*cQB9j0gJ#grCg{-2(H0&kYkG*rH+!I+;W8pP zudvzu(H&1ub6nNwafWFQ?oGIT3?O<2o(@vk9%j~H)RrN%mVtqmFMCeQ#V|J4dA9+j zGaSS$u@~ES)|--&LhSZj*07%TCn-*uP{F3eTU^=X%o9sy+W+X3OQ{ zXJtSa?27<~Ocerf;P+{V*VT6qWE%DtnY=O-DAx!l->jOwc#>%5iiVVH%(>Y8(B|Qa zy;ej=1%+UI0GjWCC#%~;`6l%u8Hzf-vyzm%^T#O)`iJuHA;a|BkW+ikk5`Y_>pys@%ma(+y%5yEjmU_)&tqN> zLPE{~(^!`ZG$wB%iq6l;7l_CE3gX&a9}o z$HSs88Fia5yn~Pqe?*G}a#i1&jwhYwU2(YC$6`+2q8kU&U7C(--H|w>{APqwJ7_Pj zuS25EeK5+Do1{8{Piq*Kn&MNsGMwbKd&3o%@x3H-Hb#FvM%?Gu4z%B6ahX1ZSOcLR zl`B>ZqTY_&?ZFv24(sN*$46%oz!ND;ls<+U&8rUh6D?6coveA+ifV@{nWk{1f> z$J(l|ri$6$K8e#8Z?Au$Sy`T@C_8xP7zi5VM0`Kd#B%fY;C)zp|JkrSGV&S5 zKZwo{jqtUi1bE1?1sk;}(W6hvLEzK83AX(nA9cdD^hSx13s~ZGz1@;zRHXbyZ20C{ zAJlw`!qasA$Pu2>fV;wjQQO0Z=5BKyjAVl?V6lIxaW!c?ru_xyi2sBh{}=lAl^hKX z4a)xkoBm&JPAIh+dlcDzL&^4gLrRLkhx*m<07-zmg0pE0&I%X1agSl2Fg(-XGY9b@-iavp z)ap>{Expy{Q8!qS;g~bGis{D9c%s;HSVrCuF*|>rqFtW{>3sXbtI7C-K&g})!%&bS zNb_JZ(+cbTdYz*O6>3TP>(EUP#q3PXevz-~-{5rBo^#y7B-Ju3!u9!v3}(3tlN1mm zDMt}7v*j{({ypb>A;_fk)nyK$h0*#q&@U(#P2rF7h?hf)%`uw!>4}+74)nW8ynXP( z=;%C6te(F1wn(9@%{j9y-bj6>MmD-vQl{z0r4|QgrKy}cvwT}K{E}_9=;2~_!a=MdEdG*A%TXIZWI5U7D;WU>96Sz+hCHT>$Af0Q)tBmX>{p;FxSZwsX6M zUXh;)S{3GjY>v5`{VOKDnj&r*Y1_rD*cnxCcRe~=_MXs0EbABkPIA;Q_@2x0Nb1%+ z$#@B!)w8BhKsX5=7I+JJ#B^j2T33SDSM5ie?JqqI2>r3)A9!<#&zpS%R;BabPx?1* zvyWcRuJ~TADjC=sPK7_(?t5W zpKTUdzuybjq=QZqhMw|L;H44(%nV~T1>|)uC@;jBV&?3hIB>FmdQh)=U9!bmB)ri- z)}F}Nv$Rk|;pCGe{3+m9$FYII7u(5kWxcr5TFR;S0=lE*Jwh)QCoGhs0Q?js81nV2 zpX=kV)XZNOG3uI%;C6(!PDV713!Wr*M7w%DVI}g-HTU;h@5q#29I*G*SWe#5hXW-H zbP(O_!r=D3BHLP%N$Jx{05E(DIB(j!zV#ICgG$r+yrFqMAN#}j#K$z&jumpR zlnMT(PhTpvY-US^WaqKFw=d~S~8ilY87WT-vLIdyaOxboLX_p0>dg!ISH7?w*D5$C8o-tMCA z)xDJ^l>4LloqGNbu@y>uk@g9@sgbhvc_lSHq`(VGD&qZ9!@9XGZw?jhd!KZ(v(V{s zwfjk*XwK`r97c&T1x->Un-x+OEbw^=!i-{_c=L=qC-A5LZ!T`U1?{)NqnFpBIIpBp zHcjeT>7^@9+Q?5A!)ktNm<>|Pyf}<8qF2FP;)l%9M&Vg*>qRPh4^wQfpL3RcGJ_tB z1p&rNa0?R~b?86o>!cOHin~~p)0|Z6^bHtB!)<(jq$^9>P2V=qYG{j<7}nxx1gWdd zu!{JO>WwO%qr31LtAa*WIsowg@ys2-GsD=D4~0C|oVqM(s^df*9_96`h_bip}j1&brN3U+UyECcV!aw9Sk+Rb$VWrZP$!RKi*V z2#h6|k`lvvN`1Ly*YXC(3Sje+vMdqMjM+c10#tf$J*~Yaf10rWjB?7u zuEhpDhS8D$q4aTT)XlzU9!nbigF@v#!$Q2|1OEd3gL4yUM|eOXf%SOd&O2AY*FE*Z zwww10_AL%?b4oM;W-0t+HvSVVMiiTaHY+pu&WrS3ZW8S>sv}6I&o7}|c=x@&w#eQd z2=#S|1gw?(F7-8_!x(iga>_dp#xjYg&$M|=ux5yt6nQo>)2~zZg0WLa=-q9Bs+~K(^lTDqw|ELMRGP6y@T`7m9_R|yjM^ zy1gi;Y-O3X=YLZ3{UGFFEUZ}TOh&Q_^Ye+6GlcbEHVjhEOliOjS;RK6diO$dTz6c6 zC9+uy5VwQ4mh5tzsMH};3=sTv^#OI;A}u*Ux#17k&Hsl90EpUIF>N+jQsFUDve=t? z5WMQK!etFJGXz)msfLwZ-SI3oAGDBl*bS@tx%}4QefPG)rEUq88ijj^Z-^V0wuUvJ zQZqGdv~IABY(BkGi(Mz`fV)PE7yYB`hz#nTJ0czIR^K`aM(>}L)=4)yn5lx{!Xx9L znAP3o-7fhsTG~Bl-0V(LgcqDCl|K2#x{!ao@{GOoGqXaWhFP3_b%PREw~72cheo=V zNJ7kcMr(dkqagFJ#S*aOo&v?{U0jP8C2iC_dyPD#U$68BZBnZ@i3K3Z*Rx%Z=lAWM z9{s*MK7*NI0k)9d3B-ZjbDjlhTA3cqn_sI{KK;9=X?2#(+e!jA$e$s!2@`Ra;f#&r zbpOvy#{!GrLBMbEVwK+#^NoI(kxH^EA8Xa-eKV_Tzl8vwt`M8@CSYV4c`X)I*U^8X zo^i}B-j@JwyBamZVHRcN_ugPzjphiSg*fe-J;YW4B^tA|qZV9X#P1d45Yo*j3NpfC zQUFeX812rl$no2ZM`s_FAkXfpP!>aUs@^pFr}m8v4uq#<9?7xA_h7KDcmM-xCYs}6 zwHN-Pjh_7bBxrke8^{-Hbc=|DKQ?>qfi}l3pg=BkNNO8aj zqv~AlDIXH66-EdDr^osKH}PEg`s)i@Dt(Uw>6r3xpRt)d6zIM-@_2pAxacN*M>`LB zoK*2wfl}j3U9kA30nm^%K^=gVRkm4|w{wCVmyPUEfeV z>Xiydpqaymz9dp-hJE#V-_@0eCv2OYu*=ob9%X*I95f2oSv(c^7okJQ$!~wmo+Gl0P1>PFBr;}3u#JAse zhU;uq4AC5u91xzdZ3qWWhQMyByj84vq9R!u5*y_POK_wVHfcvU)(;d6hhW=4Z2pPM zjxs!zqW+R#3rcK;cz1Tk&+pqP@~CMfx4(nM5pqZHo5pm9+=!1qg52&OvYDr8uJSM6 z=nddKr4u@DJeVeqyC^nmX)@JstVXeWSni;3MVWIXq=#$SuZ*6V9p)d56}1?)MCrlS zUEJ)p{sG)hbfBwo3tpRMjfbk26!A!LOz@Q3GH%H*8d%ymjVb?pXvSR`s^K)cr4>HQfvC?74Nk&_?B*EUy*nW$}9$59} zxwhQV`5a5t!L9CH^9|1X&48$JGl&B(JcSShH^ePu*RZ=Sf=K0-+qH% zo&uoNPfVLz|K{;=jApM3gkX(U_6}l!5!m3)4FB`A%K%_T04qE$Dfiv9^(zK;ASeV; z4aiK{>hW*^9@JQJjD%^-g(+s3nC?$6zZ3~!`Qoe>Tv?qP=%XuRshBU~+7juSEqUtP zxuSC3H6SWF>&qpRjgs1QjlY4rJqv6%V}vt#s2*#>>bIXxM~Bg+Y;)o zqGapcvcPF>699l{-m+YR?)fAu>ZT2TPLb~sYD;x=ds|{j2NuiNGxvq0V9}cT>S;WX zlSx;N4cN3?lrw&EzkyaI$i|SS(Dma>33buAKew_H%B5BEjqUiC)BxlTGD)%S$;ACYnGT7<7%J{{?+YF?+(b@_NkQ}5SRJ-ayg$O2)> zmk(_%=z#g|02LIV+3F8&x#x_3?Dhj%j8q^#(&9?)q7G|$jF{g!c$;JbeHrr#n!#r9 zPlUlNi`USej|o(t&}xHH0c~RBr`VFDd7%D_7`2`;vRLH)Eq(p)^8?a(TzhT@{>ec) z7rg(KFa7Uf4v?8Xrc8m_Hxe;PywdGmZ={@Tr0sPY9W9rOGv(z$BMvYTw+PDdHLQZh zMB@ishsnac{N?#~Ot`h~X!ciuRi@Xt0Fr+njdGe2$Fj3Rkpi#8GN6FrVcMk)V5K>; zTdUJ3`#X&Esjq#xUi{&?v&K1Gh)5ey4a}WAKUcQtW+2s}HL4{oONXfq>^J37j!qv} z+}BU!bk*<>V+ek@o?2XY`io%zZAIvptH9^rcXwsKq>Y<%L(=x zcmu-IX04EVaTQlPq)LZy#;j~}7d`DoU%y`;(JmK1Z&$`7(0d)9qCPFp>k5kz!`iu%0b+DOd%%RMaE zii#n51&x$Glbm zJGbOx*AeeV6`tklEOGtd{(GdNus&yTwb~ZcTjXl{nV8NO?h)sJ$1Gvb7!8aZ8#Ss3 zw#{LsX6I6R6Y~g-JG@MZvkU$$1K=YXeMfoNbZ8yTR9|uH;V{2pwnEBj^11ls#4Iie z*Bg=#qql!MPtsh77rGY0l**X+$nPr$z}|4VAm>vml&8}27OK;@+psBf!}3q0=j+wr z;kLwjF&Aww>;GLdq2o33eN;1*R8JL_sp9C<7Dm=#V*-OYH1_rN22i^%w? zG-kFV50e4ih%;|lWE`#e6<+)=NH`HK2~gc``Q=p1GLau{q}CoQd9wr%JO`} zhV(ylgfw)33g<)a$q9kKX{ovg_L)yHts`o9+RZdZ;8&8k*lFiITmmRa!ET>upMtC7 zCpbyg{eU?m1ov{XT>Z<_Gz;Pu|C=Pdd0Hl;jT#w+Dm5A!jJVg~#rdn%C7pGk&&x$V z$)!LGfe^XS`6XdBGgsw#NhIt8>`|5+iEEC!gsbPL*IAvans`tleEJg?=~ni1SpyxE zMNu-}5xN>sL?v@6!y6CHAyx>UYj06TIVsIf~BD4J%;!JR}_wUbBi*zmfXllc@8A1tD|ds zI-@QV6BPO~2zF9x@5ORzCZgg^c-S`nZT%})7e&ftF_9tt_S9!k*v^4ZH8j={ zy<$2@W~7S1`xDPWj2r2Jeh=F@i=j8$9R)27jo_^W9&*fCAr>-HU)Ye)QvH;-GB7GY z8W{wlk(6bC-vyX!R_Q<&N$i2IEgS9Mx%Dr0JSjRnw_y7zdY{&kqX_Xc%SZ!4nZiWS zy3zIwqEUU83xO$yA@au6ExVSs)_;Qvk@TES z^H1+-;owHi`58USJL=J3k$54P~Ohf==9x6NH@5w@z@RaRZqZp;eD z?Ag*N5jgF0R@M7tZo=c(BY!i8AC$=-@?j|Bdbbr>a2Bo?OoY7UutohjJxlFZml$Zg z(4@Y>Jzaj!V=XYg=e}?)-VSONltn(|GPy*Z3cep{BJ3s}Hvo^5S)tuOY1YmF+k@x! zT^&B!`}Q?kv(CAm1aXv9n&Zb|`*RZR-;z=7{zi057KZwN33WC^vgtaD5uf{BN<{`5 z5T68HnnO+R8wAV-sV+u;UT{m-waEwjoFMMZopb2H~Sc~mq-o$~6OUU?~UhWYb`(PN4n!cAl zfct(9%!x8Hs+o|#!zYsPeKSG79Pc}j3^2w2>drj(WX zc*Z7u-?@fVHni9ZZtuv*9*kc6aOmSce0HB!>AF$_%}q`CD%?F$R6Tp_*f}Djy{#wW z+66uD>3-W{$T@%O=~Qj*&DE~rLnjVKE{ojP2966cCuL+Pjn6Hi5@1Bu2`v0S^S>cK zsFJTI3(moRk8u9sQ1QRx3?KNuc6V3EH}z@`$RFwIBwZQ!(18|nA%Lttpb4dJBk8kv ztNf(Y5fV$$OzkV{FM^ZG$_B>A^?s=)>i}xxz^~^xLdT8fENsc!BY5vXYNR|zt9dkh zzI818k30l@xRZ3(tK==w%nzSkW+Y8Os6rS~V0^pKV9u#0#XD=>n_My!pp(QyWjn|V zo_UrC@blL$+7Gs{zOhq?ot&PbmY7r7m2OU;@9_~&kb8i+I)GST_-H26>mUC~voFPW zfk$q33G3Rk$q)F9b&7I|j=oqgvujQ*sNRxLeDkBPTLsRgNFIY$1h*Dng`i4dp9&rg zZrDO8#X#~-9HWBUasHP=8Lsu##X5}r&OMKB>M2~;48kTo((pSF2YtlZEqnDpml|#2 zS;>rQK#}Ez7#Z%|bV_`V&?4hh@l_~Au9=>II`Qu5`p$Lj*_C3qxlM9L+Jz^GPh^0X z-7>}edmartIdz%4tK#?!J{^o(rn8Ju_V|PP7SAm=aopMU!7tqAt^F;xth`!Afq7UP zR`+JJ&%_UVAO2eR-9u*Z*^8#bynJ{E)JBhAhSB-p0M@@mS$kd#gA1eu^Va%j2a6HU z@o-&{Bk=rWCJKT>pdZ3l&I`={)ZISAcF99AGoq=ydSl31C98#}e zC4k$qAaCFGV|i42G)l2oQ9r88a}GaJh9fV(-caRK#_mym@-UV(ok7&|iBOjqL-UML z;hulb!l(MXlBd3p(aF#;1L$v^3zDi#nt1&Qw%Q5)!bV2<%S#WF#R&lsY#sh{(#_p3 zA6a|b>LR_h<3GkyN}hF@iPj$>x?n=Ld-ELx-xy;*#q9;oY4{BzHidEjnzuY6Cp#xI zZ)5~;L?YWdr-+e4gsXIc8@!cCKWja$_=bi=Ye$BF$ovcTYv{O&ueBSFTa#gqc_CTM z+q{^~qz8^UpASWL#GdpRO8wjz9*0vKPs>*eCqPD3Hq(Ye!WzG=gou2`@uJ%Z zn61>6RB`?`v+3(XNmF?@B1#w1Hk7{LVMiR+U9cG#Vt8XwpKRQZt=m49SspTW$yQ)A z(T+Zm=!)HK@7aB^!CA>Zb-feA_B9RH`Car%Xd-iOTlr5Kj*jOE%Cd-;^4EIG-;R-c zmijsUu+a`KBL)*NEzOkqW4dtgcS%9(hG_M$j4GC~0WX+qu+N7E*O+@!mHF2Nu%p7H z!da5c-~;uLj_9g(6k(((yFH!(ZhMOxSp}tbN1jg7l z)BNetk*o#?Sp|EI{5`J>s+OOu#D+swODdVM0QKwZkALKKmt3_@QFWBRe6Bs&3G>m@ z4D!{ku(1(Y1p^fDw3j0Q12>(~p}VKZi#P>y>PwtBUm!ojY1`u=XwWh>CB% zA6r4Om;&)%;`%~3kkWoyR`;IN)|WvebmhDq18lw$!(|{E{2CDoL{V6c^%WLs-3j_q zcqZ*hi8s1?KzJGR3H2e04_G}pw<}u%*>_HynZe}T-`KCWZ@|*5Vsw!$RY7k?lK2V! zP4W8vuR5R}eXp7P?2((QOj0!MH=ded4n>R`Ve@{DPeQ~*Sd&fV*T@Nx@B6K^klW9M z+YVN~`MxCi_%W2td1<{#^j+f_l#HAc%@&7g;H==dj?&@@JU63FxYAX182l6B`qduGa|} zYuxDn(#{z1|DJaKn^@$|EHEJBo+ieBH)Z=@&sai&s7XDH0C&!XvI)4zypH2vYvzXc zh(kAe!UA{x!Kq7I=8Oq`3!>Hq`Uu2RJOch>(=0HjII`G}Bn4^W?vUL#QpO(>#mLMR z*PT&gGw zOBE2BbHAIG9ScSZD?%XKMhLGsJmteFE5?zEax={ubohZ?3gd}=`Xrs%h(MN9~%IJ*f zz4!8YzqRhV>-%xP`{R_o&OT@Db$&e0exArzTB>9Z7#`r@;E<`Sfpu_j?kU{uU5M`A z&4FfZv3JWogpR5rPU#@i`dxr;tDt$8Q4vpa1tqwPiCxrQBXDqNp8PZJsq3)s;owkZ zse={tyxwll5_@SF-V*MWsZb)7%^<^%G#x9V1C-uSDuO8@bH@!}_Rn5?_zr(lQgYJx z!r}68yflJ0__3k`XLUP`0+?4@8{B@7iC7J3W#%YdxIO0z$b_wsfM8o2LEs%RRH}F4SNh&XHfbW@h%pq2CnaY0U z?o+XWtrD$7229Tw#hfQgs~E=*Te_T59pZmdaw~u;)hk?A%b^JNIZw}#FGHFDV>5$) z?hTwB9#E%C`m*$R>XdUh3cD?J2R(Fpvyd}BfI8k3bMDAUdgR1d=VY+pk{sdK79|Qb zs&~tP(VvMQsBEriqPj@Fl(eNDW2gR#l;AS3eOJdDt0cWE?`?fzh3nZ)IPqTT8xnZ4 zJ}D;A`Fj$ASg%CytrOH`Z%;5iN;X>jU{z_R&MQQ9t7WL{vTZqI5fF`DCI85ck7=A-T4<0YRw*7Q{jceD_H@%rSZWpRYsyj z8OvQEKgLh?54^HBrdiz|S>|5_XMQ7qVMuvDuR8=2$e%q*R3UA9+>9&H43o;+ZY~>7 z=D%sta-40TwbheGXhC}x6zFP?8emk~9;X5N+*#oL8UfcSN0X-1g5&FYt0!MVi$C}t zb9rG(guWD;T-w$0)TD^`KYT&ssd&sqT_p#xmcmCY4TdX*KKPC*lb5;q9HYxgIm&SO z*-4)6Hs#MfeSK*}>0Mmd7{&q;pS;HH6%%?GjKY~|Mi;VbD zHy)-Ji-&+d*QY(@=hej7@CCPa`;tqw2`MUt*$?d=3TtO$GFR^hKDwxff3xKR_1QJ>5krTU4_MV1h0P>YHERMq*XB2@P%3|C8@FN+ruY4qFQhi;srgA)c45FKSkJ{9csFH=GYggMPM4lTm)sI;pSKDp5g^eIzI`gxzgrhIgTZ@{AlnK{gOT_mu)u~9ZGF0**sAyy;&yFrjUap%|Q z-#JDjgKMu0N+^2A_MYF9gitoK`tmJ@_(p#zNW$EU3oXiSv~``4_a?n0O_Qs1xCG8< z#kKa|_z#s%pC&USXislnwD*{XyNovpO?ehaWtTNY32mo-|B^A)qXzi8=(Rlv?WdC? zcZhqd9JRrjy=A%Eik9%*!M!+I3#NoO=N?x%kJGW<7ok+BHA};{A88}!O%)p*?{NyQ z_xxiMajMKbe8FRlZSOYkzgj0G?QyZ0V2P_6MT?Y8w1VUAX^{zf=M^uFg18!jpA{}r z#Cg4oNQdYANc3@J&woRxK|fBdXAjLPrRXUJ%48pnKJ<# zsFPF?4xdr(UH*{F>iV$Ep!lTUN^R`m36z#K=ry)7>R0@d*yg^57i4(^@P^ z=(>O6WHMJnAicQE0$+&5fX~z4U2Bi68r3qT;=d0XFZHPP7JC?gd=KhnNr%v2kWJ+S z)2OW7gR#y1?Y(^?lwa%=u2HSyXAk}?6V951Z_mDnL;C0~9IP(nT0<_b1quiLZU!<) z3JQtfcHk}_KUcyuI{5DQo#jp(uQLB=S_~BL69xZ%d%OT@)76U6Xx<1NMqgt?7$s14 zVtG!oAAb0jwFm}idsS~nzMNr7s71)B^v5eI9>`9tx+{kVcq%mppSt?2KP4sp6*4N` zIE0bCpJ>SWSbwR`@`loG>Y79ZA@&+hnGl=E8Vb>B`T&B{bQXI@mm_u+G#KSIe%Y44 z8Ny6Cx~@KS+FQ-->&}p-jd~=e_i^0o**CgjMGB{i#|3#CK#y{1P9G=GIh*j44`b< zzXom(D9dhRA8ChteriDU@MPToMobszb+FaJqiGHTL2_f&AYY#%eRwQSL>10MDsioF zC=+-;zGfFzw@DQ3f2fdB>qevjw&J$p=y9wJn*=`PRPZAE7~vS%&z_<=E+CCBNumL+ z?w)d7^#2d0Or1O>W|4BG`P`TEig#p%-y|k7F@Lf5GdHqJCX|F$(PjRz-$ZuG-A@a} zOHL*w@Q^8BUN{#RWy#D1?Cv-JNf)u^g4H%hr;5(#|Ni;@){@i0BJS^At1L1+qFY9c zI`|2sF8h>LmSXf*{)XV}DT+Ap{b-xejvngYPgViD9sa3jk_+GPo$DAE1g!%oJ@$dB z7w3w<$V5l&h8a~fKLf5EtzE^?!eda?-KN8$4slB0m)!^0a?wn2rY}IcciGe{d|OdE zH93M+zHpxRyhI7yQaQ;}osQ~#d#(e(+F5zhW_Q#M-bDOtYZVFRBM(bP>Ine1W=t%d zduz`JE1rOvEB~x)MRdO_dwL_5&Th6(<0#$&fx-Wli7#ktVYOO1J5l8u?+x@qQYqHl zS6X>~qy|4Lh3^$OK`O6i?wSvd$r(`vdJi{Bb|=BH)1yz?&*lEMYML~C3?$*Cwd`N? zdUVsGt7ojZLC>>}#luuuoV~7Q*f=5S=osZ)Gwq??ncv2E5ICE^{}tt8UqhijY`Fkb z{5A3bo!Y)_IaF_B&D#yZToEOn%-{1M3r-uR5V?YgCl!yT6_y~T z{xliSc5^G{ih$_SH9m|x@vz5}Y){&bQ-C0Iln#Sy8=$cfOh9{HgIz=*+#Iqr@-Q#`nx0v1HYQ4bn`Uh7 z9*?sZF_lkDXA^_FwzQ|r$?lf`q^)?H=Tcj<8*>{Aebg@x3;sFfjHxL=f1=AnWy0H_ z5o32FqD;IMi?0&%wP?^s{<5|L$@~tL)x8l;Q^CJTPL8tqSfxY%y#%shJq$hkMxZ{fJ8LqUB6q;Sv3+r< zdH-}AzL!~45C-#)?_Ro8llT_6q1mW?_JUn3YT?Cf1GO)c%);vNQb%1P#Bk9L#$;24 z~0)nT$Y0)a*XYkQW!5mHIGH5aHpeDN?*BX0d>b9EtQ?tDrD8(XqM2*D2~&N zTcHZe%#8HI?M?qc(H((ok~wLhOA;=Kd5irbtE{R!kL3>X$$MZseMaN)7k!>dlI)Sq`w4ezq^Qv&t2?NU-f{S2 z-?18Np3~3vGIw~oca)cB6H1j;eu%Dz=Yjh;3Ml;XwFhtP9AGw87luY6Z6xHh?qF-d z^wKSH7GmWLvdx1rRc1_4t>2;SXc2I#6!e249zigtI;%1N^)PueUv{|LSyrx4kNJ3I zMKKojg2MUCqr(fofih}mZl_>oK^i>gqhCVhX3*ZEjK+Gqi%kWv1h>ZwW<+F0v!=0S zI}YUSQ1O`6NpU54R;`ggWr~jL94=5rq=LaV6@?Tg<#v$C9hd zgzCjyrB=u9f9l!gwvlOIi0L}K^==vY&G}oQq?hMBz53{aYLe?*Reu2BE~6#e`~0Xj z+}+ey#w07XQr0aOi;XJ%%<7>XFN~_}LjN%}EL5TCS!n2YcSP-?>vJsixD%HSedB$- zG(<;gHlVbB50lD5Uta>&zrLPK3MwwakM9D_p$YFHBi;N3TFhkMr#K!rWOmIHX6{!= zl%|4{jw{9Rm(x6^#rGHvm!>_eYq-{$$s*2PknW?PSl1YsxyaUL^;CHlQ{{VV;s{H+ zuwXaozrZZl%N|QV22lMUMvpwi+xr}GIb@J;!bziHY4(@&aEA@A`(0fkI@dN25lU?o zP^P&~C7&G3@R?+G2f}WCRktkkivGuT+KE(mlj^0MsNa_^LAlbp@nUk-Uwn<4d=715 zMI{lAsx)R)N9Y(!$imNx&nGqzUn&BP_%=K876kZ_mg5?pVNypR+2X!n9go85gnihn zy;}gM%IJNWu*e&Cx>tkc&FVm1fxg$ywi1Ieq}jZ^tb4qcdq6NlVeq_UOt4dG9;{XKC~iqB^CW9>P}JZhT`vzBMN%El_aQt0*d z4J}fHxC783s_@V_wrU!dW9Y&$zwPG5t2iLfTWodA;H#r&O3(EB8HKKXbCH>Ug1DQn zF3b`|TC^OrcuC@Gl9CajPhE+Xyk0eVezi`8?A4#{C{|8BTzz?cAi?(%^D0#S*r)HX zrL)Rdxek^i>~rj5kmZG&|B6*p_~J=YQ2exrD&$rLNq~Zl8*Q>xD&Kyf&|pLIYmdp6 z>cn*8q;JGf=#O=C365ATMEd80)O-a=dW()?+#GuuR-f9e8 zWI&3B=3T)2S~M?X{DO3JN5V`kx~nVX6h}o%aLfRD zFbn*}0bWin(&{8v8tqXZ1OZ>0I@EdZD;jvebOi)r*c;TTV=2|JlP}6K;Of;Qi6-8a@UB`JDex-)*!O z+n`pL7R4Pf`|1vQ`Q!URDe6LL#n2Pm@Z4X8r!HdH2TaQ6uOHuTb|+42m)t2B!6gbK zgFqo1$Rloi!pn46thEqzu)P(oS+gsNXS=#lxila_d5Jxu;r`R`mT`kXd!7dhpzMGL lbDaO-Z~ed6&5U*oLf diff --git a/source/WorkingPractices/pull_requests.rst b/source/WorkingPractices/pull_requests.rst index 580580dd..4e4843ad 100644 --- a/source/WorkingPractices/pull_requests.rst +++ b/source/WorkingPractices/pull_requests.rst @@ -174,12 +174,10 @@ details see :ref:`updating a branch `. changes from ``main``. Only when the development has been completed and the pull request is almost ready for commit should you merge in ``main``. -Selecting Reviewers -------------------- +---- -There is a space in the pull request template to list the GitHub user ID of the -scitech and code reviewers. Once these are filled in a GitHub Action will add -this user as an ``assignee`` to the pull request. +Managing Reviews +================ .. tip:: @@ -188,6 +186,13 @@ this user as an ``assignee`` to the pull request. always check carefully that the change is sensible and doesn't contain any errors or bugs. +Selecting Reviewers +------------------- + +There is a space in the pull request template to list the GitHub user ID of the +scitech and code reviewers. Github will automatically copy these into the +appropriate :ref:`project spaces `. + SciTech Review ^^^^^^^^^^^^^^ @@ -197,7 +202,7 @@ suggestions for other suitable reviewers or you can approach anyone who would have good insight into the changes made. Once you have found a reviewer add their GitHub user ID to the pull request -description and request their review by clicking the cog on the `Reviewers` +description. Request their review by clicking the cog on the `Reviewers` pane on the right of the pull request and selecting their name or GitHub user ID. @@ -219,46 +224,40 @@ assigned a reviewer on a regular basis. If you need your pull request looking at more urgently than that, or think your pull request has been overlooked, then leave a comment for ``@ssdteam`` on the pull request. -The assigned person will be listed in the pull request description and -selected as a reviewer. A label will also be added to the pull request to help -track which pull requests are waiting for a code reviewer to be assigned. +The assigned person will be listed in the pull request description. Once the +SciTech review has been completed either the developer or SciTech reviewer +should request the review of the assigned Code Reviewer using the method +described above. + Guidance for the Code reviewer can be found on the :ref:`Code review page `. -.. _reviewer_edits: - -Code Reviewer Edits -^^^^^^^^^^^^^^^^^^^ - -As part of the process to commit certain tickets, code reviewers will sometimes -need to commit changes to the branch of a developer. Common reasons for doing -this include, - -* Updating KGO's -* Applying upgrade macros -* Updating commit hashes for linked tickets - -The ability to commit back to another users fork is only available to those with -``maintainer`` access or above and they can only do so for branches with an open -pull request and the ``Allow edits by maintainers`` option selected. +.. _review_project: -Tracking Review Status ----------------------- +Simulation Systems Review Tracker +--------------------------------- All open pull requests will be added to a GitHub Project called -``Review Tracker``. This is used to give pull requests a status that -distinguishes between the different review states. Some states are achieved -automatically, some require changing manually: +``Simulation Systems Review Tracker``. This is used to give pull requests a +status that distinguishes between the different review states, and to monitor +who is doing the reviews. The review names will be automatically filled in +once the user IDs have been added to the pull request description. + +Some states are achieved automatically, some require changing manually: * When the developer feels a PR is ready for the SciTech or Code Reviewer to - look at the state should be **manually** changed to ``SciTech Review`` or - ``Code Review`` as appropriate. + look at (either initially, or after changes have been made) the state should + be **manually** changed to ``SciTech Review`` or ``Code Review`` as + appropriate. * When the SciTech Review has been completed the state should be **manually** changed to Code Review. +* When the Code Review has been completed the state should be **manually** + changed to Approved. + .. image:: images/gh_screenshots/project_scitech_light.png :class: only-light border @@ -268,9 +267,43 @@ automatically, some require changing manually: Automatic changes include: * When changes are requested by a reviewer the state becomes ``Changes Requested`` -* When the pull request has been approved the state becomes ``Approved`` * When the pull request has been merged, or otherwise closed, the state becomes ``Done`` +.. important:: + Changing the project status **does not** notify the reviewer. To do this: + + * When the SciTech Review has been completed you should add the assigned Code + Reviewer to the list of reviewers. This will notify them that their review is + required. + + * If a reviewer has requested changes then you can alert them that you are + ready for another review by using GitHubs `rerequest review` option; selecting + the circling arrows to the right of the reviewers name. + + .. image:: images/gh_screenshots/rerequest_light.png + :class: only-light border + .. image:: images/gh_screenshots/rerequest_dark.png + :class: only-dark border + * You can `@username` in any comment to draw that persons attention to the + pull request. + + +.. _reviewer_edits: + +Code Reviewer Edits +------------------- + +As part of the process to commit certain tickets, code reviewers will sometimes +need to commit changes to the branch of a developer. Common reasons for doing +this include, + +* Updating KGO's +* Applying upgrade macros +* Updating commit hashes for linked tickets + +The ability to commit back to another users fork is only available to those with +``maintainer`` access or above and they can only do so for branches with an open +pull request and the ``Allow edits by maintainers`` option selected. \ No newline at end of file From 0d3423ac78dc371fd14ac1b849298dcc10262cfb Mon Sep 17 00:00:00 2001 From: jennyhickson Date: Wed, 22 Oct 2025 14:56:44 +0100 Subject: [PATCH 2/9] add images --- .../images/gh_screenshots/rerequest_dark.png | Bin 0 -> 5167 bytes .../images/gh_screenshots/rerequest_light.png | Bin 0 -> 5052 bytes 2 files changed, 0 insertions(+), 0 deletions(-) create mode 100644 source/WorkingPractices/images/gh_screenshots/rerequest_dark.png create mode 100644 source/WorkingPractices/images/gh_screenshots/rerequest_light.png diff --git a/source/WorkingPractices/images/gh_screenshots/rerequest_dark.png b/source/WorkingPractices/images/gh_screenshots/rerequest_dark.png new file mode 100644 index 0000000000000000000000000000000000000000..64f6929d7a3d12c6b4069585209b16f40fd1f6b1 GIT binary patch literal 5167 zcmbVQXE>bOx7Q*>3qtfV5@qy==ygVCq7%IYi4rYpFp&|Xj~bjri4eUr>JW@_^xg^4 zMTueba>u#n-Vgsz_qiY5{qFtjXRp21-fOSlZ>>mOh#JK`rh9mJcoZ7yV0}D1{Bd00 zhJ+Z`=90mha6f!+eKlpgvO$(D+?Nk*C)8_ z;^EPvHNZ-S{#LsSq;DS>wGjUi)^OU-{hO^y_~is1etX;p5(3*)l?1)FM}t!G9u#X55>m- zz$o7TcjEH=8354ul0t_iPQyeeJhiS)R^GFj>F1ksi6>%|z4n5Y%8vm#T8YuoWb1?0 z9^Be@gx%Tutt&_%gM-cpUxorO_^n1%ECLR3f`9+6S`xA%-XJa^(bm?6@7XI=DvHx_ zGw}g?7RQOo$B(=Mypq+V2M4Krs88o3a)zw3IpOWU!O|FKZD)3B>Z?VHsHnD>^y;Pc z?`l?Wgo@%=LFjDWFgU#LFe~U(o{~+LV-9wgsx9ZYd;IQYv+QG6vZdeqh=Ky%@u?~M zj>htrQ1>ICE^MRZ$L=?Z?S$U>CFYC|Y0sJ$yW_)4=6}Yql@$^j%h7b@_F1z! zU~sE7Tc%b0ekgo(_>G_MzGmmF@Kk{sz4y9xbZ)NR_Q>;eZMW0%RFj$9E@017_8nMEP7b#x3 zcYg&jp4$GV2Lp|YzJ25Rl6>OCDxcdj8yH-ydpNlqIl=b{V)@i@0ZOJCFw|9+*CCktq8yrlvxcf*q@I13 z-Q-TgD;JjzvF8er#s)+B+D#f7-&um{>Xe_kp{_)9kvJz5BCl@nel%`WZepHcfh{xj z?Q^R?L)6)+Vgwolo3PIW4B|2@2ZLQzg@ML}td4nJyM-+jXOpWoT4s^6Wc4bD?lh0J zROt|g&&Ln4jduN7T`Awxd-AOhX2unlx7=Gv6oP$4;@vTdWe~wCmDKyNm1%k?209D< zHGYCeYI=$WnLY_7Cw|}#`t+MXwkC+tF-C;LuX}lr)7tWWmxUkm8&k=QpiV2|YY79K}FHs~w9vIYP{ck6Rl-W-*|9`s&aKO=e5 zQ3mgQ_Eo2H!NoDps|1e$Vf2qXR7;;e{!QY3O26d*Az^7Hk`S~EOBefYiAZRVQS!CcO%Bw!mH@}_4Ls(0|T3F0K!gJnaBd%VauTmb4bPH z_uGJ@5Z2}~Ts+BF!d4gg%{)KD_!7!C>jn2@utM{hK~k3)%z8r5eXpmI0Y9{^ZE&Hd zeO-sS(rHL&CR5(~IK9_k-Xu19+8a?Lq4)gb8_2Ig&LMvoJX^iiG<)9{c&F~j3}!74A6)fy6`=*Y-A_2<{5{OlV zo|PM~MJrA5wTZ=rPD#j`&rX4Hh-m903r50KmY$?#c@A01OpGOUMD%#a{BZUW^L=_J zMiaG{6&TX@;g=v@qvJ`7rX=Qe!tKg6=yeRwCxs7nDK|*lwh#<^oySVFzs?oPI?z!Z zIc2)21P0HVo~)&MoldnavW0|PR|$)VsPFOf^Z!|)?6Y9k8@aA<<1Z>sxk=zx26e1j zHFsMTzU@SfVO^$rTNXFXv$t86e{BOK)GWoKo;61qvF~iN#KlH~>S0yvA_R5UZjUnq z7OUh?ysCwabb*A;9`_0h8@&7_H>*ZI^-_~E(3IBn=c&()h(g{Wb;;vs5PQ>HLF*W? zsgU)v3lXL3k!6A_Jcra^qE1zZecBi$X@`9}cm=-WgOD3SU^2@IX~txw z_o4|37L?f4)Qn!c_OD%&vqM(Y8@po#bsy6*MN8OW|KfTTN(*qZK#1;b7m95s)CKd0 z$iAC%VvPIv`k^m7O=)NZ>-u-f6C`lrmpnfks!~l$rMF?q7|B&tB*7_`Pwu$pgP%}Y zZ&3*L6rf_vf6mEeQW(-1JYFFgcFG4$PhS01(d-DfZuHIfzAg}D?Hq*4BU&%l=$h-~ zDd+<6-mKq8ZkDyI zzGv1Dj68@4t2i9kLp7!R?6k@45^q-^$u~; zPiaF8sgk9=Z>V`YdC9*TBrw=T&$bIhn5T=s=q#W+(aWb&ji+h&m@YGcS9d+Ta0r^_ zV3$fJx4%>67Zf4!%>3GnX=!0Cl^c*_HMaFuvr|eBDFMB3-*vh?Gwg^TA0wstb@7&m$pB{lvyW5G) z!L)yvDvwRi@Il&_2jo2FVsU$C1n;7SevHQ8h>Do6b9U77B8ZWZmtUqRv+|WV5+LWM zpcxgtw(@jlMy5JlNjOZe;OI*D*WtYE{a_<<&V0(CnUW4s%Sd zho65qC3qoIuBUf8`pYN9u)9?6o8S+dQF2Q$(#bpXVLEq#!$IqZY~7?+x-n56FxH|< z=z!{~9|}6Flbw@Clz!J`iG_yTx(@%(5mujIm`$e}Ve`AuUC-?20hKRPX$Y4nV4Cq+ ze#%hub#}8~@g>2qnvQZws(t~xR)-0nWhSh4dv=4&koL>v%6+C)xS|5Pe?U|Fx}kWS zYY6j=W}&{bEda31?`_W9jA~w15W(Z*v@Iwu@0j+aUHx^E0L!s)743aY?BWc`uBjnX z)6(*+>cSLsu93n-UG{?dGsR5!2;`QRHY2vg64$o1?v9QQl0Q5FE1V-40f3w=%n?oW ziUNsD)1Fh1ZKnU+)b~Ra84Q0c(>B39EfAtInhc621zBdgaoivg0o-6 zQ^z}tcQW)}2m1R1M0nMW3+-spQ*}Bvy2LLT83#QWx{A7oS`$7rpk{t+fBFHP*$@L#ew@0E zk0LLM-OEF0#d!qyIZ5qUf7UIYDhzZO+T5y;i*Jmh>tLqa!I6xCbx@1@!M620XrlaQ zvw8)N=l^dWu|a-zy|pMaPEURHCDl4u$Bh~*%z{CQn0}?9rhfgN4yY$wshoFR)N~JP zSA0A;$u2K;yZ!$)C&>am-hM0(*Swm@J7(Fog9^_x|AN1I$P?g7@vVVXVKTGbzCkVF z=XlBSF~zOi?Yb@oivz^;Fx$t%B^wu5Wai$qq=0Hb`M23Qi4xt&z(_hE*5qN8GWO3A z*hZ0qoKSXYb2H+ZH#6oC<55!s4p!O!vM=_NbtgI>0E-`+j#2X}xnVqhhV+->CTfFF z7Cb@PIhs-4`)oE|jp|UuX-A9`7))x2vO;uqai^tZ@7UPe!#F{3+ttkx5>is5chI7; zGRljSy|&|Ib{w@kJya|j8?2_ixOnbvXPXWDq*N`bzeK8A` z==d!Vxgoi#1qK^yF^Mxx37L|Zn`;FT-GMJ#N#*8Yb?G5Ep>#M()P1`jJNVN7Z1bQ3>adO9PoAfM{HrpIQkZo5kx8*sF3hiKrA zBqQ3*jXUV5?V?9INWG;yz9Npj|OW|DpOp-6MAQjh~7q@6@j%w=aitN?@W}69lJrOPW!dn?Rl%JoJ7{v0{ zlzxe@rq2F71b#zuoN`s3YW#Kb1+D2)WA zvMxWiVz6{#^>cHH4aJ26hY13K+_dxi|&3B_pUnOz-& zStm`hz#m6jbZ-;=m*O|?@#?o0L|jiv8dhzf9Q0nMi3y0$RCGD9|3oKpU|-+b;>?T+ zM4-_$(u3KhqJMMu4edq^rQ$!wsZ%m!Zf(so7uf;tL)Dg9Rxk|7wqm~QM)C6$mJbj9 z3e7wPimDFI->zA|2q-F_{O1x&xVf=AbJc1{wKyi&`yYxk$gXg#%bIkn6OJ4>Ysp|s z*RwL-zcd~cPm}CRjfe;V@$t>+LVKTx`Qb_h%X@DY2uKG8bo_5nezv2MJ&o1N{(?bu zd2JgPR|{`KdK+SS1X7U3w-%0bb$y~QIXg0#ImTi;GyHzSeq?h5TzaEle$SH-Gysl9 z+h1AzQ`9Kv#&}g9Y<08uZm2KJ&wFlIp4ctck}VhQTdY67FBS^wXczUKw2(dR@sdjT z`_gZ}&dVKR2dZF}rQ9hoY zq4{+WcYHE_F6zH{5jv!BK}6@^fMIr`7qE!gUYWq*yd#!wLFT7ZivpU8A3%`c(@5Iq ztu-NrI#f0kv9ruL&{kr+Zd#qsI?=*ehC(amU2FcX4N^&iq=`_2;8gG?{Ziljf{Oc1 z`cSZASDQCC*%mhN>C>kLYPVt`UVfcZ9d_evZrXExL>Cb8BDG2TY#J;LVahpwDPb)? ztPPLd-P-@+tbMY}IOJq&q)NYGKRWB8-;e0*mpd%vjIB(ZZIG``X03bTTc+*5ON+@E z3m$4hPy4?l}eKq*@A>@i0 xhaWhsBf2dv{YL@pU$Ot<+Z)w?>pGgCU|s3!)}^5S@1rQAZn$UZc(EM6VMy-XwYn(YqK7(INyPQnb;H zHfk`4-p+WxbFS;0bDi(U`SI*$muEkF@3q!m>t1)fzODvNR6l6d^Ksbx9 zTiqtbm+{plZ}2Zd9|H|lg4!Rf8~6sXvx<%i0YQBV<%KN?zD@4=)Xax~fco>zL)h}# zZJU6A9;^vcF$%QWo_k?&*BC>JOVj~@XuWz!7=X0IKu;}ep8-CP(^S2Z_fCT8r6r24 z*z9j^SgVhz2~fe0@T^s+`C>XRPeP%4A!ih_<-?b0xwY9IyTU@MgBVN9Pv>k2=T*hI zfNLNZuc+YSVKa@FYe21l;Cy zQ`y16sY2n*7QgN=y}*hu)BeE$_XlRsvM{FkDh@p0?%zT!Ma zwU&7~MI{Y}!(6#kQolzHAG9KJQc@{xTfqHn!YE!>4j}MyG>@FJeQGeChapK%30fZ!o>cbyxD7XV`M#b_*(UG;YGQI&>kRR}}v%+_tznfYH?jEMk_ z&{v_FB%sZH@n_*R#VPW+uPe$o5?adIXP{zdpwtR8EhoC+8HsGI(SP*D+0w^5JS&caiHSQ znwfwxllqx}k-fdBk`sqT@oG%Fp>W}&^gl`3hvjy$_DswIi{&x3Xzfy=G5@SNs&f)D zdt`)c4Q`hjFm8qI&!g)%PGV?+o@>?-kVx7Hf3&MgdShSg=%zrm7yfe z(GAL*@1EfDn;B;QiV)V5d!K#Ayuf9Wlod-d^J+2OM>^2)ch~x!we4m7!@y(D*yNx) z`*dFXHq5Ja(}-lbWBZ9?6&e2u3JZBQ8xNM301n-rvK;FB?``!OtLnm5LpTw7RLTpH zAjua$D36d5ByweXU#bDlHna8g7QKuw7ABV@Vwdwl>1~v?wWoKk+gzo&T#r=wUb0#| zX#x7Advr}d!r0EdyY87UFg0!3Q)yV@&;)@}G-K>wFm_?}K2CWq7AZ9PIlB0DE2C+< zU0yELgGqFw`go=BUO&gwekw*Dv7M)yg>dY692(zl#2D&#UTyRG;HTENPtNH*+IbHRWQCCvzP%4F}GBQ zEGu>wMwK(B4@ zuE*Q(@K|MdfXT^VQ;%lm+T>#))|-!J%!RBMtY+gE?fJeruCHTdLcZPc_rP?mv%8XK z>8?oz%)MLj`!UMSOwKMWn72ZtmR#~|)xoUG}_4Cwpf zHX?!$wZUIt(3hc_rJfu(U}q+OA3H)*qJKfH#Nm62Qj)?NVYB~E`FqyjWmP7s7wj)F zKQM@RKR}5R!=hzpyRquc`>#Dg1h3us>R*%og_>kI84a%O1 zmQr&7l)`)V`}P}X=UUPb_sS8lx!F_#ldupRITJ-!q6|xAV^Yq0w_|hUniaWBn8|E* zYV-$yVPfCWL4I;x;V%>QXY^*%BLJ8kF2*$Xry+X4Rwl!p>X`AJnjvB zAZCEBCNw)S`kR#hYof8;ec5*+UUEir=3J|hI7^>;_iGXhMy1JiURQ?nD||E|r+>S| ze}3?jsL4@(y4{A`p8KP)hxI^xqe3Q`p0MSRp(hXZ&@3z1Z-O*O zolMi$Cw>c4v2ugkQV&KE>ccD zM@XrGlk~lFYB|-%0wZMd;^G!bO6ed!c=5Ix#ShTD(N(N24kn;zh_0uc>Y5wHF&f@? z{`49L_aGY`0;244*W@~TJ1iOw?iL;ud<@Q z;+_-dw-HJDM%Fn#K53o0SG(M2p&Z!m?cf8sW39@_F6DpUp6U8<5mI{i%VW%_+Dx9| z?OA}b!~rW$o<&O5OhVlQdLa1Jed?5rnuP7`cI4$*L22?LtJ^Z-==n?^F8oh2G{Al= z#$|9HD77uBowT_yLkidiNVxRI2zuo~Xze|w4)fgIbQ-3o8g;Cxjy~uUJtW$Ku*VKr zOz?WrZpCn$LXi6mDJ~a&O4R8s0bgs1UebLdiIZ=mR9W&xHc1DaDy{=xB`<7p>MpKw z22Q|08P%)}MfHbrJ-yzak685@_DHgatv#zT-DqY!*mRf`oW*Q%6` zUw%`zefZ=2z-BwB`;&%8Nvn|{#!o`juFv41X*=C0Us#+NA)i;x%B_mr(1oH4+czAC za=N8LYR}7Hfs@7V@K51Ah65)T#nz&i9cG!eNgXy<7D-H(B>w7g0zU+`XaW=3GU)7p zSss)a>di(kGU*m$vL*X3hj=|aH)O>*vbPy!$#e$sB6KWx!gr&36Gd&S0!z!p%v%P0 z(0JsgOY)3AAzokA?^|%4QbHN0F1r#P$1Aq`LX*;|6oDfxuQN~b15%fFJCsHT2SpJ~ z;v&}PTj4CEwcV{k2qn0P9tPooi78^{_56LT==5ox;wZiEX-cB9=lTnaAB~YSKB2$1 zYMmveGm~m5?u<=hEi6(R!z_Zy5>jmQTT}d4XD`Q*2^qf1BS>5KP{D(d0D6%O4khFE_JTi# zT_qju%GybS?K|g?B`isz;ya2q^T*@t+w$nQrEzg_SJYoB7FWM#bFO-`K1@TkRW*bJ zs_DXn-xwNTZ;7%@P6%alKCt@PY?dd3Ej4QE2v$t4TwUESAwfT`#=W{$mh|Hfiz-Yv zUAzIZE>}wox5*XAFjDMH=RfqPnr$=*qV)1(Qy@YY&c&a8k0zof@NhQninkrw{ATNb zu_*O{f$-upC~j~6Z@2%%$_DD{yz07{h}_)nve|oaUx0pk%YH0 z;^Ll?QT;REnJ)esA)}Qg7|Z9L?mhhj?iG6K>Y!n5Ajk3J>(HI_?T}%c>6fDL&4MG7 zhbH*c!^p+);%-#SahamQBt`h@>ix^FUZ4(ff+?_=E4MNaL&pw`}<3$SZeOe_)UT^x^ z&yDGivf);Vg4D_59SqTt_+OF=8&hC!&qAAb3tCGaXlp0v{hh${WPeNG;$##E>ibgJ z5ztWMk}Ry()PHcjNlKYm>AK4;hz;heF+&vhezToI-+OfrQqke~mOg+197=Y7S6y7& zZARdI8?`aZWBp^-l(N+Lxbh+DEAKnjHS-ZsQA8iv7<`!NOGBeXARhb_Pzggr8UD}X zzdG5Ik^y3Gv;8UMj@i31<0ZVnWri&@+}%wt76daV(W&q6ZA%k>oS+-;n702fX`~i) z&!K{q{6o$arcWEy%Z?QB2$Id)+uPR33BhhDD|l(;>FrL$&E4~fTj>+Q9{B{V?;qk$ zB_^IKTQFM+yCSioRn3Z+<54Cp^ zJKsfXVHG>$)HjL`a^Ta=>x+6oDDKXdBWtrayTLSBM`JDtH@}05x(xwuCxrSqg%G^# z1326kF-K7V!6{P18(vsmOAXzSC|k|;+M~Pl6X9$Vbusm64BoY0mRCD(;S&n68?&yD z*90%CpB5pE{hHRUSf(fXSGt;e6LDjVn@T0p=0!|dKzxFz4@ zt0|8}M669(&B7h36lhH5kSywFG^yM71}gR?ebi{n;)}?r{_?$k-y*&m+Qf)_boQk) zck-KSo#Ktf8#z62=3`9g^kudVZ?K#TlF7LHYJFiw9TiR?%R6D-7K(Fr$UOlt^F_aA zW+^>VMXBXa25jl~##~-{j@-dpx=Vs!thaXdNW$%niU!8PBjE?Ad@H>~R=(@*qlw2J z)#LLCwhk5+%o*-m{|Ls>|A8VQ_mu?6J*i!TV0O%}$k2K(th1+~Ga2MggKU%Sp|7*) z@o&SRC5^IOfn66N|AqLX2{#r(O z=VhhEmTR5On;bl)ph$4y&S>R7{~{J-hfn9hS&v=yIi%2!9pu*6H9rbhi9p~n`Pb{g z=?dpz`YFG3r(Y?k9nYlWXTZYRtQE{TZd`|;gxElZ+Zr|Uk(GnzhIg)eMsLBydFokq zXYQ>t{I`^DANj+*h#NW|g3joY80QV9L zq59z*ALy_nV0 zfgt-ELW29iGoV-Q>K0bONzCoV=5G?yPAS^v-Qp?@rnsyjMsE8LQl9tb&uwJw?CQGO zpE0y6oq3!Dz9`qYl)w$Y0D>dYm1u*AleFQwhrb(5$ub$(EU%Kut z$LC)OAd3pY@QdK`gCp7|h#X#W05MPeS|?_M8_Zdg=a(wPY;pp6_cHpXDwu=(w~~$& zt;AEc=opYqft`CjsrwxgMY`OZO)8t|QrU3J6xSM#J?x1i-jk2e-pUXpNxs!wJl2@g z67+~1LQe<82KzlU}{|%|MlO?GJ0_n-PU9 tiYWgh)bQ!xnX8S6e-pBd79+075TEs|xhQ<<@r)aRrkXCOR@ElzKLDxqp*#Qp literal 0 HcmV?d00001 From 38a703a279b9d708bdd8f4056540130698f195a4 Mon Sep 17 00:00:00 2001 From: jennyhickson Date: Wed, 22 Oct 2025 15:24:55 +0100 Subject: [PATCH 3/9] add newline --- source/WorkingPractices/pull_requests.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/WorkingPractices/pull_requests.rst b/source/WorkingPractices/pull_requests.rst index 4e4843ad..d11ea68a 100644 --- a/source/WorkingPractices/pull_requests.rst +++ b/source/WorkingPractices/pull_requests.rst @@ -306,4 +306,4 @@ this include, The ability to commit back to another users fork is only available to those with ``maintainer`` access or above and they can only do so for branches with an open -pull request and the ``Allow edits by maintainers`` option selected. \ No newline at end of file +pull request and the ``Allow edits by maintainers`` option selected. From e148e21e6c66cd95c00e8eebb20cda36030c79f4 Mon Sep 17 00:00:00 2001 From: jennyhickson Date: Thu, 23 Oct 2025 09:49:45 +0100 Subject: [PATCH 4/9] make a separate page --- source/WorkingPractices/pull_requests.rst | 134 ----------------- source/WorkingPractices/reviews.rst | 141 ++++++++++++++++++ source/WorkingPractices/working_practices.rst | 1 + 3 files changed, 142 insertions(+), 134 deletions(-) create mode 100644 source/WorkingPractices/reviews.rst diff --git a/source/WorkingPractices/pull_requests.rst b/source/WorkingPractices/pull_requests.rst index d11ea68a..c834f64c 100644 --- a/source/WorkingPractices/pull_requests.rst +++ b/source/WorkingPractices/pull_requests.rst @@ -173,137 +173,3 @@ details see :ref:`updating a branch `. development should be done on a branch from ``stable`` without merging in changes from ``main``. Only when the development has been completed and the pull request is almost ready for commit should you merge in ``main``. - ----- - -Managing Reviews -================ - -.. tip:: - - Github allows reviewers to directly make suggestions to the code. This is - very useful for easily suggesting changes. However, the developer should - always check carefully that the change is sensible and doesn't contain any - errors or bugs. - -Selecting Reviewers -------------------- - -There is a space in the pull request template to list the GitHub user ID of the -scitech and code reviewers. Github will automatically copy these into the -appropriate :ref:`project spaces `. - -SciTech Review -^^^^^^^^^^^^^^ - -First refusal for completing the SciTech review should go to the main code -owner(s) for the area affected. If they don't want to then they may have -suggestions for other suitable reviewers or you can approach anyone who would -have good insight into the changes made. - -Once you have found a reviewer add their GitHub user ID to the pull request -description. Request their review by clicking the cog on the `Reviewers` -pane on the right of the pull request and selecting their name or GitHub user -ID. - -.. image:: images/gh_screenshots/review_cog_light.png - :class: only-light border - -.. image:: images/gh_screenshots/review_cog_dark.png - :class: only-dark border - -Guidance for the SciTech reviewer can be found on the -:ref:`SciTech review page `. - -Code Review -^^^^^^^^^^^ - -Code reviewers are assigned by the Simulation Systems and Deployment Team from -a pool of repository maintainers. New ``ready for review`` pull requests will be -assigned a reviewer on a regular basis. If you need your pull request looking at -more urgently than that, or think your pull request has been overlooked, then -leave a comment for ``@ssdteam`` on the pull request. - -The assigned person will be listed in the pull request description. Once the -SciTech review has been completed either the developer or SciTech reviewer -should request the review of the assigned Code Reviewer using the method -described above. - - -Guidance for the Code reviewer can be found on the -:ref:`Code review page `. - - -.. _review_project: - -Simulation Systems Review Tracker ---------------------------------- - -All open pull requests will be added to a GitHub Project called -``Simulation Systems Review Tracker``. This is used to give pull requests a -status that distinguishes between the different review states, and to monitor -who is doing the reviews. The review names will be automatically filled in -once the user IDs have been added to the pull request description. - -Some states are achieved automatically, some require changing manually: - -* When the developer feels a PR is ready for the SciTech or Code Reviewer to - look at (either initially, or after changes have been made) the state should - be **manually** changed to ``SciTech Review`` or ``Code Review`` as - appropriate. - -* When the SciTech Review has been completed the state should be **manually** - changed to Code Review. - -* When the Code Review has been completed the state should be **manually** - changed to Approved. - -.. image:: images/gh_screenshots/project_scitech_light.png - :class: only-light border - -.. image:: images/gh_screenshots/project_scitech_dark.png - :class: only-dark border - -Automatic changes include: - -* When changes are requested by a reviewer the state becomes ``Changes Requested`` -* When the pull request has been merged, or otherwise closed, the state becomes - ``Done`` - -.. important:: - Changing the project status **does not** notify the reviewer. To do this: - - * When the SciTech Review has been completed you should add the assigned Code - Reviewer to the list of reviewers. This will notify them that their review is - required. - - * If a reviewer has requested changes then you can alert them that you are - ready for another review by using GitHubs `rerequest review` option; selecting - the circling arrows to the right of the reviewers name. - - .. image:: images/gh_screenshots/rerequest_light.png - :class: only-light border - - .. image:: images/gh_screenshots/rerequest_dark.png - :class: only-dark border - - * You can `@username` in any comment to draw that persons attention to the - pull request. - - -.. _reviewer_edits: - -Code Reviewer Edits -------------------- - -As part of the process to commit certain tickets, code reviewers will sometimes -need to commit changes to the branch of a developer. Common reasons for doing -this include, - -* Updating KGO's -* Applying upgrade macros -* Updating commit hashes for linked tickets - -The ability to commit back to another users fork is only available to those with -``maintainer`` access or above and they can only do so for branches with an open -pull request and the ``Allow edits by maintainers`` option selected. diff --git a/source/WorkingPractices/reviews.rst b/source/WorkingPractices/reviews.rst new file mode 100644 index 00000000..f4ef178b --- /dev/null +++ b/source/WorkingPractices/reviews.rst @@ -0,0 +1,141 @@ +Review Process +============== + +.. tip:: + + Github allows reviewers to directly make suggestions to the code. This is + very useful for easily suggesting changes. However, the developer should + always check carefully that the change is sensible and doesn't contain any + errors or bugs. + +Selecting Reviewers +------------------- + +There is a space in the pull request template to list the GitHub user ID of the +scitech and code reviewers. Github will automatically copy these into the +appropriate :ref:`project spaces `. + +SciTech Review +^^^^^^^^^^^^^^ + +First refusal for completing the SciTech review should go to the main code +owner(s) for the area affected. If they don't want to then they may have +suggestions for other suitable reviewers or you can approach anyone who would +have good insight into the changes made. + +Once you have found a reviewer add their GitHub user ID to the pull request +description and request their review. + +Guidance for the SciTech reviewer can be found on the +:ref:`SciTech review page `. + +Code Review +^^^^^^^^^^^ + +Code reviewers are assigned by the Simulation Systems and Deployment Team from +a pool of repository maintainers. New ``ready for review`` pull requests will be +assigned a reviewer on a regular basis. If you need your pull request looking at +more urgently than that, or think your pull request has been overlooked, then +leave a comment for ``@ssdteam`` on the pull request. + +The assigned person will be listed in the pull request description. Once the +SciTech review has been completed either the developer or SciTech reviewer +should request the review of the assigned Code Reviewer. + +Guidance for the Code reviewer can be found on the +:ref:`Code review page `. + +.. admonition:: Requesting a Review + + Review requests are handled in the ``Reviewers`` pane on the right hand + side of a pull request. + + Select the cog, and then search for the person you wish to review by + either name or GitHub user ID. + + .. image:: images/gh_screenshots/review_cog_light.png + :class: only-light border + + .. image:: images/gh_screenshots/review_cog_dark.png + :class: only-dark border + + + Code owners will automatically be added to this reviewers section based on + the files being changed. + + + +.. _review_project: + +Simulation Systems Review Tracker +--------------------------------- + +All open pull requests will be added to a GitHub Project called +``Simulation Systems Review Tracker``. This is used to give pull requests a +status that distinguishes between the different review states, and to monitor +who is doing the reviews. The review names will be automatically filled in +once the user IDs have been added to the pull request description. + +Some states are achieved automatically, some require changing manually: + +* When the developer feels a PR is ready for the SciTech or Code Reviewer to + look at (either initially, or after changes have been made) the state should + be **manually** changed to ``SciTech Review`` or ``Code Review`` as + appropriate. + +* When the SciTech Review has been completed the state should be **manually** + changed to Code Review. + +* When the Code Review has been completed the state should be **manually** + changed to Approved. + +.. image:: images/gh_screenshots/project_scitech_light.png + :class: only-light border + +.. image:: images/gh_screenshots/project_scitech_dark.png + :class: only-dark border + + +Automatic changes include: + +* When changes are requested by a reviewer the state becomes ``Changes Requested`` +* When the pull request has been merged, or otherwise closed, the state becomes + ``Done`` + +.. important:: + Changing the project status **does not** notify the reviewer. To do this: + + * When the SciTech Review has been completed you should add the assigned Code + Reviewer to the list of reviewers. This will notify them that their review is + required. + + * If a reviewer has requested changes then you can alert them that you are + ready for another review by using GitHubs ``rerequest review`` option; + selecting the circling arrows to the right of the reviewers name. + + .. image:: images/gh_screenshots/rerequest_light.png + :class: only-light border + + .. image:: images/gh_screenshots/rerequest_dark.png + :class: only-dark border + + * You can ``@username`` in any comment to draw that persons attention to the + pull request. + + +.. _reviewer_edits: + +Code Reviewer Edits +------------------- + +As part of the process to commit certain tickets, code reviewers will sometimes +need to commit changes to the branch of a developer. Common reasons for doing +this include, + +* Updating KGO's +* Applying upgrade macros +* Updating commit hashes for linked tickets + +The ability to commit back to another users fork is only available to those with +``maintainer`` access or above and they can only do so for branches with an open +pull request and the ``Allow edits by maintainers`` option selected. diff --git a/source/WorkingPractices/working_practices.rst b/source/WorkingPractices/working_practices.rst index ce4cca48..cfec4e51 100644 --- a/source/WorkingPractices/working_practices.rst +++ b/source/WorkingPractices/working_practices.rst @@ -238,5 +238,6 @@ helpful for documenting and monitoring progress of your work. multi_repository approvals pull_requests + reviews final_steps branch_migration From d5eafb272963382aca0308d7dd16266bc5ecbf8f Mon Sep 17 00:00:00 2001 From: jennyhickson Date: Thu, 23 Oct 2025 10:03:38 +0100 Subject: [PATCH 5/9] tidy whitespace --- source/WorkingPractices/reviews.rst | 3 --- 1 file changed, 3 deletions(-) diff --git a/source/WorkingPractices/reviews.rst b/source/WorkingPractices/reviews.rst index f4ef178b..8bf3070d 100644 --- a/source/WorkingPractices/reviews.rst +++ b/source/WorkingPractices/reviews.rst @@ -59,12 +59,10 @@ Guidance for the Code reviewer can be found on the .. image:: images/gh_screenshots/review_cog_dark.png :class: only-dark border - Code owners will automatically be added to this reviewers section based on the files being changed. - .. _review_project: Simulation Systems Review Tracker @@ -95,7 +93,6 @@ Some states are achieved automatically, some require changing manually: .. image:: images/gh_screenshots/project_scitech_dark.png :class: only-dark border - Automatic changes include: * When changes are requested by a reviewer the state becomes ``Changes Requested`` From 4d287fd474013c0be618ce945130b59abdd999b5 Mon Sep 17 00:00:00 2001 From: jennyhickson Date: Thu, 23 Oct 2025 11:50:04 +0100 Subject: [PATCH 6/9] reshuffle --- source/WorkingPractices/reviews.rst | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/source/WorkingPractices/reviews.rst b/source/WorkingPractices/reviews.rst index 8bf3070d..9585d726 100644 --- a/source/WorkingPractices/reviews.rst +++ b/source/WorkingPractices/reviews.rst @@ -69,10 +69,19 @@ Simulation Systems Review Tracker --------------------------------- All open pull requests will be added to a GitHub Project called -``Simulation Systems Review Tracker``. This is used to give pull requests a -status that distinguishes between the different review states, and to monitor -who is doing the reviews. The review names will be automatically filled in -once the user IDs have been added to the pull request description. +``Simulation Systems Review Tracker``, which causes this box to appear in the +sidebar of the pull request: + +.. image:: images/gh_screenshots/project_scitech_light.png + :class: only-light border + +.. image:: images/gh_screenshots/project_scitech_dark.png + :class: only-dark border + +The project is used to give pull requests a status that distinguishes between +the different review states, and to monitor who is doing the reviews. The review +names will be automatically filled in once the user IDs have been added to the +pull request description. Some states are achieved automatically, some require changing manually: @@ -87,12 +96,6 @@ Some states are achieved automatically, some require changing manually: * When the Code Review has been completed the state should be **manually** changed to Approved. -.. image:: images/gh_screenshots/project_scitech_light.png - :class: only-light border - -.. image:: images/gh_screenshots/project_scitech_dark.png - :class: only-dark border - Automatic changes include: * When changes are requested by a reviewer the state becomes ``Changes Requested`` From 569859f841147ba50e9a4445ae5357d9f9294f23 Mon Sep 17 00:00:00 2001 From: jennyhickson Date: Tue, 18 Nov 2025 14:37:32 +0000 Subject: [PATCH 7/9] tidy up capitals and remove auto-editting project references. --- source/Development/planning_your_change.rst | 6 +++--- source/Development/temp_logicals.rst | 2 +- source/FurtherDetails/coding_style.rst | 9 ++++----- source/FurtherDetails/glossary.rst | 2 +- source/Reviewers/codereview.rst | 10 +++++----- source/Reviewers/howtocommit.rst | 4 ++-- source/Reviewers/index.rst | 8 ++++---- source/Reviewers/scitechreview.rst | 8 ++++---- source/WorkingPractices/final_steps.rst | 2 +- source/WorkingPractices/reviews.rst | 19 +++++++++---------- source/WorkingPractices/working_practices.rst | 8 ++++---- 11 files changed, 38 insertions(+), 40 deletions(-) diff --git a/source/Development/planning_your_change.rst b/source/Development/planning_your_change.rst index 00d2853e..72c6e192 100644 --- a/source/Development/planning_your_change.rst +++ b/source/Development/planning_your_change.rst @@ -61,9 +61,9 @@ aware of these. `__ * `PEP 8 (Python) `__ -**Who will SciTech review the change?** This is a useful consideration as not +**Who will SciTech Review the change?** This is a useful consideration as not everyone who uses the repository has the knowledge or experience to review -every change that is being developed. Get in touch with your SciTech reviewer +every change that is being developed. Get in touch with your SciTech Reviewer early in the process as they will have valuable insights that can help to shape your change. @@ -97,7 +97,7 @@ upgrade macro to include the switch into the upgraded configuration. vital to make sure your code changes work when switched **on** and give the same answer when the code is run over different processor configurations. Producing a quick plot or plots to show the impact of your code and including -them on your pull request can aid your SciTech reviewer in showing that your code +them on your pull request can aid your SciTech Reviewer in showing that your code works properly. **Does the change need any new diagnostics to make sense of the code?** Many diff --git a/source/Development/temp_logicals.rst b/source/Development/temp_logicals.rst index 0d2fdc1a..6ed92a3e 100644 --- a/source/Development/temp_logicals.rst +++ b/source/Development/temp_logicals.rst @@ -23,7 +23,7 @@ for two reasons: Neither of these statements suggest that the fix shouldn't be included --- in fact the opposite is true. The decision as to whether to include a temporary logical normally rests with the configuration owner, but with guidance from -the CodeSys reviewer and the Simulation Systems and Deployment team. In such +the Code Reviewer and the Simulation Systems and Deployment team. In such cases, the following guidance is followed: * Essential bug fixes (e.g. something which would on occasions cause the model diff --git a/source/FurtherDetails/coding_style.rst b/source/FurtherDetails/coding_style.rst index b10392e5..b8090b0e 100644 --- a/source/FurtherDetails/coding_style.rst +++ b/source/FurtherDetails/coding_style.rst @@ -1906,7 +1906,7 @@ rules are imposed. .. _`sec:reviews`: -Code reviews +Code Reviews ============ In order to ensure that these standards are adhered to and are having the @@ -1921,12 +1921,11 @@ performed in the order below: `__ page on the UM homepage. -#. A code/system review is performed to analyse the change for its impact, +#. A Code Review is performed to analyse the change for its impact, ensure that it meets this coding standard and to ensure that all concerned parties are made aware of changes that are required. Guidance for reviewers - is outlined in `Code/System Review Guidance - `__ - page on the UM homepage. + is outlined in `Code Review Guidance page + `__. .. _Appendix A: diff --git a/source/FurtherDetails/glossary.rst b/source/FurtherDetails/glossary.rst index 9e56310f..9b07c25c 100644 --- a/source/FurtherDetails/glossary.rst +++ b/source/FurtherDetails/glossary.rst @@ -13,7 +13,7 @@ Code Review Deadline: The date by which all pull requests aiming to be included in a release have been moved into code review. -CodeSys Review: +Code Review: A technical review of the changes involved in the pull request, including checks that code standards have been upheld and that the working practices have been followed. These reviews are generally completed by a member of the diff --git a/source/Reviewers/codereview.rst b/source/Reviewers/codereview.rst index c93ec445..d65cf0dc 100644 --- a/source/Reviewers/codereview.rst +++ b/source/Reviewers/codereview.rst @@ -1,7 +1,7 @@ .. _code_review: -Code and System Review -====================== +Code Review +=========== .. tip:: @@ -12,7 +12,7 @@ Code and System Review Purpose of the review --------------------- -The purpose of the code/system review is to analyse a change for its impact and +The purpose of the Code Review is to analyse a change for its impact and to ensure that all concerned parties are made aware of changes that are required. @@ -32,7 +32,7 @@ contains a Code Review section with questions to help you think through all the areas of concern. This Code Review section should be completed once you are finished. -Work through the code review template considering each question in turn. These +Work through the review template considering each question in turn. These will include areas such as: .. dropdown:: Is the pull request and testing complete? @@ -120,7 +120,7 @@ Final decision points and actions --------------------------------- The pull request will likely iterate between the reviewer and the developer -during the review process while retaining it's code review status. The Code +during the review process while retaining it's Code Review status. The Code Reviewer can `Resolve Conversations` when they feel each query has been satisfactorily answered. diff --git a/source/Reviewers/howtocommit.rst b/source/Reviewers/howtocommit.rst index c117caa3..e47eba50 100644 --- a/source/Reviewers/howtocommit.rst +++ b/source/Reviewers/howtocommit.rst @@ -442,8 +442,8 @@ KGO differently* .. tab-item:: LFRic Apps + LFRic Core KGO Checksums are stored in the repository alongside the code and can - be updated using a script. This can be done by either the code - reviewer or by the developer (before submitting their changes for + be updated using a script. This can be done by either the Code + Reviewer or by the developer (before submitting their changes for review). In the latter case, the update will need redoing by the reviewer before commit if there are merge conflicts in the checksum files. diff --git a/source/Reviewers/index.rst b/source/Reviewers/index.rst index 8129a818..d3f99b04 100644 --- a/source/Reviewers/index.rst +++ b/source/Reviewers/index.rst @@ -6,15 +6,15 @@ Guides for Reviewers PRs will pass through a two-stage review. Linked PRs should work through this process together. -The first, scitech, review is carried out by someone with a good understanding +The first, SciTech, review is carried out by someone with a good understanding of the area being developed. Once satisfied they then pass the PR to a -code reviewer who takes a bigger picture and system view of the change. -Trivial PRs can bypass the scitech review. +Code Reviewer who takes a bigger picture and system view of the change. +Trivial PRs can bypass the SciTech Review. The change then passes to the Code Reviewer and in this stage the developer is encouraged to merge ``main`` into their branch and resolve any conflicts. -Once the reviews are complete the code reviewer is then responsible for the +Once the reviews are complete the Code Reviewer is then responsible for the final merge and commit of the change to ``main``. diff --git a/source/Reviewers/scitechreview.rst b/source/Reviewers/scitechreview.rst index 468d46c2..beb3ab24 100644 --- a/source/Reviewers/scitechreview.rst +++ b/source/Reviewers/scitechreview.rst @@ -26,7 +26,7 @@ Reviewer responsibilities and checkpoints The pull request template that populates the pull request description box contains a SciTech Review section with questions to help you think through all -the areas of concern. This SciTech review section should be completed once you are finished. +the areas of concern. This SciTech Review section should be completed once you are finished. The Science / Technical reviewer should @@ -59,10 +59,10 @@ The science/technical reviewer must demand that non-compliance is corrected before a change is passed onto the next level of review. The pull request will likely iterate between the reviewer and the developer during -the review process while retaining it's sci/tech review status. +the review process while retaining it's SciTech Review status. -Once you are happy that the change is appropriate and correct, and the sci-tech -review parts of the pull request template have been completed then change +Once you are happy that the change is appropriate and correct, and the SciTech +Review parts of the pull request template have been completed then change the review state to Code Review and leave an approving review. .. image:: ../WorkingPractices/images/gh_screenshots/project_scitech_light.png diff --git a/source/WorkingPractices/final_steps.rst b/source/WorkingPractices/final_steps.rst index cb4e61dc..24063165 100644 --- a/source/WorkingPractices/final_steps.rst +++ b/source/WorkingPractices/final_steps.rst @@ -10,7 +10,7 @@ there may be several commits to different trunks involved. Sometimes there can be a delay between a code change being approved and the commit to ``main``. This can be for a number of reasons and rarely will be - due to your change. If you have any concerns, please contact your CodeSys + due to your change. If you have any concerns, please contact your Code Reviewer in the first instance. Overnight and Weekly Testing diff --git a/source/WorkingPractices/reviews.rst b/source/WorkingPractices/reviews.rst index 9585d726..3bb68014 100644 --- a/source/WorkingPractices/reviews.rst +++ b/source/WorkingPractices/reviews.rst @@ -12,8 +12,8 @@ Selecting Reviewers ------------------- There is a space in the pull request template to list the GitHub user ID of the -scitech and code reviewers. Github will automatically copy these into the -appropriate :ref:`project spaces `. +scitech and code reviewers. These can also be filled into the appropriate +:ref:`project spaces `. SciTech Review ^^^^^^^^^^^^^^ @@ -38,9 +38,10 @@ assigned a reviewer on a regular basis. If you need your pull request looking at more urgently than that, or think your pull request has been overlooked, then leave a comment for ``@ssdteam`` on the pull request. -The assigned person will be listed in the pull request description. Once the -SciTech review has been completed either the developer or SciTech reviewer -should request the review of the assigned Code Reviewer. +The assigned person will be listed in the pull request description and +:ref:`Review Tracking project `. Once the SciTech review has +been completed either the developer or SciTech reviewer should request the +review of the assigned Code Reviewer. Guidance for the Code reviewer can be found on the :ref:`Code review page `. @@ -59,8 +60,8 @@ Guidance for the Code reviewer can be found on the .. image:: images/gh_screenshots/review_cog_dark.png :class: only-dark border - Code owners will automatically be added to this reviewers section based on - the files being changed. + Code owners in some repositories will automatically be added to this + reviewers section based on the files being changed. .. _review_project: @@ -79,9 +80,7 @@ sidebar of the pull request: :class: only-dark border The project is used to give pull requests a status that distinguishes between -the different review states, and to monitor who is doing the reviews. The review -names will be automatically filled in once the user IDs have been added to the -pull request description. +the different review states, and to monitor who is doing the reviews. Some states are achieved automatically, some require changing manually: diff --git a/source/WorkingPractices/working_practices.rst b/source/WorkingPractices/working_practices.rst index f4dc2590..ed2d160f 100644 --- a/source/WorkingPractices/working_practices.rst +++ b/source/WorkingPractices/working_practices.rst @@ -86,7 +86,7 @@ Remote Upstream The primary or parent repository, owned by the MetOffice GitHub - organisation. Only code reviewers are able to directly interact with this + organisation. Only Code Reviewers are able to directly interact with this repository, rather than being required to use forks. @@ -156,13 +156,13 @@ The development cycle can be seen below. and you have included proof of local testing. #. Pass the pull request for review. Usually this will involve first a - :ref:`Sci Tech review ` and then a :ref:`Code review + :ref:`SciTech review ` and then a :ref:`Code Review `. If any changes are required ensure the testing still passes. - * Once in code review, you will likely need to update your branch to the + * Once in Code Review, you will likely need to update your branch to the :ref:`head of main `. This may involve solving merge conflicts. -#. Once the pull request has been approved, the code reviewer will merge it to +#. Once the pull request has been approved, the Code Reviewer will merge it to `main`. For detailed explanation of these steps, see the subsequent pages, particularly From 1c37995950cf799546d49351e95cf02134b2a26b Mon Sep 17 00:00:00 2001 From: jennyhickson Date: Thu, 20 Nov 2025 10:23:20 +0000 Subject: [PATCH 8/9] fix --'s --- source/Reviewers/howtocommit.rst | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/source/Reviewers/howtocommit.rst b/source/Reviewers/howtocommit.rst index e47eba50..a6284235 100644 --- a/source/Reviewers/howtocommit.rst +++ b/source/Reviewers/howtocommit.rst @@ -106,17 +106,17 @@ To update the test suite for an upgrade macro, please run: --um=vnXX.Y_tZZZZ \ [--jules-path=/path/to/jules/clone] - where ``-\-um=vnXX.Y_tZZZZ`` is the ``AFTER_TAG`` of the latest + where ``--um=vnXX.Y_tZZZZ`` is the ``AFTER_TAG`` of the latest upgrade macro. If there is a macro for fcm_make or createbc then check that the makes ``version*_*.py`` has the correct BEFORE and AFTER tags and - append ``-\-makeum=vnXX.Y_tZZZZ`` and/or - ``-\-createbc=vnXX.Y_tZZZZ`` to the above command. + append ``--makeum=vnXX.Y_tZZZZ`` and/or + ``--createbc=vnXX.Y_tZZZZ`` to the above command. .. note:: - The ``-\-jules-path`` option is only required if there are + The ``--jules-path`` option is only required if there are linked changes to the ``rose-meta/jules-shared`` directory in the Jules repository. From f88ece26b80ed859931cfce7f7a8cf88a9256f05 Mon Sep 17 00:00:00 2001 From: jennyhickson Date: Thu, 20 Nov 2025 11:46:10 +0000 Subject: [PATCH 9/9] clarify scitech --- source/Reviewers/scitechreview.rst | 15 +++++++++++---- source/WorkingPractices/reviews.rst | 2 ++ 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/source/Reviewers/scitechreview.rst b/source/Reviewers/scitechreview.rst index beb3ab24..76ecef56 100644 --- a/source/Reviewers/scitechreview.rst +++ b/source/Reviewers/scitechreview.rst @@ -55,18 +55,25 @@ The Science / Technical reviewer should Final decision points and actions --------------------------------- -The science/technical reviewer must demand that non-compliance is corrected +The SciTech reviewer must demand that non-compliance is corrected before a change is passed onto the next level of review. The pull request will likely iterate between the reviewer and the developer during the review process while retaining it's SciTech Review status. -Once you are happy that the change is appropriate and correct, and the SciTech -Review parts of the pull request template have been completed then change -the review state to Code Review and leave an approving review. +Once you are happy that the change is appropriate and correct: + +#. Ensure the the SciTech parts of the pull request template have been completed. +#. Leave an approving review +#. Change the review state to Code Review +#. Request the review of the nominated Code Reviewer (or leave them a + message with ``@username`` if their review has already been requested) + +These steps are covered in more detail as part of the :ref:`review_process` .. image:: ../WorkingPractices/images/gh_screenshots/project_scitech_light.png :class: only-light border .. image:: ../WorkingPractices/images/gh_screenshots/project_scitech_dark.png :class: only-dark border. + diff --git a/source/WorkingPractices/reviews.rst b/source/WorkingPractices/reviews.rst index 3bb68014..71a76214 100644 --- a/source/WorkingPractices/reviews.rst +++ b/source/WorkingPractices/reviews.rst @@ -1,3 +1,5 @@ +.. _review_process: + Review Process ==============