Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid wallet_requestSnaps and wallet_invokeSnap specs #204

Open
Mrtenz opened this issue Mar 25, 2024 · 1 comment
Open

Invalid wallet_requestSnaps and wallet_invokeSnap specs #204

Mrtenz opened this issue Mar 25, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Mrtenz
Copy link
Member

Mrtenz commented Mar 25, 2024

wallet_requestSnaps and wallet_invokeSnap use an object as params, but on the docs, the params are currently being wrapped in an array.

The spec and examples should be updated to use this format:

wallet_requestSnaps

type Request = {
  method: 'wallet_requestSnaps';
  params: Record<SnapId, { version?: SemVerVersion; }>;
}

wallet_invokeSnap

type Request = {
  method: 'wallet_invokeSnap',
  params: {
    snapId: SnapId;
    request: {
      method: string;
      params: Json;
    }
  }
}
@Mrtenz Mrtenz added the bug Something isn't working label Mar 25, 2024
@shanejonas
Copy link
Contributor

rel #193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants