fix: remove duplicate gas fee tokens check (#7234)

## Explanation

Remove unnecessary additional call to `checkGasFeeTokenBeforePublish`.

## References

Related to
[#23137](MetaMask/metamask-mobile#23137)

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs)
- [x] I've introduced [breaking
changes](https://github.com/MetaMask/core/tree/main/docs/breaking-changes.md)
in this PR and have prepared draft pull requests for clients and
consumer packages to resolve them

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Removes the redundant gas fee token/balance check during approval (now
only checked post-beforeSign), adds a log when skipping nonce for
external signing, and updates the changelog.
> 
> - **Transaction Controller**:
> - Remove duplicate `checkGasFeeTokenBeforePublish` invocation in
`#approveTransaction`; gas fee tokens/balance are now checked only in
`#signTransaction` after the `beforeSign` hook.
> - **Utils**:
> - Add log in `utils/nonce#getNextNonce` when skipping nonce for
`isExternalSign`.
> - **Changelog**:
> - Document fix to check balance and gas fee tokens only after before
sign hook.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
38f9eca. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: matthewwalsh0

packages/transaction-controller/CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+
+- Check balance and gas fee tokens only after before sign hook ([#7234](https://github.com/MetaMask/core/pull/7234))
+
 ## [62.2.0]
 
 ### Added

packages/transaction-controller/src/TransactionController.ts

@@ -3176,17 +3176,6 @@ export class TransactionController extends BaseController<
       const { networkClientId } = transactionMeta;
       const ethQuery = this.#getEthQuery({ networkClientId });
 
-      await checkGasFeeTokenBeforePublish({
-        ethQuery,
-        fetchGasFeeTokens: async (tx) =>
-          (await this.#getGasFeeTokens(tx)).gasFeeTokens,
-        transaction: transactionMeta,
-        updateTransaction: (txId, fn) =>
-          this.#updateTransactionInternal({ transactionId: txId }, fn),
-      });
-
-      transactionMeta = this.#getTransactionOrThrow(transactionId);
-
       const [nonce, releaseNonce] = await getNextNonce(
         transactionMeta,
         (address: string) =>

packages/transaction-controller/src/utils/nonce.ts

@@ -27,6 +27,7 @@ export async function getNextNonce(
   } = txMeta;
 
   if (isExternalSign) {
+    log('Skipping nonce as signed externally');
     return [undefined, undefined];
   }