Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[network-controller] Add lookupNetwork timeout #4499

Open
Gudahtt opened this issue Jul 3, 2024 · 0 comments
Open

[network-controller] Add lookupNetwork timeout #4499

Gudahtt opened this issue Jul 3, 2024 · 0 comments

Comments

@Gudahtt
Copy link
Member

Gudahtt commented Jul 3, 2024

The NetworkController method lookupNetwork doesn't currently have a timeout. The default fetch timeout is quite long, leading to long delays in situations where we're waiting to know whether the network is accessible or not. We should add a timeout of 5 seconds. We can assume that networks that take longer than that to respond are inaccessible.

Acceptance Criteria

  • Add a timeout on the lookupNetwork method
  • Add unit tests for this change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant