Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[base-controller,polling-controller] Make non-controller superclass compatible with polling-controller mixins #4503

Open
MajorLift opened this issue Jul 3, 2024 · 0 comments

Comments

@MajorLift
Copy link
Contributor

Some of our classes that were previously labeled as controllers have empty state, making them non-controllers.

As part of Wallet Framework team's Q3 2024 OKRs (O1KR1), we're currently in the process of upgrading these non-controllers to use the messenger pattern without inheriting from BaseController.

Some non-controllers have empty state but still use polling patterns (e.g. TokenDetectionController). We should define new PollingController mixins or extend the existing ones so that they can serve as superclasses for non-controllers as well as controllers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant