Skip to content

Conversation

@georgewrmarshall
Copy link
Contributor

@georgewrmarshall georgewrmarshall commented Sep 26, 2025

Description

Adds a new Storybook example story that demonstrates the layered background token system and text/icon color variations. This story provides a visual showcase for testing and reviewing the brand color token updates implemented in PR #839.

The story includes layered background examples (default → section → subsection), modal-style overlays, and comprehensive text/icon color demonstrations to validate the design token hierarchy and ensure proper color contrast relationships.

Related issues

Related to: #839

Manual testing steps

  1. Run Storybook: yarn storybook
  2. Navigate to "Examples/Backgrounds" in the sidebar
  3. Review the layered background demonstrations:
    • Background DefaultBackground SectionBackground Subsection hierarchy
    • Background Alternative with Background Default overlay (modal example)
  4. Verify text and icon color variations:
    • Default text/icon colors
    • Alternative text/icon colors (updated to #9b9b9b)
    • Muted text/icon colors (updated to #48484e)
  5. Compare with main branch Storybook to observe color differences
  6. Test in both light and dark themes to ensure proper token application
  7. Verify proper color contrast and visual hierarchy

Screenshots/Recordings

Before

No previous version - this is a new story

After

Screenshot 2025-10-22 at 1 37 30 PM Screenshot 2025-10-22 at 1 38 05 PM

Pre-merge author checklist

  • I've followed MetaMask Contributor Docs
  • I've completed the PR template to the best of my ability
  • I've included tests if applicable
  • I've documented my code using JSDoc format if applicable
  • I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds Backgrounds example stories (web and React Native) demonstrating layered background tokens and text/icon color variants, and registers the RN story in Storybook config.

  • Storybook:
    • New examples: Adds Examples/Backgrounds stories in apps/storybook-react/stories/Backgrounds.stories.tsx and apps/storybook-react-native/stories/Backgrounds.stories.tsx showcasing layered background tokens (BackgroundDefault → BackgroundSection → BackgroundSubsection) with text/icon color variants and button examples.
    • React Native config: Registers the new story in apps/storybook-react-native/.storybook/storybook.requires.js.

Written by Cursor Bugbot for commit 5b50dee. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

📖 Storybook Preview

@github-actions
Copy link
Contributor

📖 Storybook Preview

@georgewrmarshall georgewrmarshall self-assigned this Sep 26, 2025
@georgewrmarshall georgewrmarshall marked this pull request as ready for review September 26, 2025 17:00
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner September 26, 2025 17:00
@github-actions
Copy link
Contributor

📖 Storybook Preview

@github-actions
Copy link
Contributor

📖 Storybook Preview

@github-actions
Copy link
Contributor

📖 Storybook Preview

@georgewrmarshall georgewrmarshall force-pushed the background-section-example branch from 06fd588 to 25def11 Compare October 1, 2025 21:54
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

📖 Storybook Preview

@georgewrmarshall georgewrmarshall marked this pull request as draft October 14, 2025 17:42
@github-actions
Copy link
Contributor

📖 Storybook Preview

@georgewrmarshall georgewrmarshall marked this pull request as ready for review October 22, 2025 20:38
@georgewrmarshall georgewrmarshall merged commit afa28e7 into main Oct 22, 2025
43 checks passed
@georgewrmarshall georgewrmarshall deleted the background-section-example branch October 22, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants