feat: ask user confirmation on unpair #537
Conversation
OGPoyraz
force-pushed
the
feat/403-ask-user-why-they-are-unpairing-the-desktop-app
branch
from
6f39757
to
199d0c9
Compare
* extension update * chore: update ci and lavamoat
* chore: electron upgrade * fix: use node-fetch instead of node 18 fetch * fix: restore extension commit * fix: restore commitid submodule --------- Co-authored-by: Matthew Walsh <[email protected]>
* chore: update submodule * fix: restore submodule commitid * chore: submodule
OGPoyraz
force-pushed
the
feat/403-ask-user-why-they-are-unpairing-the-desktop-app
branch
from
752ee4c
to
04ef013
Compare
packages/app/src/app/desktop-app.ts
Outdated
| }) | ||
| .then(async (value) => { | ||
| if (value.response === 0) { | ||
| this.metricsService.track(EVENT_NAMES.DESKTOP_APP_UNPAIRED, { |
There was a problem hiding this comment.
Do we not want this inside the disable method so it's done at the source?
There was a problem hiding this comment.
Good question, it actually depends if we want to capture this event regardless of the answer for this confirmation.
I will ask @vinistevam
There was a problem hiding this comment.
Yeap makes sense to move it to disable.
OGPoyraz
force-pushed
the
feat/403-ask-user-why-they-are-unpairing-the-desktop-app
branch
from
e73e082
to
4ee33fe
Compare
OGPoyraz
force-pushed
the
feat/403-ask-user-why-they-are-unpairing-the-desktop-app
branch
from
b542369
to
8477307
Compare
OGPoyraz
force-pushed
the
feat/403-ask-user-why-they-are-unpairing-the-desktop-app
branch
from
01eecbe
to
5cb0ad4
Compare
|
Hf6 |
|
CLA Signature Action: Thank you for your submission, we really appreciate it. We ask that you all read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:
By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository. 1 out of 3 committers have signed the CLA. |
Overview
This PR implements a confirmation dialog when the user tries to unpair while paired.