fix: cp-7.56.0 generate metrics for failed transactions on startup (#20248)

## **Description**

Generate metrics for incomplete transactions on startup.

Redirect to Perps market view after Perps deposit.

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Fixes:
[#5862](MetaMask/MetaMask-planning#5862)

## **Manual testing steps**

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Author: matthewwalsh0

app/components/Views/confirmations/hooks/transactions/useTransactionConfirm.test.ts

@@ -300,7 +300,7 @@ describe('useTransactionConfirm', () => {
   });
 
   describe('navigates to', () => {
-    it('wallet view if perps deposit', async () => {
+    it('perps market if perps deposit', async () => {
       useTransactionMetadataRequestMock.mockReturnValue({
         id: transactionIdMock,
         type: TransactionType.perpsDeposit,
@@ -310,7 +310,9 @@ describe('useTransactionConfirm', () => {
 
       await result.current.onConfirm();
 
-      expect(mockNavigate).toHaveBeenCalledWith(Routes.WALLET_VIEW);
+      expect(mockNavigate).toHaveBeenCalledWith(Routes.PERPS.ROOT, {
+        screen: Routes.PERPS.MARKETS,
+      });
     });
 
     it('transactions if full screen', async () => {

app/components/Views/confirmations/hooks/transactions/useTransactionConfirm.ts

@@ -87,7 +87,9 @@ export function useTransactionConfirm() {
     );
 
     if (type === TransactionType.perpsDeposit) {
-      navigation.navigate(Routes.WALLET_VIEW);
+      navigation.navigate(Routes.PERPS.ROOT, {
+        screen: Routes.PERPS.MARKETS,
+      });
     } else if (isFullScreenConfirmation) {
       navigation.navigate(Routes.TRANSACTIONS_VIEW);
     } else {

app/core/Engine/controllers/transaction-controller/event-handlers/metrics.test.ts

@@ -44,6 +44,10 @@ jest.mock('../../../../Analytics/MetricsEventBuilder', () => ({
   },
 }));
 
+jest.mock('../../../Engine', () => ({
+  context: {},
+}));
+
 describe('Transaction Metric Event Handlers', () => {
   const mockGetSmartTransactionMetricsProperties = jest.mocked(
     getSmartTransactionMetricsProperties,

app/core/Engine/controllers/transaction-controller/event-handlers/metrics.ts

@@ -16,8 +16,11 @@ import type {
   TransactionEventHandlerRequest,
   TransactionMetricsBuilder,
 } from '../types';
-import Logger from '../../../../../util/Logger';
 import { getMetaMaskPayProperties } from '../event_properties/metamask-pay';
+import Engine from '../../../Engine';
+import { createProjectLogger } from '@metamask/utils';
+
+const log = createProjectLogger('transaction-metrics');
 
 const METRICS_BUILDERS: TransactionMetricsBuilder[] = [
   getMetaMaskPayProperties,
@@ -30,51 +33,57 @@ const createTransactionEventHandler =
     transactionMeta: TransactionMeta,
     transactionEventHandlerRequest: TransactionEventHandlerRequest,
   ) => {
-    const defaultTransactionMetricProperties =
-      await generateDefaultTransactionMetrics(
-        eventType,
-        transactionMeta,
-        transactionEventHandlerRequest,
-      );
-
-    const metrics = {
-      properties: defaultTransactionMetricProperties.properties,
-      sensitiveProperties:
-        defaultTransactionMetricProperties.sensitiveProperties,
-    };
+    try {
+      const defaultTransactionMetricProperties =
+        await generateDefaultTransactionMetrics(
+          eventType,
+          transactionMeta,
+          transactionEventHandlerRequest,
+        );
 
-    const allTransactions =
-      transactionEventHandlerRequest.getState()?.engine?.backgroundState
-        ?.TransactionController?.transactions ?? [];
+      const metrics = {
+        properties: defaultTransactionMetricProperties.properties,
+        sensitiveProperties:
+          defaultTransactionMetricProperties.sensitiveProperties,
+      };
 
-    const getUIMetrics = getConfirmationMetricProperties.bind(
-      null,
-      transactionEventHandlerRequest.getState,
-    );
+      const allTransactions =
+        transactionEventHandlerRequest.getState()?.engine?.backgroundState
+          ?.TransactionController?.transactions ?? [];
 
-    const getState = transactionEventHandlerRequest.getState;
+      const getUIMetrics = getConfirmationMetricProperties.bind(
+        null,
+        transactionEventHandlerRequest.getState,
+      );
 
-    for (const builder of METRICS_BUILDERS) {
-      try {
-        const currentMetrics = builder({
-          transactionMeta,
-          allTransactions,
-          getUIMetrics,
-          getState,
-        });
-
-        merge(metrics, currentMetrics);
-      } catch (error) {
-        // Intentionally empty
+      const getState = transactionEventHandlerRequest.getState;
+
+      for (const builder of METRICS_BUILDERS) {
+        try {
+          const currentMetrics = builder({
+            transactionMeta,
+            allTransactions,
+            getUIMetrics,
+            getState,
+          });
+
+          merge(metrics, currentMetrics);
+        } catch (error) {
+          // Intentionally empty
+        }
       }
-    }
 
-    const event = generateEvent({
-      ...defaultTransactionMetricProperties,
-      ...metrics,
-    });
+      const event = generateEvent({
+        ...defaultTransactionMetricProperties,
+        ...metrics,
+      });
 
-    MetaMetrics.getInstance().trackEvent(event);
+      log('Event', event);
+
+      MetaMetrics.getInstance().trackEvent(event);
+    } catch (error) {
+      log('Error in transaction event handler', error);
+    }
   };
 
 /**
@@ -125,55 +134,91 @@ export async function handleTransactionFinalizedEventForMetrics(
   transactionMeta: TransactionMeta,
   transactionEventHandlerRequest: TransactionEventHandlerRequest,
 ): Promise<void> {
-  // Generate default properties
-  const defaultTransactionMetricProperties =
-    await generateDefaultTransactionMetrics(
-      TRANSACTION_EVENTS.TRANSACTION_FINALIZED,
-      transactionMeta,
-      transactionEventHandlerRequest,
-    );
-
-  // Generate smart transaction properties if applicable
-  let smartTransactionProperties = { properties: {}, sensitiveProperties: {} };
   try {
-    const { getState, initMessenger, smartTransactionsController } =
-      transactionEventHandlerRequest;
-    const shouldUseSmartTransaction = selectShouldUseSmartTransaction(
-      getState(),
-      transactionMeta.chainId,
-    );
-    if (shouldUseSmartTransaction) {
-      const smartMetrics = await getSmartTransactionMetricsProperties(
-        smartTransactionsController,
+    if (
+      retryIfEngineNotInitialized(() => {
+        handleTransactionFinalizedEventForMetrics(
+          transactionMeta,
+          transactionEventHandlerRequest,
+        );
+      })
+    ) {
+      return;
+    }
+
+    // Generate default properties
+    const defaultTransactionMetricProperties =
+      await generateDefaultTransactionMetrics(
+        TRANSACTION_EVENTS.TRANSACTION_FINALIZED,
         transactionMeta,
-        true,
-        initMessenger as unknown as BaseControllerMessenger,
+        transactionEventHandlerRequest,
       );
-      smartTransactionProperties = {
-        properties: smartMetrics,
-        sensitiveProperties: {},
-      };
+
+    // Generate smart transaction properties if applicable
+    let smartTransactionProperties = {
+      properties: {},
+      sensitiveProperties: {},
+    };
+    try {
+      const { getState, initMessenger, smartTransactionsController } =
+        transactionEventHandlerRequest;
+      const shouldUseSmartTransaction = selectShouldUseSmartTransaction(
+        getState(),
+        transactionMeta.chainId,
+      );
+      if (shouldUseSmartTransaction) {
+        const smartMetrics = await getSmartTransactionMetricsProperties(
+          smartTransactionsController,
+          transactionMeta,
+          true,
+          initMessenger as unknown as BaseControllerMessenger,
+        );
+        smartTransactionProperties = {
+          properties: smartMetrics,
+          sensitiveProperties: {},
+        };
+      }
+    } catch (error) {
+      log('Error getting smart transaction metrics', error);
     }
+
+    // Add RPC properties
+    const rpcProperties = generateRPCProperties(transactionMeta.chainId);
+
+    // Merge default, smart transaction, and RPC properties
+    const mergedEventProperties = merge(
+      {},
+      defaultTransactionMetricProperties,
+      smartTransactionProperties,
+      {
+        properties: rpcProperties.properties,
+        sensitiveProperties: rpcProperties.sensitiveProperties,
+      },
+    );
+
+    // Generate and track the event
+    const event = generateEvent(mergedEventProperties);
+
+    log('Finalized event', event);
+
+    MetaMetrics.getInstance().trackEvent(event);
   } catch (error) {
-    Logger.log('Error getting smart transaction metrics:', error);
+    log('Error in finalized transaction event handler', error);
   }
+}
 
-  // Add RPC properties
-  const rpcProperties = generateRPCProperties(transactionMeta.chainId);
-
-  // Merge default, smart transaction, and RPC properties
-  const mergedEventProperties = merge(
-    {},
-    defaultTransactionMetricProperties,
-    smartTransactionProperties,
-    {
-      properties: rpcProperties.properties,
-      sensitiveProperties: rpcProperties.sensitiveProperties,
-    },
-  );
+function retryIfEngineNotInitialized(fn: () => void): boolean {
+  try {
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    const { context } = Engine;
+    return false;
+  } catch (e) {
+    log('Transaction controller event before engine initialized');
 
-  // Generate and track the event
-  const event = generateEvent(mergedEventProperties);
+    setTimeout(() => {
+      fn();
+    }, 5000);
 
-  MetaMetrics.getInstance().trackEvent(event);
+    return true;
+  }
 }

app/core/Engine/controllers/transaction-controller/transaction-controller-init.ts

@@ -58,6 +58,12 @@ export const TransactionControllerInit: ControllerInitFunction<
     smartTransactionsController,
   } = getControllers(request);
 
+  addTransactionControllerListeners({
+    initMessenger,
+    getState,
+    smartTransactionsController,
+  });
+
   try {
     const transactionController: TransactionController =
       new TransactionController({
@@ -122,12 +128,6 @@ export const TransactionControllerInit: ControllerInitFunction<
         publicKeyEIP7702: AppConstants.EIP_7702_PUBLIC_KEY as Hex | undefined,
       });
 
-    addTransactionControllerListeners({
-      initMessenger,
-      getState,
-      smartTransactionsController,
-    });
-
     return { controller: transactionController };
   } catch (error) {
     Logger.error(error as Error, 'Failed to initialize TransactionController');

app/core/Engine/controllers/transaction-controller/utils.ts

@@ -175,9 +175,16 @@ export async function generateDefaultTransactionMetrics(
 
   const { from } = txParams || {};
 
-  const accountType = isValidHexAddress(from)
-    ? getAddressAccountType(from)
-    : 'unknown';
+  let accountType = 'unknown';
+
+  // Fails if wallet locked
+  try {
+    accountType = isValidHexAddress(from)
+      ? getAddressAccountType(from)
+      : accountType;
+  } catch {
+    // Intentionally empty
+  }
 
   const batchProperties = await getBatchProperties(transactionMeta);
   const gasFeeProperties = getGasMetricProperties(transactionMeta);