[Bug]: The Pure JS example doesn't work, fail to detect Metamask extension

[jimgreen2013]

SDK

Web

Provide environment information

I've tried firefox, chromium and Braver browser, my os is Linux/Fedora

MetaMask SDK Version

0.18.5

MetaMask Mobile app Version

Just web

What browser are you using? (if relevant)

No response

How are you deploying your application? (if relevant)

No response

Describe the Bug

Expected Behavior

Link to reproduction - Issues with a link to complete (but minimal) reproduction code will be addressed faster

https://github.com/MetaMask/metamask-sdk/tree/main/packages/examples/pure-javascript

To Reproduce

open the index.html and click connect

[christopherferreira9]

Hi @jimgreen2013 ! I wasn't able to reproduce this using OSX. Will try to give this one a go using Linux. I'll get back to this issue as soon as possible.

[jimgreen2013]

Hi @jimgreen2013 ! I wasn't able to reproduce this using OSX. Will try to give this one a go using Linux. I'll get back to this issue as soon as possible.

I try my best to do some investigation, here are my findings:

1. the vue example worked as expected;
2. The key difference is that the vue example successfully inject window.etherum and window.extension while the pureJs example only inject window.etherum.

[jimgreen2013]

@christopherferreira9 Finally, I find out the reason, it's not a bug but due to opening the index.html directly in the browser instead of serving it through a http server.

I have updated the README file and add more information, here is the pull request #930

[christopherferreira9]

awesome @jimgreen2013 ! We'll be addressing your PR soon. I'm closing this issue in the meantime.