Add test

Author: FrederikBolding

packages/snaps-controllers/src/services/AbstractExecutionService.test.ts

@@ -164,4 +164,39 @@ describe('AbstractExecutionService', () => {
       }),
     ).rejects.toThrow(`${MOCK_SNAP_ID} failed to start.`);
   });
+
+  it('skips metamask_chainChanged JSON-RPC notifications', async () => {
+    const { service } = createService(MockExecutionService);
+
+    await service.executeSnap({
+      snapId: 'TestSnap',
+      sourceCode: `
+        module.exports.onRpcRequest = () => null;
+      `,
+      endowments: [],
+    });
+
+    const { streams, worker } = service.getJobs().values().next().value;
+    const postMessageSpy = jest.spyOn(worker, 'postMessage');
+
+    streams.rpc.write({
+      name: 'metamask-provider',
+      data: { method: 'metamask_chainChanged' },
+    });
+
+    streams.rpc.write({
+      name: 'metamask-provider',
+      data: { id: 'foo', result: '1' },
+    });
+
+    expect(postMessageSpy).toHaveBeenCalledTimes(1);
+    expect(postMessageSpy).toHaveBeenCalledWith({
+      data: {
+        name: 'jsonRpc',
+        data: { data: { id: 'foo', result: '1' }, name: 'metamask-provider' },
+      },
+    });
+
+    await service.terminateAllSnaps();
+  });
 });

packages/snaps-execution-environments/src/common/endowments/network.ts

@@ -256,11 +256,12 @@ const createNetwork = ({ notify }: EndowmentFactoryOptions = {}) => {
         } finally {
           if (openFetchConnection !== undefined) {
             openConnections.delete(openFetchConnection);
+
+            await notify({
+              method: 'OutboundResponse',
+              params: { source: 'fetch' },
+            });
           }
-          await notify({
-            method: 'OutboundResponse',
-            params: { source: 'fetch' },
-          });
         }
 
         if (res.body !== null) {