This repository was archived by the owner on Dec 28, 2021. It is now read-only.
fixed some ansible-lint messages - #1
Open
flamableconcrete wants to merge 1 commit into
Open
Conversation
Author
|
Sad day :( Thanks Travis-CI though! |
Contributor
|
Hey Jared! Thanks for your improvements which unfortunately do not work yet. I tried to use the ansible module to download the package before but couldn't make it work, hence the curl call. As the unarchive module currently does not support the stripping of directory levels one could extract the directory to a temporary location and move the result around but I would like to postpone the changes to the next major version of the role (which will require newer Ansible version) for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm actually not on a machine I can test this, but it looks like it should work. The only thing I would be concerned about is the
line in the unarchive module. I've never used that before, but who knows - hopefully it should work! And apparently Ansible is adding in the --strip option to the unarchive module soon anyway - ansible/ansible-modules-core#2480.