Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotly formatting #63

Closed
eroten opened this issue Aug 4, 2023 · 0 comments · Fixed by #64
Closed

Plotly formatting #63

eroten opened this issue Aug 4, 2023 · 0 comments · Fixed by #64
Assignees
Labels
enhancement New feature or request

Comments

@eroten
Copy link
Collaborator

eroten commented Aug 4, 2023

See _plotly_layout.R

Desired features

  • flexible function naming. It would be great to follow the council_{object} syntax, but I've already been using plotly_layout() in several projects. Could we use a simple alias (see https://stackoverflow.com/a/57441165)
  • flexible parameter naming - x, x_title both pass to the x-axis title text
  • ... to pass additional arguments to plotly::layout(). Show example with legend = list(orientation = "h"), yaxis = list(tickformat = "1%")
  • examples and documentation - probably updating the Colors vignette
  • font access checks - plotly need access to the various HelveticaNeue woff files. see also separate font load from theme_council()  #47, describe how to install fonts for new users #46
@eroten eroten added the enhancement New feature or request label Aug 4, 2023
@eroten eroten self-assigned this Aug 4, 2023
@eroten eroten linked a pull request Aug 24, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant