feat(Twitter): Add support for Twitter timelines (#120)

* Solving #97

* Update tests

* Update src/transformers/Twitter.js

(for the sake of consistency)

Co-authored-by: Michaël De Boey <[email protected]>

* Update src/__tests__/transformers/Twitter.js

As far as we know, this can't be created

Co-authored-by: Michaël De Boey <[email protected]>

* Update src/__tests__/transformers/Twitter.js

This too, is not possible.

Co-authored-by: Michaël De Boey <[email protected]>

* Update src/__tests__/transformers/__fixtures__/Twitter.md

This too, is not possible.

Co-authored-by: Michaël De Boey <[email protected]>

Co-authored-by: Agastya Chandrakant <[email protected]>
Co-authored-by: Michaël De Boey <[email protected]>

Author: acagastya

src/__tests__/transformers/Twitter.js

@@ -9,14 +9,16 @@ import { cache, getMarkdownASTForFile, parseASTToMarkdown } from '../helpers';
 const { Response } = jest.requireActual('node-fetch');
 jest.mock('node-fetch', () => jest.fn());
 
-const mockFetch = (status, moment) =>
+const mockFetch = (status, moment, timeline) =>
   fetchMock
     .mockResolvedValueOnce(new Response(JSON.stringify({ html: status })))
     .mockResolvedValueOnce(new Response(JSON.stringify({ html: status })))
     .mockResolvedValueOnce(new Response(JSON.stringify({ html: moment })))
     .mockResolvedValueOnce(new Response(JSON.stringify({ html: moment })))
     .mockResolvedValueOnce(new Response(JSON.stringify({ html: moment })))
-    .mockResolvedValueOnce(new Response(JSON.stringify({ html: moment })));
+    .mockResolvedValueOnce(new Response(JSON.stringify({ html: moment })))
+    .mockResolvedValueOnce(new Response(JSON.stringify({ html: timeline })))
+    .mockResolvedValueOnce(new Response(JSON.stringify({ html: timeline })));
 
 beforeEach(() => {
   fetchMock.mockReset();
@@ -48,6 +50,10 @@ cases(
       url: 'https://this-is-not-twitter.com/foobar/status/123',
       valid: false,
     },
+    "non-Twitter url ending with 'twitter.com' and having '/timelines/'": {
+      url: 'https://this-is-not-twitter.com/foobar/timelines/123',
+      valid: false,
+    },
     'profile url': {
       url: 'https://twitter.com/MichaelDeBoey93',
       valid: false,
@@ -80,6 +86,14 @@ cases(
       url: 'https://www.twitter.com/i/events/994601867987619840',
       valid: true,
     },
+    'timelines url': {
+      url: 'https://twitter.com/wesbos/timelines/1189618481672667136',
+      valid: true,
+    },
+    "timelines url having 'www' subdomain": {
+      url: 'https://www.twitter.com/wesbos/timelines/1189618481672667136',
+      valid: true,
+    },
   }
 );
 
@@ -111,10 +125,25 @@ test('Gets the correct Twitter moment link', async () => {
   );
 });
 
+test('Gets the correct Twitter timeline link', async () => {
+  mockFetch(
+    `<a class="twitter-timeline-mocked-fetch-transformer" href="https://twitter.com/wesbos/timelines/1189618481672667136">🔥 Hot Tips from Wes Bos - Curated tweets by wesbos</a>`
+  );
+
+  const html = await getHTML(
+    'https://twitter.com/wesbos/timelines/1189618481672667136'
+  );
+
+  expect(html).toMatchInlineSnapshot(
+    `"<a class=\\"twitter-timeline-mocked-fetch-transformer\\" href=\\"https://twitter.com/wesbos/timelines/1189618481672667136\\">🔥 Hot Tips from Wes Bos - Curated tweets by wesbos</a>"`
+  );
+});
+
 test('Plugin can transform Twitter links', async () => {
   mockFetch(
     `<blockquote class="twitter-tweet-mocked-fetch-plugin"><p lang="en" dir="ltr">example</p>&mdash; Kent C. Dodds (@kentcdodds) <a href="https://twitter.com/kentcdodds/status/1078755736455278592">December 28, 2018</a></blockquote>`,
-    `<a class="twitter-moment-mocked-fetch-plugin" href="https://twitter.com/i/moments/994601867987619840">🔥 Design Tips</a>`
+    `<a class="twitter-moment-mocked-fetch-plugin" href="https://twitter.com/i/moments/994601867987619840">🔥 Design Tips</a>`,
+    `<a class="twitter-timeline-mocked-fetch-plugin" href="https://twitter.com/wesbos/timelines/1189618481672667136">🔥 Hot Tips from Wes Bos - Curated tweets by wesbos</a>`
   );
   const markdownAST = getMarkdownASTForFile('Twitter');
 
@@ -131,6 +160,8 @@ test('Plugin can transform Twitter links', async () => {
 
     <https://this-is-not-twitter.com/foobar/status/123>
 
+    <https://this-is-not-twitter.com/foobar/timelines/123>
+
     <https://twitter.com/MichaelDeBoey93>
 
     <https://twitter.com/i/moments/edit/994601867987619840>
@@ -146,6 +177,10 @@ test('Plugin can transform Twitter links', async () => {
     <a class=\\"twitter-moment-mocked-fetch-plugin\\" href=\\"https://twitter.com/i/moments/994601867987619840\\">🔥 Design Tips</a>
 
     <a class=\\"twitter-moment-mocked-fetch-plugin\\" href=\\"https://twitter.com/i/moments/994601867987619840\\">🔥 Design Tips</a>
+
+    <a class=\\"twitter-timeline-mocked-fetch-plugin\\" href=\\"https://twitter.com/wesbos/timelines/1189618481672667136\\">🔥 Hot Tips from Wes Bos - Curated tweets by wesbos</a>
+
+    <a class=\\"twitter-timeline-mocked-fetch-plugin\\" href=\\"https://twitter.com/wesbos/timelines/1189618481672667136\\">🔥 Hot Tips from Wes Bos - Curated tweets by wesbos</a>
     "
   `);
 });

src/__tests__/transformers/__fixtures__/Twitter.md

@@ -8,6 +8,8 @@ https://this-is-not-twitter.com/i/moments/123
 
 https://this-is-not-twitter.com/foobar/status/123
 
+https://this-is-not-twitter.com/foobar/timelines/123
+
 https://twitter.com/MichaelDeBoey93
 
 https://twitter.com/i/moments/edit/994601867987619840
@@ -23,3 +25,7 @@ https://www.twitter.com/i/moments/994601867987619840
 https://twitter.com/i/events/994601867987619840
 
 https://www.twitter.com/i/events/994601867987619840
+
+https://twitter.com/wesbos/timelines/1189618481672667136
+
+https://www.twitter.com/wesbos/timelines/1189618481672667136

src/transformers/Twitter.js

@@ -6,7 +6,7 @@ export const shouldTransform = (url) => {
   return (
     ['twitter.com', 'www.twitter.com'].includes(host) &&
     (pathname.includes('/status/') ||
-      (includesSomeOfArray(pathname, ['/events/', '/moments/']) &&
+      (includesSomeOfArray(pathname, ['/events/', '/moments/', '/timelines/']) &&
         !pathname.includes('/edit/')))
   );
 };