From 04d92c636f9b3ae62ceedac7572069756c2b5c09 Mon Sep 17 00:00:00 2001 From: Eugene Medvedev Date: Wed, 21 Jun 2023 19:09:06 +0300 Subject: [PATCH] =?UTF-8?q?=E2=9A=99=EF=B8=8F=20Cleanup=20for=20next=20rel?= =?UTF-8?q?ease.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- README.md | 6 +----- go.mod | 3 +-- main.go | 6 ------ 3 files changed, 2 insertions(+), 13 deletions(-) diff --git a/README.md b/README.md index 812982a..334d332 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ This is highly experimental. -Do not use this program for anything critical. Right now it's still very much an evening project waiting for feedback from people trying to use it. The signature format is not yet stable, and neither is the text mode format. +Do not use this program for anything critical. Right now it's still very much an evening project waiting for feedback from people trying to use it. The text mode format in particular is probably not stable. Please experiment with it, that's the right word. @@ -60,10 +60,6 @@ There is currently no way for us to know if a user's certificate has been revoke Similarly, there is no way to prevent someone from using an expired certificate, since they can set the clock to what they want. -### RSA keys - -`lotw-trust` currently assumes that LoTW issues and will forever issue only RSA-based x509 certificates. This is not guaranteed. In fact, it'd be better if they switched to something more modern, even if I would have to code to handle that. - ### General caveats I am not a cryptographer, I am a sociologist. Golang is not my best language, it's just the one that got me the result the quickest, while still allowing to easily make a cross-platform tool. diff --git a/go.mod b/go.mod index 3552272..2d725f4 100644 --- a/go.mod +++ b/go.mod @@ -10,9 +10,8 @@ require ( software.sslmate.com/src/go-pkcs12 v0.2.0 ) -require github.com/x448/float16 v0.8.4 // indirect - require ( + github.com/x448/float16 v0.8.4 // indirect golang.org/x/crypto v0.10.0 // indirect golang.org/x/sys v0.9.0 // indirect ) diff --git a/main.go b/main.go index 7bbfb9f..2f5dd95 100644 --- a/main.go +++ b/main.go @@ -12,7 +12,6 @@ import ( "fmt" "io" "log" - "math" "os" "path/filepath" "strings" @@ -326,11 +325,6 @@ func main() { sigBlock := append([]byte(sigHeader), compressedSig...) - // If the sig block somehow got longer than 65kb, we have a problem anyway. - if len(sigBlock) > math.MaxUint16 { - l.Fatal("Signature block too long, which means something else went wrong.") - } - var savingData []byte if textMode {