Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toFormat pollutes the global scope #2

Open
oscsx opened this issue Dec 5, 2018 · 0 comments
Open

toFormat pollutes the global scope #2

oscsx opened this issue Dec 5, 2018 · 0 comments

Comments

@oscsx
Copy link

oscsx commented Dec 5, 2018

Hi,

This library creates the toFormat function in the global scope and does not provide a no conflict option. This has the potential to cause issues within applications that also make use of the global scope.

I already have a fix for this, I'll be submitting a PR.
oscsx added a commit to oscsx/toFormat that referenced this issue Dec 5, 2018
@oscsx
Fix for MikeMcl#2 - toFormat pollutes the global scope
a0de5f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oscsx