Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code for "hyp_mlr" #6

Open
JinhwiPark opened this issue Feb 24, 2023 · 2 comments
Open

Code for "hyp_mlr" #6

JinhwiPark opened this issue Feb 24, 2023 · 2 comments

Comments

@JinhwiPark
Copy link

JinhwiPark commented Feb 24, 2023

Hi, thanks for the interesting paper.

I think the following part is the code for hyperbolic logit (paper equation(7)), and it seems that there is no $\lambda_{p_{y}}^{c}$ in the code:

return 2.0 / tf.sqrt(c) * A_norm * tf.asinh(sineterm)

Could you check this?

@JinhwiPark JinhwiPark changed the title Code for " Code for "hyp_mlr" Feb 24, 2023
@seanzhuh
Copy link

seanzhuh commented Jan 5, 2024

Hi, I've encountered the same issue, and another problem I found out was that the input to tf.asinh does not divide w_y also

@jhindel
Copy link

jhindel commented Feb 6, 2024

I agree with @seanzhuh and @JinhwiPark. lambda is always set to 2 and w_y seems to be missing in the denominator. Is there any reason for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants