Reduce logging footprint -- reduce significant figures by rounding floats in logs

[jkrauska]

Preliminary Checks

• This issue is not a duplicate. Before opening a new issue, please search existing issues: https://github.com/MinaProtocol/mina/issues
• This issue is not a question, feature request, RFC, or anything other than a bug report. Please post those things in GitHub Discussions: https://github.com/MinaProtocol/mina/discussions

Description

Every few seconds I see log lines that could be a lot simplier.

They are using up lots of bytes in logs with irrelevant data -- round some floats please.

eg:
2021-10-03 19:50:03 UTC [Info] Updating new available work took 5.097389221191406 ms

should really be written at most as
2021-10-03 19:50:03 UTC [Info] Updating new available work took 5.097 ms

Steps to Reproduce

1. Run a node
2. Watch logs
3. Think about what's relevant

Expected Result

2021-10-03 19:50:03 UTC [Info] Updating new available work took 5.097 ms

Actual Result

2021-10-03 19:50:03 UTC [Info] Updating new available work took 5.097389221191406 ms

How frequently do you see this issue?

Always

What is the impact of this issue on your ability to run a node?

Low

Status

NA

Additional information

code:

mina/src/lib/work_selector/work_lib.ml

Line 79 in b137fbd

[%log info] "Updating new available work took $time ms"

rounding floats:
https://discuss.ocaml.org/t/rounding-floats-to-number-of-decimals/6921/3

[joseandro]

Thanks for your suggestion @jkrauska. I will convert this Issue into a Discussion so that it can be properly discussed between the community.