Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch container logging to a log driver #246

Open
nwneisen opened this issue Oct 3, 2023 · 0 comments · May be fixed by #252
Open

Switch container logging to a log driver #246

nwneisen opened this issue Oct 3, 2023 · 0 comments · May be fixed by #252
Labels
enhancement New feature or request

Comments

@nwneisen
Copy link
Collaborator

nwneisen commented Oct 3, 2023

Current Behavior

The current change made in #224 tails the log file created by docker. This works but there are some potential issues with it on windows.

Solution

A better setup would be to write a container log driver that cri-dockerd installs when it is installed. This log driver would write the log output to both the standard docker json file and the kube cri formatted file.

A fallback could also be setup, in case the driver isn't installed, which attaches to the container and streams the log output using https://docs.docker.com/engine/api/v1.43/#tag/Container/operation/ContainerAttach or https://docs.docker.com/engine/api/v1.43/#tag/Container/operation/ContainerLogs

@nwneisen nwneisen added the enhancement New feature or request label Oct 3, 2023
@nwneisen nwneisen linked a pull request Oct 11, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant