Reuse Ping messages (ava-labs#1503)

Co-authored-by: Stephen <[email protected]>

Author: dboehm-avalabs

network/network.go

@@ -199,6 +199,11 @@ func NewNetwork(
 		return nil, fmt.Errorf("initializing network metrics failed with: %w", err)
 	}
 
+	pingMessge, err := msgCreator.Ping()
+	if err != nil {
+		return nil, fmt.Errorf("initializing common ping message failed with: %w", err)
+	}
+
 	peerConfig := &peer.Config{
 		ReadBufferSize:       config.PeerReadBufferSize,
 		WriteBufferSize:      config.PeerWriteBufferSize,
@@ -217,6 +222,7 @@ func NewNetwork(
 		PongTimeout:          config.PingPongTimeout,
 		MaxClockDifference:   config.MaxClockDifference,
 		ResourceTracker:      config.ResourceTracker,
+		PingMessage:          pingMessge,
 	}
 	onCloseCtx, cancel := context.WithCancel(context.Background())
 	n := &network{

network/peer/config.go

@@ -44,4 +44,6 @@ type Config struct {
 
 	// Tracks CPU/disk usage caused by each peer.
 	ResourceTracker tracker.ResourceTracker
+
+	PingMessage message.OutboundMessage
 }

network/peer/peer.go

@@ -516,9 +516,8 @@ func (p *peer) sendPings() {
 				}
 			}
 
-			msg, err := p.MessageCreator.Ping()
-			p.Log.AssertNoError(err)
-			p.Send(p.onClosingCtx, msg)
+			p.Config.PingMessage.AddRef()
+			p.Send(p.onClosingCtx, p.Config.PingMessage)
 		case <-p.onClosingCtx.Done():
 			return
 		}

network/peer/peer_test.go

@@ -72,6 +72,9 @@ func makeRawTestPeers(t *testing.T) (*rawTestPeer, *rawTestPeer) {
 
 	mc := newMessageCreator(t)
 
+	pingMessage, err := mc.Ping()
+	assert.NoError(err)
+
 	metrics, err := NewMetrics(
 		logging.NoLog{},
 		"",
@@ -95,6 +98,7 @@ func makeRawTestPeers(t *testing.T) (*rawTestPeer, *rawTestPeer) {
 		PongTimeout:          constants.DefaultPingPongTimeout,
 		MaxClockDifference:   time.Minute,
 		ResourceTracker:      resourceTracker,
+		PingMessage:          pingMessage,
 	}
 	peerConfig0 := sharedConfig
 	peerConfig1 := sharedConfig

network/peer/test_peer.go

@@ -94,6 +94,12 @@ func StartTestPeer(
 	if err != nil {
 		return nil, err
 	}
+
+	pingMessage, err := mc.Ping()
+	if err != nil {
+		return nil, err
+	}
+
 	peer := Start(
 		&Config{
 			Metrics:             metrics,
@@ -119,6 +125,7 @@ func StartTestPeer(
 			PongTimeout:          constants.DefaultPingPongTimeout,
 			MaxClockDifference:   time.Minute,
 			ResourceTracker:      resourceTracker,
+			PingMessage:          pingMessage,
 		},
 		conn,
 		cert,