* fixed: failed to build RoboVM using Java19

## Root cases:
- Tests started to fail due JDK changes in toString() of annotations (openjdk/jdk#7418).
- Eclipse Tycho has to be updated to know JDK19-env

## Fixes:
- tycho updated to 3.0.3. This also cause update-side to be migrated to repository (as first one was removed) -- completely not tested
- test cases: host JDK18 and JDK19 has different behaviour -- test cases were updated just to recognize this case and adapt string to match JDK18/RoboVM

Author: dkimitsa

.github/workflows/snapshot.yml

@@ -44,4 +44,4 @@ jobs:
       - name: Deploy idea plugin
         run: aws s3 sync ./plugins/idea/build/distributions/ s3://${{ secrets.AWS_BUCKET }}/snapshots/idea --acl public-read --follow-symlinks --delete
       - name: Deploy eclipse plugin
-        run: aws s3 sync ./plugins/eclipse/update-site/target/site/ s3://${{ secrets.AWS_BUCKET }}/snapshots/eclipse --acl public-read --follow-symlinks --delete
+        run: aws s3 sync ./plugins/eclipse/update-site/target/repository/ s3://${{ secrets.AWS_BUCKET }}/snapshots/eclipse --acl public-read --follow-symlinks --delete

compiler/compiler/src/test/java/org/robovm/compiler/plugin/annotation/AnnotationImplPluginTest.java

@@ -195,7 +195,7 @@ public void testCreateImplNoMembers() throws Exception {
         assertTrue(annotation.equals(impl1));
         assertTrue(impl1.equals(annotation));
         assertEquals(annotation.hashCode(), impl1.hashCode());
-        assertEquals(annotation.toString(), impl1.toString());
+        assertEquals(toString(annotation), toString(impl1));
         assertSame(annotation.annotationType(), impl1.annotationType());
     }
 
@@ -359,4 +359,33 @@ public Class<?> loadClass(String name) throws ClassNotFoundException {
         }.loadClass(className);
         return implClass;
     }
+
+    // dkitmisa: JDK19+ uses getCanonicalName() instead of getName() to build toString()
+    //           as result this will make tests to fail as RoboVM uses old one.
+    //           at same time have to keep compatibility when running on JDK18- hosts.
+    //           workaround is to replace getCanonicalName() with getName() in returned string
+    //           to make it looks same as on RoboVM and JDK18-
+    //           details: https://github.com/openjdk/jdk/pull/7418
+    private static String toString(Annotation anno) {
+        String s = anno.toString();
+        if (java19orHigher) {
+            String canonicalName = anno.annotationType().getCanonicalName();
+            String binaryName = anno.annotationType().getName();
+            if (canonicalName != null && !canonicalName.isEmpty() && !canonicalName.equals(binaryName) &&
+                s.startsWith("@" + canonicalName + "("))  {
+                // replace canonical class name with binary name to keep compatibility with RoboVM implementation
+                return "@" + binaryName + "(" + s.substring(2 + canonicalName.length());
+            }
+        }
+
+        return s;
+    }
+    private final static boolean java19orHigher = isJava19orHigher();
+    private static boolean isJava19orHigher() {
+        try {
+            return Integer.parseInt(System.getProperty("java.specification.version")) >= 19;
+        } catch (NumberFormatException ignored) {
+            return false;
+        }
+    }
 }

plugins/eclipse/pom.xml

@@ -29,7 +29,7 @@
 
     <properties>
         <robovm.version>2.3.19-SNAPSHOT</robovm.version>
-        <tycho.version>2.5.0</tycho.version>
+        <tycho.version>3.0.3</tycho.version>
         <eclipse-site>https://download.eclipse.org/releases/2021-09/</eclipse-site>
     </properties>
 

plugins/eclipse/update-site/site.xml plugins/eclipse/update-site/category.xml

@@ -11,5 +11,5 @@
 
     <artifactId>org.robovm.eclipse.update-site</artifactId>
     <name>RoboVM for Eclipse Update Site</name>
-    <packaging>eclipse-update-site</packaging>
+    <packaging>eclipse-repository</packaging>
 </project>

plugins/eclipse/update-site/pom.xml

@@ -29,7 +29,7 @@ git push
 
 # Copy the update-site/target/ to whereever you want it
 ssh [email protected] "mkdir -p /usr/share/nginx/html/downloads/releases/eclipse/$RELEASE_VERSION"
-scp -r update-site/target/site/ [email protected]:/usr/share/nginx/html/downloads/releases/eclipse/$RELEASE_VERSION/
+scp -r update-site/target/repository/ [email protected]:/usr/share/nginx/html/downloads/releases/eclipse/$RELEASE_VERSION/
 
 # Set the pom version to the next development version
 mvn org.eclipse.tycho:tycho-versions-plugin:1.5.1:set-version -DnewVersion="$DEVELOPMENT_VERSION-SNAPSHOT"