Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACTION: chalk breaking change #155

Open
nicolas377 opened this issue Jan 17, 2022 · 3 comments
Open

ACTION: chalk breaking change #155

nicolas377 opened this issue Jan 17, 2022 · 3 comments
Assignees
@nicolas377

Comments

@nicolas377
Copy link
Collaborator

About a month ago, I merged #134 into master, which was a breaking version of chalk. I hadn't properly tested the change, and it seems that chalk has changed directions to use ESM, and not support CommonJS. This can be demonstrated by using the current state of master (at commit 4684574), and running npx extension-cli. You should see this error (unneeded dirs blacked out):

image

I'll be working on fixing this, but this will remain a tracking issue.
@nicolas377 nicolas377 self-assigned this Jan 17, 2022
@nicolas377
Copy link
Collaborator Author

@nkrusch wanted to ping you to let you know about this

@nicolas377 nicolas377 mentioned this issue Jan 17, 2022
Merged
1 task
@nicolas377
Copy link
Collaborator Author

I'm going to commit a temporary fix to this, which will just be a reversion to chalk v4. At that point, I'll start work on a PR to use ESM (we may potentially need to use module bundling for that).

nicolas377 added a commit that referenced this issue Jan 17, 2022
@nicolas377
fix(deps): downgraded chalk to v4
fee1634 
This reverts commit e7c7af0.

Chalk v5 is a pure ESM package, which we are not compatible with as of yet.

This is part of the fix detailed in #155.
@nicolas377
Copy link
Collaborator Author

@nkrusch I've gotten the master version stable. I won't be making any new commits to master for a while, so if you want to, now would be a great time to do a patch release.

@nicolas377 nicolas377 mentioned this issue Mar 17, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolas377 nicolas377

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolas377