Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplication #33

Closed
nkrusch opened this issue Dec 19, 2020 · 1 comment · Fixed by #92, #93, #95 or #94
Closed

Remove duplication #33

nkrusch opened this issue Dec 19, 2020 · 1 comment · Fixed by #92, #93, #95 or #94
Labels
refactor Improve implementation of existing code

Comments

@nkrusch
Copy link
Contributor

nkrusch commented Dec 19, 2020

As per code climate analysis, there are similar blocks here that can be refactored.

Screen Shot 2020-12-19 at 4 23 55 PM
@nkrusch nkrusch added good first issue refactor Improve implementation of existing code labels Dec 19, 2020
This was linked to pull requests Jul 25, 2021
Duplication #92
Merged
Duplication #93
Merged
nkrusch added a commit that referenced this issue Jul 25, 2021
@nkrusch
Merge pull request #94 from MobileFirstLLC/quality
1048cc8 
Quality (#33)
nkrusch added a commit that referenced this issue Jul 25, 2021
@nkrusch
Merge pull request #95 from MobileFirstLLC/complexity
59357bd 
Complexity (#33)
@nkrusch nkrusch linked a pull request Jul 25, 2021 that will close this issue
Complexity #95
Merged
@nkrusch
Copy link
Contributor Author

nkrusch commented Jul 25, 2021

fixed most reported issues; the remaining relate to #23

@nkrusch nkrusch closed this as completed Jul 25, 2021
@nkrusch nkrusch linked a pull request Jul 25, 2021 that will close this issue
Quality #94
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Improve implementation of existing code
Milestone
No milestone
1 participant
@nkrusch