Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【discuss】Should the log file loaded with encoding UTF-8 ? #197

Closed
qmkCamel opened this issue Dec 15, 2023 · 0 comments
Closed

【discuss】Should the log file loaded with encoding UTF-8 ? #197

qmkCamel opened this issue Dec 15, 2023 · 0 comments

Comments

@qmkCamel
Copy link

We use the XCLogParser to parse our team‘s xcactivitylog, when we read the parsed result found some Garbled text.
I scan the repo found the follow code, it seems to load the log file with encoding ascii.
Would the UTF-8 encoding be a better choice?

XCLogParser/Sources/XCLogParser/loglocation/LogLoader.swift

Line 29 in cd41cfc

guard let contents = String(data: unzipped, encoding: .ascii) else {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@qmkCamel