Update LLVM and Swift files for Swift 6 #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated some files from https://github.com/apple/llvm-project and https://github.com/swiftlang/swift. I'm not confident that I did this correctly, but the tests do pass and this does fix MobileNativeFoundation#60. ``` $ swift --version swift-driver version: 1.111.2 Apple Swift version 6.0 (swiftlang-6.0.0.5.15 clang-1600.0.22.6) Target: arm64-apple-macosx14.0 $ swift test Building for debugging... ld: warning: duplicate -rpath '/Applications/Xcode-16.0.0-Beta.3.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib' ignored [67/67] Linking IndexStorePackageTests Build complete! (7.53s) Test Suite 'All tests' started at 2024-07-11 13:12:09.222. Test Suite 'IndexStorePackageTests.xctest' started at 2024-07-11 13:12:09.223. Test Suite 'IndexStoreTests' started at 2024-07-11 13:12:09.223. Test Case '-[IndexStoreTests.IndexStoreTests testExerciseIndexStore]' started. Test Case '-[IndexStoreTests.IndexStoreTests testExerciseIndexStore]' passed (0.506 seconds). Test Case '-[IndexStoreTests.IndexStoreTests testMissingIndexStore]' started. Test Case '-[IndexStoreTests.IndexStoreTests testMissingIndexStore]' passed (0.000 seconds). Test Suite 'IndexStoreTests' passed at 2024-07-11 13:12:09.729. Executed 2 tests, with 0 failures (0 unexpected) in 0.506 (0.506) seconds Test Suite 'SwiftDemangleTests' started at 2024-07-11 13:12:09.729. Test Case '-[SwiftDemangleTests.SwiftDemangleTests testBreathFirstSequence]' started. Test Case '-[SwiftDemangleTests.SwiftDemangleTests testBreathFirstSequence]' passed (0.000 seconds). Test Case '-[SwiftDemangleTests.SwiftDemangleTests testDemangle]' started. Test Case '-[SwiftDemangleTests.SwiftDemangleTests testDemangle]' passed (0.000 seconds). Test Case '-[SwiftDemangleTests.SwiftDemangleTests testObjCUSR]' started. Test Case '-[SwiftDemangleTests.SwiftDemangleTests testObjCUSR]' passed (0.000 seconds). Test Case '-[SwiftDemangleTests.SwiftDemangleTests testSwiftExtensionUSR]' started. Test Case '-[SwiftDemangleTests.SwiftDemangleTests testSwiftExtensionUSR]' passed (0.000 seconds). Test Suite 'SwiftDemangleTests' passed at 2024-07-11 13:12:09.730. Executed 4 tests, with 0 failures (0 unexpected) in 0.001 (0.001) seconds Test Suite 'IndexStorePackageTests.xctest' passed at 2024-07-11 13:12:09.730. Executed 6 tests, with 0 failures (0 unexpected) in 0.507 (0.507) seconds Test Suite 'All tests' passed at 2024-07-11 13:12:09.730. Executed 6 tests, with 0 failures (0 unexpected) in 0.507 (0.508) seconds ``` This will fail on CI until it is updated to Swift 6. Signed-off-by: JP Simard <[email protected]>
jpsim
force-pushed
the
update-llvm-and-swift-files-for-swift-6
branch
2 times, most recently
from
6eadd9f
to
78f6b4c
Compare
|
I can't think of an easy way to support both Swift 5.x and 6.x at the same time. There are hard ways to do it, but I don't think it's worth it considering that consumers can pin to previous releases. Given that GitHub Action runners are notoriously very slow to support new Xcode versions, it may be necessary to skip some tests on CI in order to merge this once Swift 6 + Xcode 16 are officially released in a few weeks. I'll also do a final check with Xcode 16.0 GM before merging. Is that an acceptable approach to you @keith @marcosgriselli and other users of this project that I'm not aware of? |
|
I think supporting only Swift 6 for this is fine. especially for swift demangle which only ever supported the specific point release you were at too. tbh it's pretty fragile and maybe we should even have a runtime check that you're on the right version or something 😬 |
|
Anything preventing this from landing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated some files from https://github.com/apple/llvm-project and https://github.com/swiftlang/swift.
I'm not confident that I did this correctly, but the tests do pass and this does fix #60.
This will fail on CI until it is updated to Swift 6.