Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas version fix #51

Open
xandaau opened this issue Mar 21, 2024 · 0 comments
Open

Pandas version fix #51

xandaau opened this issue Mar 21, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@xandaau
Copy link
Collaborator

xandaau commented Mar 21, 2024

In the requirements we have pandas version >=0.24.0, however some code in Designer class (actually pivot_table method) crashes when pandas version is less than 1.3.0.

This is needed to be fixed, and can be done in two ways:

  1. Upgrade pandas version in requirements and check that everything is okay
  2. Rewrite code for pivot_table() and leave the appropriate version of the dependency as the older one

Short error snippet

get_empirical_table_sample_size
    report = report.pivot_table(
TypeError: pivot_table() got an unexpected keyword argument 'sort'
@xandaau xandaau added the bug Something isn't working label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant