Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model breaks NEURON CI #1

Open
JCGoran opened this issue Jul 16, 2024 · 2 comments
Open

Model breaks NEURON CI #1

JCGoran opened this issue Jul 16, 2024 · 2 comments

Comments

@JCGoran
Copy link

JCGoran commented Jul 16, 2024

I am getting this error when trying to run the model (also present in the CI, see for instance this run):

Error: new_seed used as both variable and function in file Gfluct.mod

We need to pick which one we want, the variable:

RANGE new_seed

or the function:

PROCEDURE new_seed(seed) { : procedure to set the seed

Considering neither the variable nor the function are used anywhere, I suggest we remove them, or at the very least rename one of them.

@ramcdougal
Copy link
Contributor

ramcdougal commented Jul 16, 2024

This is a very old file. The issue has to do with the NEURON 9.x changes. The solution for ModelDB:8115's version was to remove the RANGE.

My only hesitation is that there are commented out lines in [Depressing_Spinal_Motoneuron_Cell_Classes.py](https://github.com/ModelDBRepository/2017405/blob/601ca5c62793af858d32f235219323ca33ad5957/Depressing_Spinal_Motoneuron_Cell_Classes.py#L248) that attempted to use the RANGE variable. I'm unclear if the d1_r, d2_r etc strategies have any effect on the MOD files. @nrnhines do they?

@nrnhines
Copy link

I'd choose the PROCEDURE. The RANGE has no definition in the mod file and it is a good thing that an error is generated by the translator.

In 8.2, nowhere in the translated mod file is new_seed anything but a function. When I launch, consider the hoc code

create soma
objref gf
gf = new Gfluct(.5)
gf.newseed

will produce

nrniv: GFluct is not a template
 near line 7
 gf = new GFluct(.5)

So the commented out lines, when uncommented, don't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants