-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extension started spewing out in console #185
Comments
I believe this is the combination of 1 update we made to manage multiple Webui UIs at the same time, and a ComfyUI update. The error in itself comes from the workflow types not being registered to the extension. The error is not supposed to appear if the workflow types are registeted properly. As for the error that you get when dropping an image, this is probably a ComfyUI update yes. |
Thanks for the added context. Is there a reason why the comfy side-panel isn't hidden in the IFrame? Also, it's definitely weird that the default workflows are not loading for each workflow type on startup. (For loading workflows from A1111 generated images when drag and dropping, see #112) |
The side-panel started popping up there like that.
During handling of the above exception, another exception occurred: Traceback (most recent call last): [ComfyUI] Cannot import D:\WORK\conda_envs\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\NodeGPT module for custom nodes: No module named 'autogen'" So there are three packs that fail, though they work under bare Comfyui. |
I think this problem is caused by the extension not finding the venv your comfyui needs to work normally and falling back on the webui venv. Could you please share with us:
if you are using a conda env, we will have to add support for that. the extension currently only supports pip venvs with the |
Not using a conda env for comfyui, using a conda env for webui though. They just happen to both be downstream from a directory called conda_envs. This all worked up to about a month ago. Some node groups didn't load because they were clearly looking for stuff that doesn't exist in webui conda env. Now it just loads that workflow and shows the menu bar, while showing void to and from Webui nodes when added.
|
I will add |
The extension now checks for the portable python path location. After updating and making sure the dependencies of your custom nodes have been met in the portable python environment, let us know if you still run into issues using the extension. |
Updated and made sure dependencies are met in the portable python env. Thank you for looking into it.
|
Alright, I'll let you reinstall from scratch. Before doing that, could you please share the entire logs? I wonder if we could be missing a critical piece of information. i.e. the entire logs from the webui starting to finishing starting with the error after one attempted generation. |
https://pastebin.com/ksM0hkW8 Comfyui window looks like this throughout it, just like nothing was loaded from the metadata. I'll hold out on the re-install case something comes up. I tried to remove the extension and install it back but that didn't change anything. To clarify further, that: lib_comfyui.ipc.callback.RemoteError: '955c0d24-6a74-434c-9a97-841bb481f7b6'
|
Just to be sure, clicking on the "Reload ComfyUI interfaces (client side)" doesn't fix the problem, correct? Is there any error reported in the browser when you click on that button? Basically, the problem appears to be that the ui doesn't register the iframes with the backend for some reason. |
I just pushed a small update to the reload button that may give us more information, make sure to test this on the latest version of the extension. |
https://pastebin.com/7uSEvBgq
|
Yes, but what about the browser console? Are there errors in the browser (not the server, but i.e. chrome or firefox) after clicking on the reload button? |
https://pastebin.com/ghtMnLX6
|
Thanks. I see that the browser can't find any of the js files of the extension, which is why the iframes fail to load. Now we have to figure out why the server returns 404 on them. Do you know how to locate the current js files in your browser? Normally, you can press F12 -> go to the "Debugger" tab -> open any of the ComfyUI sections on the left. This is what I see under |
@ljleb all I got under the debugger that identifies the iframe is this: there are other entries connecting to same port on 127.0.0.1 but they don't highlight the element. |
For now I can't think of another piece of information that could help here. I tried to look into it a little bit with everything you shared, but to no avail so far. I think I'll need a bit more time to find a way to reproduce. I did find one or two improvements to the repo to commit but nothing that can fix this really. I'm sorry, I unfortunately have to focus on real life for the next week at least, but I should be able to check back here after. If anyone finds a solution and wants this fixed sooner, PRs are welcome. |
Maybe one last thing to try could be to toggle on/off the reverse proxy and restart fully the webui between each settings update. The reverse proxy intercepts js files and replaces some of the import paths to make comfyui js extensions work, so maybe it is related to the 404s. I'm not confident this will do anything but it's worth a try I think. |
Tried the options with a full restart between updates. Nothing changes though. It's always loading the side menu and the workflow. At least the node dependencies got fixed.
|
That's... interesting. Does it work if you temporarily disable every comfyui nodes? A quick way to do this is to use a completely new comfyui install location and then download comfyui using the extension or by manually cloning to that location. Maybe another thing to try at this point would be a factory install of the webui + sd-webui-comfyui + comfyui in another directory to see if the problem still occurs there. |
Somehow too much stuff in the updates made me miss your reply. Sorry.
|
I am still having this issue
|
Did the PR we merged today fix part of the issue? |
For the webui key error, restarting the UI (ctrl + F5) should do the job. Is that not working? You can't expect the UI to function properly if the key error is there, you NEED the Webui key to be registered by the extension when generating an image. |
On every generation, after it gets handed to the extension it borks with :
"*** Error running postprocess_batch_list: D:\WORK\conda_envs\automatic\stable-diffusion-webui\extensions\sd-webui-comfyui\scripts\comfyui.py
lib_comfyui.ipc.callback.RemoteError: '1d60c3da-0985-4724-95dd-80ddd2f87fa4'
---"
and trying to add the from webui and to webui doesn't work either, the nodes appear empty. This is on latest everything really.
Trying to drag an image with a comfy post-process in it results in an error.
Something changed, probably in comfy that's my guess.
The text was updated successfully, but these errors were encountered: