Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve "separation of concerns"(?) in protocol parsing #163

Open
MichaelClerx opened this issue Apr 21, 2020 · 2 comments
Open

Improve "separation of concerns"(?) in protocol parsing #163

MichaelClerx opened this issue Apr 21, 2020 · 2 comments
Labels
code-and-design Code style, architecture long term Low priority issues that need solving _eventuall_

Comments

@MichaelClerx
Copy link
Contributor

Still a bit of spaghetti between actions.py and protocol.py, mainly to do with merging.

Not sure how to resolve this!
@MichaelClerx MichaelClerx added the code-and-design Code style, architecture label Apr 21, 2020
@jonc125
Copy link
Contributor

jonc125 commented Apr 21, 2020

Roughly speaking, model interface merging happens in actions.py and other forms of merging between imported protocols happen in protocol.py.

If you have a concrete proposal to improve things, feel free to suggest it, otherwise I recommend closing this!

@MichaelClerx MichaelClerx added the long term Low priority issues that need solving _eventuall_ label Apr 21, 2020
@MichaelClerx
Copy link
Contributor Author

MichaelClerx commented Apr 21, 2020 •
edited
Loading

No concrete proposal as yet! But I'd like to make it so that

  • parsing/actions.py just contains parse actions, and information that can be gotten from the protocol specification alone
  • merging protocols is part of the parsing process, and doesn't depend on parser functions being called in the correct sequence from protocol.py (I don't think the protocol class should know how parsing works)
  • stuff that relies on combining a protocol with a model does not live inside the parsing module

@MichaelClerx MichaelClerx changed the title Protocol parsing Improve "separation of concerns"(?) in protocol parsing Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-and-design Code style, architecture long term Low priority issues that need solving _eventuall_
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichaelClerx @jonc125