Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster stimulus implementation #47

Closed
MichaelClerx opened this issue Sep 3, 2019 · 4 comments
Closed

Faster stimulus implementation #47

MichaelClerx opened this issue Sep 3, 2019 · 4 comments
Labels
long term Low priority issues that need solving _eventuall_

Comments

@MichaelClerx
Copy link
Contributor

Typically, the CellML version of a model includes a stimulus current.
This is essential a default protocol, and so it can be argued this should not be part of a model.

  • Note 1: The same holds for physical constants and physiological parameters such as temperature or membrane area: in a modular set-up these should really not be part of the cell model.
  • Note 2: In addition, most stimulus protocols are discontinuous, and consist of a small jump of 0.5, 1, or 2ms in a 1000ms period.
    Unless the solver somehow knows when these jumps are, simulations need to be run with a maximum step size of e.g. 1ms.
    This is inefficient during the systolic/refractory phase, where steps of over 100ms could otherwise be made.

Related to reset rules in CellML 2

@mirams
Copy link

mirams commented Sep 3, 2019

Yes, WL and Chaste have always stripped out the stimulus for this reason.

But I forbid the use of reset rules for the stimulus!

There is no need to go and do the extra work of a root finding adventure for this, which is how reset rules are implemented in the solvers. We do already know where the jumps are from the metadata so we can just run solve in a couple of steps, stopping and starting where we already know (a-priori) that the stimulus applies.

@MichaelClerx
Copy link
Contributor Author

Reset rules on the time variable won't be implemented with root finding. That would have to be handled differently

@MichaelClerx
Copy link
Contributor Author

MichaelClerx commented Sep 3, 2019

Anyway, I was only copying and pasting from earlier notes. CellML 2 won't be out before the end of the grant I'm sure wrong :D

@MichaelClerx MichaelClerx added the long term Low priority issues that need solving _eventuall_ label Apr 20, 2020
@MichaelClerx
Copy link
Contributor Author

Closing in favour of the older ticket #193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
long term Low priority issues that need solving _eventuall_
Projects
None yet
Development

No branches or pull requests

2 participants