Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to update with no registered fixers causes NPE #43

Open
i509VCB opened this issue Sep 25, 2019 · 0 comments
Open

Trying to update with no registered fixers causes NPE #43

i509VCB opened this issue Sep 25, 2019 · 0 comments

Comments

@i509VCB
Copy link

i509VCB commented Sep 25, 2019

So I was toying around with DFU and I discovered a bug while playing with Schemas to register my type references.

So if you create a DataFixer through the DataFixerBuilder and don't add a DataFix to any registered schema version (adding a DataFix to any schema fixes the issue), when you build and then update a Dynamic through the update method, you get an NPE from the DataFixer inside of private int getLowestFixSameVersion(final int versionKey) within DataFixerUpper at Line 115 where it checks for fixerVersions.

The intended functionality I thought would occur is the DFU would just pass out the Dynamic unchanged because there are no fixes at all to modify the Dynamic with, however the update seems to attempt to fix the data even if there are not any fixes to actually apply.

Sorry about the horrible wording it is about 10:45 at night here. Just ask me if you need any clarification about any more explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant