Defer again after initial defer has been completed #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlonicus
reviewed
Jan 17, 2023
| it('defers again after initial defer has completed', () => { | ||
| const DeferConditionally: React.FC<{ mountDeferred: boolean }> = ({ mountDeferred }) => { | ||
| return ( | ||
| <> |
There was a problem hiding this comment.
I would maybe add a print out of the useIsDeffering() hook value so you can verify that it's being set correctly, and then later run some expects on it. wdyt?
Suggested change
| <> | |
| <> | |
| <p>isDeferring: ${ useIsDeferring() }</p> |
There was a problem hiding this comment.
Makes sense to me! I fixed it in my latest commit. Tried to follow the convention already in place in other tests for checking this.
* Remove requestingToRun state, since it is no longer needed
|
@marlonicus As mentioned above, adjusted the test according to your feedback! I also want to mention that I removed the |
marlonicus
approved these changes
Jan 19, 2023
|
As we are deprecating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR the
<DeferredMountProvider/>would never defer again after initial deferring has been completed. In practice this meant that if a new child with a<DeferredMount/>or with a<DeferredMountWithCallback/>was mounted added after initial deferring was completed, theuseIsDeferring()hook would still returnfalse.This PR changes that behaviour and sets the defer state to
trueevery time a new child with<DeferredMount/>or<DeferredMountWithCallback/>is mounted. An example of where this behaviour would be useful and expected is when you have routing inside a<DeferredMountProvider/>.