Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Apache Maven to 3.9.8 #120

Open
piotrzarzycki21 opened this issue Jun 19, 2024 · 8 comments
Open

Update Apache Maven to 3.9.8 #120

piotrzarzycki21 opened this issue Jun 19, 2024 · 8 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@piotrzarzycki21
Copy link
Collaborator

I've been started to experience problem locally with building our Royale applications using Maven 3.6.0 which is part of SDK Installer. All builds on GH Actions are working, because they are using newest version of Maven.

https://maven.apache.org/download.cgi

@piotrzarzycki21 piotrzarzycki21 added the enhancement New feature or request label Jun 19, 2024
@piotrzarzycki21 piotrzarzycki21 added this to the v4.7.0 milestone Jun 19, 2024
@JoelProminic
Copy link
Contributor

If we update this, we'll want to go through and make sure all the project templates that use Maven can work with the newer version. See #99 for an example of the problems we had with Gradle.

Note that the Maven scripts are effectively broken on macOS for the Domino Visual Editor and Form Builder projects - this is an issue with the newer Notes client versions.

@piotrzarzycki21
Copy link
Collaborator Author

This so far influence Royale application itself, but as well Royale framework as well. If I will have to work on some fix in Royale I will need that update. However note that I already upgrade my local Maven to that version, so I'm good with that, but this is something which we will have to have on our radar.

Additionally doesn't hurt us to have this update in development version of SDK Installer 4.7.0.

rat-moonshine added a commit that referenced this issue Jun 20, 2024
Updating Maven version to 3.9.8 #120
@rat-moonshine
Copy link
Collaborator

rat-moonshine commented Jun 20, 2024

It's updated. Please give some tests, when a new build is available.

Were we shifted to build Development version with GHA? I don't see installer from https://static.moonshine-ide.com/downloads/msdki/dev/macos/ installs as "MoonshineSDKInstallerDevelopment" but "MoonshineSDKInstaller"!

@piotrzarzycki21
Copy link
Collaborator Author

Thanks @rat-moonshine for update! @Aszusz it was for purpose to have this like that ?

@piotrzarzycki21
Copy link
Collaborator Author

@rat-moonshine Installer installs as MoonshineSDKInstallerDevelopment on my system, so it's correct I believe.

@piotrzarzycki21
Copy link
Collaborator Author

I was able to successfully install and setup Maven 3.9.8

@rat-moonshine
Copy link
Collaborator

@rat-moonshine Installer installs as MoonshineSDKInstallerDevelopment on my system, so it's correct I believe.

It turned out that I had a MoonshineSDKInstallerDeveloment.app exists somewhere in my local build directory. By macOS' nature, any new installation keep updating that executable only, instead of installing at /Applications. Once removed that exec, new installation installs in correct location.

@JoelProminic
Copy link
Contributor

JoelProminic commented Jun 20, 2024

As I mentioned earlier, I'd like to do some tests with Maven 3.9.8 and the current Maven project templates so that we don't break those projects for new users.

Other things I'd like to check or discuss:

  • Will Moonshine automatically update to the newer version of Maven if it is installed? - UPDATE: No, it keeps the existing version. Do we need to change this, or are we fine with existing users updating manually
  • If the older version of Maven is installed, will MSKDI enable the install button for Maven? - UPDATE: Yes, I got the prompt to install the new version.

@JoelProminic JoelProminic reopened this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants