Some fixes to c421d72

Checkstyle fixes.

Author: immortius

config/checkstyle/suppressions.xml

@@ -6,4 +6,5 @@
 <suppressions>
     <suppress checks="." files="org[\\/]terasology[\\/]protobuf[\\/].*"/>
     <suppress checks="MethodNameCheck" files="org[\\/]terasology[\\/]engine[\\/]paths[\\/]windows.*"/>
+	<suppress checks="ParameterAssignment" files="org[\\/]terasology[\\/]math[\\/]TeraMath"/>
 </suppressions>

src/main/java/org/terasology/engine/GameThread.java

@@ -37,6 +37,9 @@ public final class GameThread {
     private static Thread gameThread;
     private static BlockingDeque<Runnable> pendingRunnables = Queues.newLinkedBlockingDeque();
 
+    private GameThread() {
+    }
+
     /**
      * @return Whether the currentThread is the gameThread.
      */

src/main/java/org/terasology/math/MatrixUtils.java

@@ -30,6 +30,9 @@
  */
 public final class MatrixUtils {
 
+    private MatrixUtils() {
+    }
+
     /**
      * Copies the given matrix into a newly allocated FloatBuffer.
      * The order of the elements is column major (as used by OpenGL).

src/main/java/org/terasology/math/Rect2i.java

@@ -17,15 +17,14 @@
 
 import com.google.common.collect.Lists;
 
-import java.util.ArrayList;
 import java.util.List;
 import java.util.Objects;
 
 /**
  * 2D Rectangle
  */
 // TODO: Review and bring into line with Region3i's api
-public class Rect2i {
+public final class Rect2i {
     public static final Rect2i EMPTY = new Rect2i();
 
     // position
@@ -184,6 +183,7 @@ public String toString() {
 
     /**
      * Returns the difference between a and b - that is all parts of a that are not contained by b.
+     *
      * @param a
      * @param b
      * @return A collection of rectangles that compose the difference of a - b. May be empty if a is completely encompassed by b.

src/main/java/org/terasology/math/Region3i.java

@@ -24,7 +24,7 @@
  *
  * @author Immortius
  */
-public class Region3i implements Iterable<Vector3i> {
+public final class Region3i implements Iterable<Vector3i> {
     public static final Region3i EMPTY = new Region3i();
 
     private final Vector3i min = new Vector3i();

src/main/java/org/terasology/math/TeraMath.java

@@ -163,7 +163,7 @@ public static int pow(int base, int exp) {
         if (exp <= 0) {
             // x^0 and 1/(1^x) for any x are the only cases where an integer could represent a non-zero value
             // 0^0 is an indetermination, but Integers provides no means to represent it
-            if (exp == 0) {
+            if (exp == 0 || base == 1) {
                 return 1;
             }
             return 0;
@@ -395,7 +395,8 @@ public static int calcChunkPosY(int y) {
     * @return The Y-coordinate of the chunk
     */
     public static int calcChunkPosY(int y, int chunkPowerY) {
-        return 0;//(y >> chunkPowerY);
+        return 0;
+        //return (y >> chunkPowerY);
     }
 
     /**

src/main/java/org/terasology/monitoring/gui/ChunkMonitorDisplay.java

@@ -43,7 +43,6 @@
 import java.awt.event.MouseWheelEvent;
 import java.awt.event.MouseWheelListener;
 import java.awt.image.BufferedImage;
-import java.util.HashMap;
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Map;

src/main/java/org/terasology/rendering/assets/font/Font.java

@@ -19,7 +19,6 @@
 import org.terasology.asset.Asset;
 import org.terasology.rendering.assets.material.Material;
 import org.terasology.rendering.assets.mesh.Mesh;
-import org.terasology.rendering.nui.Color;
 import org.terasology.rendering.nui.HorizontalAlignment;
 
 import java.util.List;

src/main/java/org/terasology/rendering/assets/font/FontDataBuilder.java

@@ -18,14 +18,7 @@
 import com.google.common.collect.Maps;
 import gnu.trove.map.TIntObjectMap;
 import gnu.trove.map.hash.TIntObjectHashMap;
-import org.terasology.asset.AssetType;
-import org.terasology.asset.AssetUri;
-import org.terasology.asset.Assets;
-import org.terasology.engine.Terasology;
-import org.terasology.engine.TerasologyConstants;
-import org.terasology.persistence.ModuleContext;
 import org.terasology.rendering.assets.material.Material;
-import org.terasology.rendering.assets.material.MaterialData;
 import org.terasology.rendering.assets.texture.Texture;
 
 import java.util.Map;

src/main/java/org/terasology/rendering/assets/font/FontLoader.java

@@ -20,9 +20,7 @@
 import org.terasology.asset.AssetType;
 import org.terasology.asset.AssetUri;
 import org.terasology.asset.Assets;
-import org.terasology.engine.TerasologyConstants;
 import org.terasology.engine.module.Module;
-import org.terasology.persistence.ModuleContext;
 import org.terasology.rendering.assets.material.Material;
 import org.terasology.rendering.assets.material.MaterialData;
 import org.terasology.rendering.assets.texture.Texture;