Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on trying to use shaping table #5143

Open
Miner34dev opened this issue Sep 27, 2023 · 3 comments
Open

Crash on trying to use shaping table #5143

Miner34dev opened this issue Sep 27, 2023 · 3 comments
Labels
Category: Crash Requests, Issues and Changes targeting unexpected terminations, segfaults, etc. Category: Gameplay Content Requests, Issues and Changes targeting gameplay mechanics and content Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Bug Issues reporting and PRs fixing problems

Comments

@Miner34dev
Copy link

Miner34dev commented Sep 27, 2023

General Info

Terasology Launcher Version: Linux X64 4.8.0
Terasology Version: 5.3.0 stable
Operating System: Garuda linux
Onboard / Dedicated Graphics: AMD Ryzen 3 5300U (no dedicated graphics)
Java Version: Launcher bundled

What you were trying to do

Using a shaping table in josharias survival.

What actually happened

Terasology crashed, the bug report window opened but i was unable to use it since my mouse pointer disappeared.

How to reproduce

  1. Select Terasology version 5.3.0
  2. Start Terasology
  3. Select gameplay josharias survival
  4. Start game
  5. Get a shaping table
  6. Use it
  7. See error (NullPointerException)

Log details

Here is the world's log (i hope it's the right one)
Terasology-Survivalworld.log

Additional Infos / Context

Please note that after restarting and crafting a new shaping table it worked without crashing.

@Miner34dev Miner34dev added Status: Needs Investigation Requires to be debugged or checked for feasibility, etc. Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Bug Issues reporting and PRs fixing problems labels Sep 27, 2023
@Miner34dev Miner34dev changed the title Crash/Bug on trying to ... Crash on trying to use shaping table Sep 27, 2023
@Miner34dev
Copy link
Author

Miner34dev commented Sep 27, 2023

Just happened again.
Anybody reproduced it?

@jdrueckert
Copy link
Member

Hi @Miner34dev,
thanks for reporting this, I can reproduce it based on the steps you shared 👍
NPE seems to come from our ManualLabor module:

java.lang.NullPointerException: null
	at org.terasology.manualLabor.processParts.SymmetricBlockOutputProcessPartCommonSystem.validateToStartExecution(SymmetricBlockOutputProcessPartCommonSystem.java:82)
	at org.terasology.manualLabor.processParts.SymmetricBlockOutputProcessPartCommonSystemMethodAccess.invoke(Unknown Source)
	at org.terasology.engine.entitySystem.event.internal.EventSystemImpl$ByteCodeEventHandlerInfo.invoke(EventSystemImpl.java:399)

More precisely, from SymmetricBlockOutputProcessPartCommonSystem#validateToStartExecution.
My working theory is that the slotAmountsComponent might not be properly initialized or something... wanted to check in an entity dump (in-game console dumpEntities), but it seems we have another bug there when on windows (see #5144)...
I'll need to check on my Linux, but won't get to that today, I'll comment once I have any updates.

@jdrueckert jdrueckert moved this to 🚀 Next Up (5.4.0) in Terasology Bugs Sep 27, 2023
@jdrueckert jdrueckert moved this to New (Inbox) in Terasology Inbox Sep 27, 2023
@jdrueckert
Copy link
Member

I can now confirm that with a shaping table placed in the world in a dump of all entities of the world, a InventoryInputProcessPartSlotAmountsComponent as trying to be fetched in SymmetricBlockOutputProcessPartCommonSystem.java line 81 is no where to be found which results in slotAmountsComponent being null which in turns results in the NPE when it's attempted to be accessed.

Having said that, it's unclear to me when this last worked and when it broke. With our current development capacities bound elsewhere, I don't think we'll fix this anytime soon.

@jdrueckert jdrueckert added Category: Gameplay Content Requests, Issues and Changes targeting gameplay mechanics and content Category: Crash Requests, Issues and Changes targeting unexpected terminations, segfaults, etc. and removed Status: Needs Investigation Requires to be debugged or checked for feasibility, etc. labels Sep 28, 2023
@jdrueckert jdrueckert moved this from 🚀 Next Up (5.4.0) to Backlog in Terasology Bugs Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Crash Requests, Issues and Changes targeting unexpected terminations, segfaults, etc. Category: Gameplay Content Requests, Issues and Changes targeting gameplay mechanics and content Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Bug Issues reporting and PRs fixing problems
Projects
Status: Backlog
Development

No branches or pull requests

2 participants