Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap for refactor and improvement of player movement code #5253

Open
engiValk opened this issue Jun 15, 2024 · 1 comment
Open

Roadmap for refactor and improvement of player movement code #5253

engiValk opened this issue Jun 15, 2024 · 1 comment
Assignees
Labels
Category: Doc Requests, Issues and Changes targeting javadoc and module documentation Status: Needs Discussion Requires help discussing a reported issue or provided PR

Comments

@engiValk
Copy link
Contributor

Motivation

  • Currently the player movement code is deprecated and has some issues in implementation that has caused movement issues. It is also been a while since it has had a bit of a tidy up.

Proposal

  • Going to rework the movement code and the MovementMode(STATE) enum to make it more extendable and generally easier to work with. Main focus is fixing the SWIMMING enum as currently it just lowers gravity to simulate more accurate buoyancy and to ensure no more issues arise from it.

Concerns

  • Might end up affecting networking side of things if it uses predictive movement but I will fix it as it comes up.

Task Breakdown

  • Replace the MovementMode enums with ones that are more extendable and don't constantly affect key character states like gravity.
@engiValk engiValk added Category: Doc Requests, Issues and Changes targeting javadoc and module documentation Status: Needs Discussion Requires help discussing a reported issue or provided PR labels Jun 15, 2024
@engiValk
Copy link
Contributor Author

I am going to handle this myself but just wanted this as an official things so others can see it, feel free to assign it to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Doc Requests, Issues and Changes targeting javadoc and module documentation Status: Needs Discussion Requires help discussing a reported issue or provided PR
Projects
Status: Next Milestone
Development

No branches or pull requests

1 participant