Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buying Store issues #376

Open
AtomixRO opened this issue Mar 11, 2024 · 2 comments
Open

Buying Store issues #376

AtomixRO opened this issue Mar 11, 2024 · 2 comments
Labels
Bug Something that is already regarded as completed not working how it should be.

Comments

@AtomixRO
Copy link

AtomixRO commented Mar 11, 2024

Describe the bug
B1 = buyer; B2 = Seller.
If B1 can only buy 1 jellopy if sets to 1 jellopy as B2 can only sell the maximum amount allowed by B1 otherwise he gets
image

Not a weight issue in max inventory items count or being OW from B1.

B1 should be able to buy as many items by just setting 1ea of any item until B1 is OW instead of 99 ea to get 99 ea. Once sold out, the store closes for B2, remains on B1 and can walk around.
Also B2 gets the message "gained xxx zeny" once the transaction is completed, should be B1 to receive this message and/or maybe another message for B2.

Screenshots (if applicable)

image

Packet/Client version
20130618

Browser/device info
Any

@AtomixRO AtomixRO added the Bug Something that is already regarded as completed not working how it should be. label Mar 11, 2024
@MrAntares
Copy link
Owner

I think the store itself works properly:

  • BUYER needs at least 1 item of what he wants to buy in the store, sets how many items he wants tu buy max and sets the zeny he gives. After this the store will open with the items, the price and the amounts he wants to buy (this is not the same s how many he has). Remember, he might not want to buy infinite amount so there is a limit of how many he wants. So far this works fine as I tested it.
  • SELLER check the store and see the item he can sell to the buyer. He can only sell so much the buyer has set as limit. This also works fine.

What I see as issue:

  • If an item reaches the limit, the counter turns into 0, but items with 0ea shouldn't be visible at all, so there is a missing hide here.
  • When the SELLER sells an item to the store, it remains visually in his inventory, so there should be an update on his inv that removes the sold items.

@AtomixRO
Copy link
Author

Gotcha, I really got confused this the following, I guess the feature itself lack some additional information as a first time user using Buying Store, when I see that the amount of Input Number of the item I want to buy is automatically set to the maximum number of the item I do possess in my inventory made me think that was the hard limit.
image

Is this of the behavior is on retail as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something that is already regarded as completed not working how it should be.
Projects
None yet
Development

No branches or pull requests

2 participants