Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shop InputBox input doesn't close together with the shop #386

Open
kontownik opened this issue Apr 14, 2024 · 0 comments
Open

Shop InputBox input doesn't close together with the shop #386

kontownik opened this issue Apr 14, 2024 · 0 comments
Labels
Bug Something that is already regarded as completed not working how it should be.

Comments

@kontownik
Copy link

kontownik commented Apr 14, 2024

Steps to reproduce:

  1. Open Tool Shop NPC
  2. Pick up Red Potion, InputBox for item count will pop up.
  3. Cancel Shop
    (issue: input remains)
  4. Click at "OK" at count InputBox.

Actual result:

Online.js?20240411e:577422 Uncaught TypeError: Cannot read properties of undefined (reading 'discountprice')
    at transferItem (Online.js?20240411e:577422:52)
    at InputBox.onSubmitRequest (Online.js?20240411e:577517:5)
    at UIComponent.validate (Online.js?20240411e:477513:9)
    at HTMLButtonElement.dispatch (Online.js?20240411e:5525:9)
    at elemData.handle (Online.js?20240411e:5201:28)

Expected result:

  • When shop is cancelled (step3) InputBox should be hidden as well. That's how RO client behave.
  • "Input name" placeholder should be change to dragged item name, Red Potion in this case.
@kontownik kontownik added the Bug Something that is already regarded as completed not working how it should be. label Apr 14, 2024
@kontownik kontownik changed the title Shop item count input doesn't close together with the shop Shop InputBox input doesn't close together with the shop Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something that is already regarded as completed not working how it should be.
Projects
None yet
Development

No branches or pull requests

1 participant