Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing custom lub execution support #464

Open
redpolline opened this issue Aug 24, 2024 · 1 comment
Open

Missing custom lub execution support #464

redpolline opened this issue Aug 24, 2024 · 1 comment
Labels
Missing Feature A feature that is not implemented yet by the client.

Comments

@redpolline
Copy link
Contributor

After commit e332233, we now have a lua interpreter in the tree.

However, we don't actually execute any lua code from the client data. Which has severe drawbacks:

  1. We need to manually load and parse various lua tables and convert them to JS in DBManager.js.
  2. Adding support for features that depend on lua code requires a lot of reinventing the wheel.
  3. We miss out on changes that occur in the lua code until someone updates our custom JS code manually.
  4. We lose compatibility with custom clients / translations that have made their own lua modifications.

What we need to do is replicate the lua environment expected by the lua scripts and to call the expected functions.

@redpolline redpolline added the Missing Feature A feature that is not implemented yet by the client. label Aug 24, 2024
@Danil0v3s
Copy link
Contributor

This would also be a good point to refactor and remove some, if not all, of the translated tables existing in JS. Since they're just representations of the lua tables anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing Feature A feature that is not implemented yet by the client.
Projects
None yet
Development

No branches or pull requests

2 participants