enable items not fully read warning by default

support 1.21.3

Author: MrKinau

src/main/java/systems/kinau/fishingbot/network/protocol/ProtocolConstants.java

@@ -142,7 +142,7 @@ public static String getVersionString(int protocolId) {
             case MC_1_20_3: return "1.20.3 / 1.20.4";
             case MC_1_20_5: return "1.20.5 / 1.20.6";
             case MC_1_21: return "1.21 / 1.21.1";
-            case MC_1_21_2: return "1.21.2";
+            case MC_1_21_2: return "1.21.2 / 1.21.3";
             default: return "Unknown version";
         }
     }
@@ -155,6 +155,7 @@ public static String getExactVersionString(int protocolId) {
             case MC_1_20: return "1.20.1";
             case MC_1_20_3: return "1.20.4";
             case MC_1_20_5: return "1.20.6";
+            case MC_1_21_2: return "1.21.3";
             default: return getVersionString(protocolId);
         }
     }
@@ -215,7 +216,9 @@ public static int getProtocolId(String versionString) {
             case "1.21":
             case "1.21.1":
             case "1.21 / 1.21.1": return MC_1_21;
-            case "1.21.2": return MC_1_21_2;
+            case "1.21.2":
+            case "1.21.3":
+            case "1.21.2 / 1.21.3": return MC_1_21_2;
             default: return MC_1_8;
         }
     }

src/main/java/systems/kinau/fishingbot/network/protocol/play/PacketInPlayerInventory.java

@@ -27,15 +27,13 @@ public void write(ByteArrayDataOutput out, int protocolId) throws IOException {
     @Override
     public void read(ByteArrayDataInputWrapper in, NetworkHandler networkHandler, int length, int protocolId) throws IOException {
         this.slotId = readVarInt(in);
-        if (FishingBot.getInstance().getConfig().isLogItemData()) {
+        if (FishingBot.getInstance().getConfig().isLogItemData())
             FishingBot.getLog().info("Start reading PacketInPlayerInventory slot");
-        }
         this.item = readSlot(in, protocolId, networkHandler.getDataComponentRegistry());
-        if (FishingBot.getInstance().getConfig().isLogItemData()) {
+        if (FishingBot.getInstance().getConfig().isLogItemData())
             FishingBot.getLog().info("End of reading PacketInPlayerInventory slot");
-            if (in.getAvailable() > 0)
-                FishingBot.getLog().warning("End of reading PacketInPlayerInventory has " + in.getAvailable() + " byte(s) left");
-        }
+        if (in.getAvailable() > 0)
+            FishingBot.getLog().warning("End of reading PacketInPlayerInventory has " + in.getAvailable() + " byte(s) left");
         FishingBot.getInstance().getCurrentBot().getEventManager().callEvent(new UpdateSlotEvent(0, Integer.valueOf(slotId).shortValue(), item));
     }
 }

src/main/java/systems/kinau/fishingbot/network/protocol/play/PacketInSetSlot.java

@@ -30,19 +30,16 @@ public void write(ByteArrayDataOutput out, int protocolId) { }
     @Override
     public void read(ByteArrayDataInputWrapper in, NetworkHandler networkHandler, int length, int protocolId) {
         this.windowId = Packet.readContainerIdSigned(in, protocolId);
-        if (protocolId >= ProtocolConstants.MC_1_17_1) {
+        if (protocolId >= ProtocolConstants.MC_1_17_1)
             readVarInt(in); // revision
-        }
         this.slotId = in.readShort();
-        if (FishingBot.getInstance().getConfig().isLogItemData()) {
+        if (FishingBot.getInstance().getConfig().isLogItemData())
             FishingBot.getLog().info("Start reading PacketInSetSlot slot");
-        }
         this.slot = readSlot(in, protocolId, networkHandler.getDataComponentRegistry());
-        if (FishingBot.getInstance().getConfig().isLogItemData()) {
+        if (FishingBot.getInstance().getConfig().isLogItemData())
             FishingBot.getLog().info("End of reading PacketInSetSlot slot");
-            if (in.getAvailable() > 0)
-                FishingBot.getLog().warning("End of reading PacketInSetSlot has " + in.getAvailable() + " byte(s) left");
-        }
+        if (in.getAvailable() > 0)
+            FishingBot.getLog().warning("End of reading PacketInSetSlot has " + in.getAvailable() + " byte(s) left");
         FishingBot.getInstance().getCurrentBot().getEventManager().callEvent(new UpdateSlotEvent(windowId, slotId, slot));
     }
 }

src/main/java/systems/kinau/fishingbot/network/protocol/play/PacketInWindowItems.java

@@ -31,9 +31,8 @@ public void write(ByteArrayDataOutput out, int protocolId) throws IOException {
     @Override
     public void read(ByteArrayDataInputWrapper in, NetworkHandler networkHandler, int length, int protocolId) throws IOException {
         this.windowId = readContainerIdUnsigned(in, protocolId);
-        if (protocolId >= ProtocolConstants.MC_1_17_1) {
+        if (protocolId >= ProtocolConstants.MC_1_17_1)
             readVarInt(in); // revision (whatever it is?) or arbitrary state id?
-        }
         this.slots = new ArrayList<>();
         int count = protocolId >= ProtocolConstants.MC_1_17_1 ? readVarInt(in) : in.readShort();
         if (FishingBot.getInstance().getConfig().isLogItemData())
@@ -50,7 +49,7 @@ public void read(ByteArrayDataInputWrapper in, NetworkHandler networkHandler, in
             if (FishingBot.getInstance().getConfig().isLogItemData())
                 FishingBot.getLog().info("End of reading PacketInWindowItems carriedItem");
         }
-        if (FishingBot.getInstance().getConfig().isLogItemData() && in.getAvailable() > 0)
+        if (in.getAvailable() > 0)
             FishingBot.getLog().warning("End of reading PacketInWindowItems has " + in.getAvailable() + " byte(s) left");
         FishingBot.getInstance().getCurrentBot().getEventManager().callEvent(new UpdateWindowItemsEvent(windowId, slots));
     }