Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflowing Image on survivor builds #5

Open
deffy92 opened this issue May 4, 2024 · 1 comment
Open

Overflowing Image on survivor builds #5

deffy92 opened this issue May 4, 2024 · 1 comment
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@deffy92
Copy link

deffy92 commented May 4, 2024

Describe the bug
The image is overflowing the parent container. Adding overflow: hidden; fixes it.

Screenshots
Showcasing the overflow, going out of bounds of the parent div.
image

How it looks with overflow hidden, via web inspector.
image

Device information
Only tested in Firefox

Extra

If you want me to make a PR on this I wouldn't mind it.

@deffy92 deffy92 added the bug Something isn't working label May 4, 2024
@MrTipson
Copy link
Owner

MrTipson commented May 4, 2024

The implementation for images is a bit cursed back from when I wanted to have a nice way to overlay christmas hats on top of killer portraits. I'm aware that this Nea image overflows but I've opted to leave it in since I think it looks kinda cool. At this time, I don't think I'll change it, but I'll keep this in mind if more people find this problematic in the future.

Note: I probably wouldn't use overflow: hidden; for this, since overflow is usually just a symptom of layout issues. I'd most likely revert it to the way I had it done in b6f2939 (if that still works fine).

@MrTipson MrTipson added the wontfix This will not be worked on label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants