You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The implementation for images is a bit cursed back from when I wanted to have a nice way to overlay christmas hats on top of killer portraits. I'm aware that this Nea image overflows but I've opted to leave it in since I think it looks kinda cool. At this time, I don't think I'll change it, but I'll keep this in mind if more people find this problematic in the future.
Note: I probably wouldn't use overflow: hidden; for this, since overflow is usually just a symptom of layout issues. I'd most likely revert it to the way I had it done in b6f2939 (if that still works fine).
Describe the bug
The image is overflowing the parent container. Adding
overflow: hidden;
fixes it.Screenshots
![image](https://private-user-images.githubusercontent.com/6856243/327955773-af1408b4-63a2-4cf4-bb0c-716eccaf16b9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4MzkwNDAsIm5iZiI6MTczODgzODc0MCwicGF0aCI6Ii82ODU2MjQzLzMyNzk1NTc3My1hZjE0MDhiNC02M2EyLTRjZjQtYmIwYy03MTZlY2NhZjE2YjkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDZUMTA0NTQwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MjY2MmQ5NTU4YzNkMWVhYTE3MjY2ZmNlMTJmNGNiN2JkMDYwODRmYzlmMTk3NDY1ZTk4OWQxOGVhOTllNDExMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.0NIpz8QGnu_yU7PcgtxIQxrMsQcTrkrECa2jpLzCiRM)
Showcasing the overflow, going out of bounds of the parent div.
How it looks with overflow hidden, via web inspector.
![image](https://private-user-images.githubusercontent.com/6856243/327955887-e0f466a6-1ac6-4bde-8a15-0d8fb01fac41.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4MzkwNDAsIm5iZiI6MTczODgzODc0MCwicGF0aCI6Ii82ODU2MjQzLzMyNzk1NTg4Ny1lMGY0NjZhNi0xYWM2LTRiZGUtOGExNS0wZDhmYjAxZmFjNDEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDZUMTA0NTQwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YjNmN2M4YjQxMjdiZWZlOWNkMmY3MzNhOThjZTc0Mjk2NDJjYzVlNTllZWNiODM2ZDAxZjYxZjVmZjJlMmY4NSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.e9uWm5queEHM_AveTHtmS9ixSyWiHCaXGV_881CIX78)
Device information
Only tested in Firefox
Extra
If you want me to make a PR on this I wouldn't mind it.
The text was updated successfully, but these errors were encountered: