Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalising avatar textures programatically #1

Open
calummackervoy opened this issue May 3, 2023 · 1 comment
Open

Normalising avatar textures programatically #1

calummackervoy opened this issue May 3, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@calummackervoy
Copy link
Member

In Avatar.gd there is a function init_new_player, which initialises a new player with (amongst other things) their portrait

Currently all portraits are 512*512 in PNG format and the code takes advantage of that

In order to accept portraits from the internet we should accept different sizes (although it's OK to put some restrictions like filetype on the portrait). So the code here needs to be adapted based on the image size

Ideally we would also place a circular filter on the image so that they're always round although this might be easier in JavaScript

@calummackervoy calummackervoy added the enhancement New feature or request label May 3, 2023
@calummackervoy
Copy link
Member Author

This need is repeated for the sprite in objects/cards/Card.gd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant