Duration Parser Fix. #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Straight from a GithubCopilot breakdown of the RegEx (because I'm too lazy):
```dart
\((\d{1,2}:\d{2})\)
```
1. `\(` and `\)`: These match the literal parentheses `(` and `)`. The backslashes `\` are escape characters that indicate the parentheses should be treated as literal characters rather than special regex characters.
2. `(\d{1,2}:\d{2})`: This is a capturing group that matches the time format. Let's break this down further:
- `\d{1,2}`: This matches one or two digits, representing the hour part of the time. `\d` is a shorthand for any digit (0-9), and {1,2} specifies that it should match between one and two digits.
- `:`: This matches the literal colon `:` character, which separates the hours and minutes.
- `\d{2}`: This matches exactly two digits, representing the minute part of the time.
In summary, this regex matches a time in the format of HH:MM or H:MM enclosed in parentheses. For example, it would match (12:34) or (9:45).
I removed the `\(` & `\)` so it parses time without the literal parantheses.
`https://music.youtube.com/watch?v=X6km003df74` returns album titles as artist instead of artists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Straight from a GithubCopilot breakdown of the RegEx (because I'm too lazy):
\((\d{1,2}:\d{2})\)\(and\): These match the literal parentheses(and). The backslashes\are escape characters that indicate the parentheses should be treated as literal characters rather than special regex characters.(\d{1,2}:\d{2}): This is a capturing group that matches the time format. Let's break this down further:\d{1,2}: This matches one or two digits, representing the hour part of the time.\dis a shorthand for any digit (0-9), and {1,2} specifies that it should match between one and two digits.:: This matches the literal colon:character, which separates the hours and minutes.\d{2}: This matches exactly two digits, representing the minute part of the time.In summary, this regex matches a time in the format of HH:MM or H:MM enclosed in parentheses. For example, it would match (12:34) or (9:45).
I removed the
\(&\)so it parses time without the literal parantheses.