Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: remove direct volume control from Skill #107

Open
krisgesling opened this issue Dec 30, 2020 · 1 comment
Open

Refactor: remove direct volume control from Skill #107

krisgesling opened this issue Dec 30, 2020 · 1 comment

Comments

@krisgesling
Copy link
Contributor

Currently the Alarm Skill directly manipulates the volume via ALSA. This should be done by emitting the relevant messages on the Mycroft Message bus so that each platform can handle the volume in its own specific way. At the very least this should be handled by the Volume Skill, not the Alarm Skill.

The volume control messages can be found at:
https://mycroft-ai.gitbook.io/docs/mycroft-technologies/mycroft-core/message-types#volume-control

@Mabenan
Copy link

Mabenan commented Jul 11, 2022

In my opinion the volume shouldn't be changed at all by an alarm skill.
Or at least it should be an option.

The rest of it is true. Especially as the handling of the Mixer is different in this skill as it is in the Volume Skill. which also lacks some soundhardware on a pi but this is again another story.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants