Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Play the XXX news" does not work as expected #129

Open
denics opened this issue May 5, 2022 · 4 comments
Open

"Play the XXX news" does not work as expected #129

denics opened this issue May 5, 2022 · 4 comments

Comments

@denics
Copy link
Contributor

denics commented May 5, 2022

Hi al,
in the examples, and in the code, it seems possible to ask mycroft to play the news from a specific source (my wife is spanish and I am italian, you can imagine).
However, I cannot make mycroft play any news if not from the default one, at least, in italian. I could not even find the intent for that.

@denics denics added the bug label May 5, 2022
@krisgesling
Copy link
Contributor

Hey Denics,

Apologies for the slow response, I've been away a bit and catching up on things.

For phrases like "play the XXX news" this is routed through the Common Play System (CPS). It calls the CPS_match_query_phrase() method on all CPS registered Skills, and they report back their confidence that they have the thing the user wants to play.

In this case it's using this function to match names:

def match_station_from_utterance(skill, utterance):

So potentially there's something in there that's not working for translated strings? or it's not matching on the station name/acronym correctly. If you have specific example phrases (in Italian) we could add some unit tests to get a better idea of what's happening.

@denics
Copy link
Contributor Author

denics commented Jun 7, 2022

Ok, but then that means that we will never have a correspondence in languages other than en-us. For example in Italian it should be able to play:

  • "(dimmi|dammi) le (ultime|) notizie da RNE" - "play the RNE news" - and it should start playing RNE radio

A dream would be to be able to say:

  • "(dimmi|dammi|quali sono) le (ultime|) notizie dalla Spagna" - "play the news from Spain" and it should start playing RNE radio

Thanks and sorry for pestering you, I know you are busy with Mark II, and I am really looking forward to it, this is why I decided to get my hands dirty :)

@krisgesling
Copy link
Contributor

No that should definitely be possible.

The first one sounds like we just need to get the translations mapped correctly. It might be as simple as adding dimmi and dammi to give.voc?
This is actually separate to what I outlined above. It's a direct intent registered to this Skill rather than going through the Common Play disambiguation process.

The second form isn't something that is supported yet but is a great idea.

Not sure exactly when we'll get to it, but I've added a help wanted label just in case.

@denics
Copy link
Contributor Author

denics commented Oct 31, 2022

Hi @krisgesling I am a bit frustrated here. I tried to make my picroft tell me the Italian news in many way, but with no success :(
I don't know how to ask to read the news from RG1 in Italian and I cannot override the skill configuration (why???).
Can you help me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants