Move balance_changes to scope

Author: tpham-mysten

crates/sui-indexer-alt-graphql/src/api/types/transaction_effects.rs

@@ -221,8 +221,8 @@ impl EffectsContents {
         let limits = pagination.limits("TransactionEffects", "balanceChanges");
         let page = Page::from_params(limits, first, after, last, before)?;
 
-        // First try to get balance changes from execution context
-        if let Some(grpc_balance_changes) = content.balance_changes() {
+        // First try to get balance changes from execution context (scope)
+        if let Some(grpc_balance_changes) = self.scope.balance_changes() {
             return page
                 .paginate_indices(grpc_balance_changes.len(), |i| {
                     BalanceChange::from_grpc(self.scope.clone(), &grpc_balance_changes[i])

crates/sui-indexer-alt-graphql/src/scope.rs

@@ -58,6 +58,9 @@ pub(crate) struct Scope {
     /// This enables any Object GraphQL type to access fresh data without database queries.
     execution_objects: ExecutionObjectMap,
 
+    /// Balance changes from the executed transaction, only available in execution context.
+    balance_changes: Option<Vec<grpc::BalanceChange>>,
+
     /// Access to packages for type resolution.
     package_store: Arc<dyn PackageStore>,
 
@@ -77,6 +80,7 @@ impl Scope {
             checkpoint_viewed_at: Some(watermark.high_watermark().checkpoint()),
             root_version: None,
             execution_objects: Arc::new(BTreeMap::new()),
+            balance_changes: None,
             package_store: package_store.clone(),
             resolver_limits: limits.package_resolver(),
         })
@@ -90,6 +94,7 @@ impl Scope {
             checkpoint_viewed_at: Some(checkpoint_viewed_at),
             root_version: self.root_version,
             execution_objects: Arc::clone(&self.execution_objects),
+            balance_changes: self.balance_changes.clone(),
             package_store: self.package_store.clone(),
             resolver_limits: self.resolver_limits.clone(),
         })
@@ -101,6 +106,7 @@ impl Scope {
             checkpoint_viewed_at: self.checkpoint_viewed_at,
             root_version: Some(root_version),
             execution_objects: Arc::clone(&self.execution_objects),
+            balance_changes: self.balance_changes.clone(),
             package_store: self.package_store.clone(),
             resolver_limits: self.resolver_limits.clone(),
         }
@@ -112,6 +118,7 @@ impl Scope {
             checkpoint_viewed_at: self.checkpoint_viewed_at,
             root_version: None,
             execution_objects: Arc::clone(&self.execution_objects),
+            balance_changes: self.balance_changes.clone(),
             package_store: self.package_store.clone(),
             resolver_limits: self.resolver_limits.clone(),
         }
@@ -163,7 +170,12 @@ impl Scope {
             .and_then(|(_, opt)| opt.as_ref())
     }
 
-    /// Create a nested scope with execution objects extracted from an ExecutedTransaction.
+    /// Get balance changes from execution context, if available.
+    pub(crate) fn balance_changes(&self) -> Option<&[grpc::BalanceChange]> {
+        self.balance_changes.as_deref()
+    }
+
+    /// Create a nested scope with execution objects and balance changes extracted from an ExecutedTransaction.
     pub(crate) fn with_executed_transaction(
         &self,
         executed_transaction: &grpc::ExecutedTransaction,
@@ -174,6 +186,7 @@ impl Scope {
             checkpoint_viewed_at: None,
             root_version: self.root_version,
             execution_objects,
+            balance_changes: Some(executed_transaction.balance_changes.clone()),
             package_store: self.package_store.clone(),
             resolver_limits: self.resolver_limits.clone(),
         })

crates/sui-indexer-alt-reader/src/kv_loader.rs

@@ -54,7 +54,6 @@ pub enum TransactionContents {
         events: Option<Vec<Event>>,
         transaction_data: Box<TransactionData>,
         signatures: Vec<GenericSignature>,
-        balance_changes: Vec<grpc::BalanceChange>,
     },
 }
 
@@ -241,15 +240,11 @@ impl TransactionContents {
             .transpose()?
             .map(|events: TransactionEvents| events.data);
 
-        // Extract balance changes from the gRPC response
-        let balance_changes = executed_transaction.balance_changes.clone();
-
         Ok(Self::ExecutedTransaction {
             effects: Box::new(effects),
             events,
             transaction_data: Box::new(transaction_data),
             signatures,
-            balance_changes,
         })
     }
 
@@ -316,15 +311,6 @@ impl TransactionContents {
         }
     }
 
-    pub fn balance_changes(&self) -> Option<Vec<grpc::BalanceChange>> {
-        match self {
-            Self::ExecutedTransaction {
-                balance_changes, ..
-            } => Some(balance_changes.clone()),
-            _ => None,
-        }
-    }
-
     pub fn raw_transaction(&self) -> anyhow::Result<Vec<u8>> {
         match self {
             Self::Pg(stored) => Ok(stored.raw_transaction.clone()),