Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile-time enforce to the right OTEL version #29

Open
thomaseizinger opened this issue Mar 7, 2024 · 2 comments
Open

Compile-time enforce to the right OTEL version #29

thomaseizinger opened this issue Mar 7, 2024 · 2 comments

Comments

@thomaseizinger
Copy link
Contributor

It would be nice if we could change the API to be forced to pass a type from the otel-sdk crate somewhere to ensure we get a compile-error when there is a version mismatch.

Currently, things will just silently break if you bump one version but not the other :(

@thomaseizinger thomaseizinger changed the title Compile-time link to the right OTEL version Compile-time enforce to the right OTEL version Mar 7, 2024
@0xcypher02
Copy link

This silent failure caused us to have issues for a while. We've been trying to figure out a way to enforce this at compile time (or allow the user to pass in a specific OtelData TypeId, but it's difficult without tracing-subscriber changes. Curious to hear if you resolved in another way (we just bumped version on our fork).

@thomaseizinger
Copy link
Contributor Author

This silent failure caused us to have issues for a while. We've been trying to figure out a way to enforce this at compile time (or allow the user to pass in a specific OtelData TypeId, but it's difficult without tracing-subscriber changes. Curious to hear if you resolved in another way (we just bumped version on our fork).

I played around with this for a while but also couldn't get anything meaningful to work. So far, I've enforced it manually in the dependency bumps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants