Minor cleanups needed.

[blychs]

I have been finding some hardocded stuff that seems unnecessary.
E. g., in the plotting method of the analysis class, the following is hardcoded:

                        if obsvar == 'nitrogendioxide_tropospheric_column':
                            modvar = modvar + 'trpcol'

however, this is because the current pairing code in TROPOMI forces that trpcol into the modvar, but that does not happen for any other satellite.
I believe that this is unncessarily complicated, and can be cleaned up by changing the modvar when doing the pairing instead of here, so that it does not affect the following code anymore.

Let me know your thoughts, @mlirenzhenmayi

Cheers
Pablo

[mlirenzhenmayi]

Hi Pablo, OK, I see. I think it makes sense to clean up the hardcoded stuff, as long as it doesn't affect the functions. Thanks for looking into it, Meng

…

On Wed, Nov 12, 2025 at 12:38 PM Pablo Lichtig ***@***.***> wrote: *blychs* created an issue (NCAR/MELODIES-MONET#391) <#391> I have been finding some hardocded stuff that seems unnecessary. E. g., in the plotting method of the analysis class, the following is hardcoded: if obsvar == 'nitrogendioxide_tropospheric_column': modvar = modvar + 'trpcol' however, this is because the current pairing code in TROPOMI forces that trpcol into the modvar, but that does not happen for any other satellite. I believe that this is unncessarily complicated, and can be cleaned up by changing the modvar when doing the pairing instead of here, so that it does not affect the following code anymore. Let me know your thoughts, @mlirenzhenmayi <https://github.com/mlirenzhenmayi> Cheers Pablo — Reply to this email directly, view it on GitHub <#391>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AS6MKRY4PS4WVBNJNRTR3XD34OEEZAVCNFSM6AAAAACL5ONG7KVHI2DSMVQWIX3LMV43ASLTON2WKOZTGYYTOOJUGU4TENY> . You are receiving this because you were mentioned.Message ID: ***@***.***>