Initial configuration of Codee Fortran formatter with examples (src/*.F90)
#707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climbfuji
commented
Dec 8, 2025
climbfuji
commented
Dec 8, 2025
climbfuji
commented
Dec 8, 2025
climbfuji
commented
Dec 8, 2025
climbfuji
commented
Dec 8, 2025
climbfuji
requested review from
dustinswales,
gold2718,
grantfirl,
mkavulich and
peverwhee
as code owners
climbfuji
commented
Dec 8, 2025
Member
dustinswales
left a comment
dustinswales
left a comment
There was a problem hiding this comment.
@climbfuji Thanks for incorporating the code formatter here!
I love the idea, we just need to decide on a few details and incorporate this into our workflows.
As a github action, running the formatter could be invoked either diagnostically (report format violations) or prognostically (fix format violations).
peverwhee
reviewed
Dec 15, 2025
climbfuji
commented
Jan 5, 2026
climbfuji
changed the title
src/*.F90)src/*.F90)
dustinswales
approved these changes
Jan 8, 2026
peverwhee
approved these changes
Jan 9, 2026
Collaborator
|
@climbfuji This PR has merge conflicts that need to be resolved, then it can be merged |
Collaborator
Author
On it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial configuration of Codee Fortran formatter with examples (
src/*.F90).This PR adds an initial
.codee-formatconfiguration file for the free Codee Fortran formatter and a temporary scriptrun_codee_tmp.shto get started with the tool (note that the day-to-day usage will be much simpler than in the script). The PR also demonstrates the effect of the formatting rules for the four Fortran source files insrc/.The goal of this PR is to provide the necessary information to decide on the formatting rules we want to use. Once we have agreed on the format, we can update the
src/*.F90files as needed and merge this PR. The integration with GitHub actions and the simplified usage on the command line will come after that. In a 3rd PR, we will work on a tighter integration of the codee format config with the capgen Fortran write to make sure that the auto-generated code also complies with the formatting rules.The majority of the diffs are because NEPTUNE (and UFS) use two whitespaces as indentation, whereas the files in
src/currently use 3 whitespaces. We can change the codee config, but every space we save makes the lines shorter. To see the remaining differences, please select "Hide whitespaces" when looking at the files changed.User interface changes?: No
Working toward #703
Testing: No changes to the tests - GitHub actions CI tests passed
test removed:
unit tests:
system tests:
manual testing: