Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wet canopy fraction is incorrectly a function of vegetation fraction #91

Open
barlage opened this issue Jun 7, 2023 · 1 comment
Open

wet canopy fraction is incorrectly a function of vegetation fraction #91

barlage opened this issue Jun 7, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@barlage
Copy link
Collaborator

barlage commented Jun 7, 2023

The partitioning of precipitation in precip_heat/CanopyWaterIntercept is scaled by fveg/VegFrac early in the module, but maxliq/CanopyLiqWaterMax (and similar for snow) are not scaled by fveg/VegFrac. This causes a dependence of fwet/CanopyWetFrac on vegetation fraction. I see two possible solutions:

  1. the easy one is to scale capacity by vegetation fraction (I have tested this and it does solve the issue)
  2. multiply by vegetation fraction later when water is input to the soil

I like solution 2 better since it is clearer to understand and the canopy water would be a physical value that is actually on the leaf and not spread across the grid.
@tslin2 tslin2 added the bug Something isn't working label Jun 8, 2023
@tslin2 tslin2 mentioned this issue Jun 10, 2023
Closed
@tslin2 tslin2 linked a pull request Jun 10, 2023 that will close this issue
green vegetation fraction scaling of max canopy capacity of rain & snow intercept #93
Closed
This was referenced Jun 27, 2023
Closed
Merged
cenlinhe added a commit that referenced this issue Sep 19, 2023
@cenlinhe
bug fix for VegFrac scaling, issue #91-92
a7dd399
@cenlinhe
Copy link
Collaborator

I have fixed this issue using the easy quick solution in this commit in release-v4.5-WRF branch: 0fd17e5
The fix in v5.0 (included in release-v5.0.1) is in this commit: a7dd399

@jesusff jesusff mentioned this issue Oct 19, 2023
Open
jesusff added a commit to CORDEX-WRF-community/noahmp that referenced this issue Oct 19, 2023
@jesusff
Merge branch 'release-v4.5-WRF' of github.com:NCAR/noahmp into v4.5.1…
5fe2e72 
…-devel

To include fixes for NCAR#91, NCAR#92, SLUCM ground flux and snow combination layer index
@cenlinhe cenlinhe mentioned this issue Oct 22, 2023
Merged
weiwangncar pushed a commit to wrf-model/WRF that referenced this issue Jan 13, 2024
@cenlinhe
Bug fix for Noah-MP snow, vegetation and urban (#1929)
ce1069f 
TYPE: bug fix

KEYWORDS: Noah-MP, snow combine, vegetation fraction scaling, urban ground heat flux

SOURCE: Cenlin He (NCAR/RAL)

DESCRIPTION OF CHANGES:
There are a few bug fixes for Noah-MP related processes:
(1) the snow layer index in snow COMBINE module was wrong, causing model crash when snow layer changes by more than 1 layer within one timestep; This has been fixed by using the correct layer index. 
(2) the ground heat flux sign in Noah-MP column model (positive: downward) is inconsistent with that in urban canopy model (positive: upward), leading to wrong diagnostic grid-mean ground heat flux calculation for urban grid. This only affects the diagnostic value for output. See this issue: #1921 and NCAR/hrldas#114
(3) there is a bug in vegetation fraction (FVEG) scaling for stomata resistance calculation (NCAR/noahmp#92) and canopy interception calculation (NCAR/noahmp#91).

LIST OF MODIFIED FILES: list of changed files (use `git diff --name-status master` to get formatted list):
phys/noahmp/src/module_sf_noahmplsm.F
phys/noahmp/src/module_sf_noahmpdrv.F

TESTS CONDUCTED: 
1. Tested successfully in NCAR Cheyenne HPC for 13-km run over the entire CONUS region
2. The Jenkins tests are all passing.

RELEASE NOTE:  Noah-MP bug fix for snow combination, vegetation fraction scaling, and urban ground heat flux sign.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

green vegetation fraction scaling of max canopy capacity of rain & snow intercept tslin2/noahmp
3 participants
@barlage @cenlinhe @tslin2