feat: Use GetRequiredService instead of GetService to resolve jobs (#24)

* Use GetRequiredService instead of GetService and added tests

* Removed redundant test

* Added entry in changelog

* Remove empty line in NCronJobIntegrationTests.cs

* Update CHANGELOG.md

Co-authored-by: Steven Giesel <[email protected]>

---------

Co-authored-by: Steven Giesel <[email protected]>

Author: skarum

CHANGELOG.md

@@ -9,6 +9,7 @@ All notable changes to **NCronJob** will be documented in this file. The project
 ### Changed
 
 - Implementation of the scheduling. Better performance and closed some memory leaks
+- Throw exception if job cannot be resolved with dependencies from the DI container. Reported and implemented by [@skarum](https://github.com/skarum) in [#23)(https://github.com/linkdotnet/NCronJob/issues/23)
 
 ## [2.0.4] - 2024-04-16
 

src/LinkDotNet.NCronJob/Execution/JobExecutor.cs

@@ -27,11 +27,7 @@ public void RunJob(RegistryEntry run, CancellationToken stoppingToken)
         }
 
         var scope = serviceProvider.CreateScope();
-        if (scope.ServiceProvider.GetService(run.Type) is not IJob job)
-        {
-            LogJobNotRegistered(run.Type);
-            return;
-        }
+        var job = (IJob)scope.ServiceProvider.GetRequiredService(run.Type);
 
         ExecuteJob(run, job, scope, stoppingToken);
     }

tests/NCronJob.Tests/NCronJobIntegrationTests.cs

@@ -3,6 +3,7 @@
 using LinkDotNet.NCronJob;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Hosting;
+using Microsoft.Extensions.Logging.Abstractions;
 using Shouldly;
 using TimeProviderExtensions;
 
@@ -154,6 +155,7 @@ public async Task NotRegisteredJobShouldNotAbortOtherRuns()
         var fakeTimer = TimeProviderFactory.GetTimeProvider();
         ServiceCollection.AddSingleton<TimeProvider>(fakeTimer);
         ServiceCollection.AddNCronJob(n => n.AddJob<SimpleJob>(p => p.WithCronExpression("* * * * *")));
+        ServiceCollection.AddTransient<ParameterJob>();
         var provider = CreateServiceProvider();
         provider.GetRequiredService<IInstantJobRegistry>().RunInstantJob<ParameterJob>();
 
@@ -163,6 +165,20 @@ public async Task NotRegisteredJobShouldNotAbortOtherRuns()
         jobFinished.ShouldBeTrue();
     }
 
+    [Fact]
+    public void ThrowIfJobWithDependenciesIsNotRegistered()
+    {
+        ServiceCollection
+            .AddNCronJob(n => n.AddJob<JobWithDependency>(p => p.WithCronExpression("* * * * *")));
+        var provider = CreateServiceProvider();
+
+        Assert.Throws<InvalidOperationException>(() =>
+        {
+            using var executor = new JobExecutor(provider, NullLogger<JobExecutor>.Instance);
+            executor.RunJob(new RegistryEntry(typeof(JobWithDependency), new JobExecutionContext(null), null), CancellationToken.None);
+        });
+    }
+
     private sealed class GuidGenerator
     {
         public Guid NewGuid { get; } = Guid.NewGuid();
@@ -202,4 +218,10 @@ private sealed class ParameterJob(ChannelWriter<object> writer) : IJob
         public async Task RunAsync(JobExecutionContext context, CancellationToken token)
             => await writer.WriteAsync(context.Parameter!, token);
     }
+
+    private sealed class JobWithDependency(ChannelWriter<object> writer, GuidGenerator guidGenerator) : IJob
+    {
+        public async Task RunAsync(JobExecutionContext context, CancellationToken token)
+            => await writer.WriteAsync(guidGenerator.NewGuid, token);
+    }
 }